Use .then(null, Cu.reportError); with Promise.jsm

2013-08-09 Thread Paolo Amadini
This is a quick reminder to anyone writing or reviewing code that uses Promise.jsm. You should check that exceptions aren't swallowed, and this is typically done with a logging rejection handler. You should always use the handler unless you're handing off the promise to other code. For some

Re: Use .then(null, Cu.reportError); with Promise.jsm

2013-08-09 Thread Neil
Paolo Amadini wrote: This is a quick reminder to anyone writing or reviewing code that uses Promise.jsm. How do the other promise implementations in the tree compare in this respect? (For instance I suspect it might be feasible for DOM promises to report any pending exception when they

Re: Use .then(null, Cu.reportError); with Promise.jsm

2013-08-09 Thread Boris Zbarsky
On 8/9/13 5:54 AM, Neil wrote: (For instance I suspect it might be feasible for DOM promises to report any pending exception when they get garbage collected.) Oh, that is a _very_ interesting idea. I wonder whether we can get that specced, or at least allowed by the spec. -Boris

Re: Use .then(null, Cu.reportError); with Promise.jsm

2013-08-09 Thread Anne van Kesteren
On Fri, Aug 9, 2013 at 2:08 PM, Boris Zbarsky bzbar...@mit.edu wrote: Oh, that is a _very_ interesting idea. I wonder whether we can get that specced, or at least allowed by the spec. If it's just to the error console, we can do whatever we want. Do you have something else in mind? --

Re: Use .then(null, Cu.reportError); with Promise.jsm

2013-08-09 Thread Boris Zbarsky
On 8/9/13 9:27 AM, Boris Zbarsky wrote: I think we should definitely report to the error console. I filed https://bugzilla.mozilla.org/show_bug.cgi?id=903419 -Boris ___ dev-platform mailing list dev-platform@lists.mozilla.org