Re: dialog=1 for window.open from content

2015-10-05 Thread Mike Conley
Unfortunately, it looks like the kind of counter I would need is not yet supported[1]. Even if some bank in the world is using dialog=1, what does it give them? It doesn't change the behaviour of the window like showModalDialog (which runs in a nested event loop), it just changes the buttons

Re: dialog=1 for window.open from content

2015-10-02 Thread Mike Taylor
On 10/2/15 2:53 AM, Ehsan Akhgari wrote: Before I go whole-hog trying to fix bug 1095236, I'm curious to know if we really want to continue supporting dialog=1 from content, or if it's safe to just ignore that feature like the other browser engines (which I think would be the fastest path

dialog=1 for window.open from content

2015-10-01 Thread Mike Conley
Hello dev-platform, I'm currently working on bug 1095236 - that's an e10s bug for us failing to open any windows if the features string includes dialog=1 (or dialog=yes). According to [1], setting dialog=1 makes a popup window that removes the min/max/restore buttons, and no "command" menu (the

Re: dialog=1 for window.open from content

2015-10-01 Thread Justin Dolske
On 10/1/15 1:34 PM, Mike Conley wrote: I'm currently working on bug 1095236 - that's an e10s bug for us failing to open any windows if the features string includes dialog=1 (or dialog=yes). According to [1], setting dialog=1 makes a popup window that removes the min/max/restore buttons, and no

Re: dialog=1 for window.open from content

2015-10-01 Thread Blake Kaplan
Mike Conley wrote: > Are there any really good arguments to keep supporting it? I don't know how much data we have for dialog=1, but we'll end up needing to be able to do this for for showModalDialog (see bug 981796 and bug 1137025). -- Blake Kaplan

Re: dialog=1 for window.open from content

2015-10-01 Thread Ehsan Akhgari
On 2015-10-01 4:34 PM, Mike Conley wrote: Hello dev-platform, I'm currently working on bug 1095236 - that's an e10s bug for us failing to open any windows if the features string includes dialog=1 (or dialog=yes). According to [1], setting dialog=1 makes a popup window that removes the