Re: nsIPresShell has gone

2019-05-02 Thread Bobby Holley 
At long last - thank you!

On Thu, May 2, 2019 at 7:20 PM Cameron McCormack  wrote:

> On Fri, May 3, 2019, at 11:44 AM, Masayuki Nakano wrote:
> > Finally, I completely got rid of nsIPresShell from our tree.
> > https://bugzilla.mozilla.org/show_bug.cgi?id=253889
>
> Thank you for doing this, Masayuki!
> ___
> dev-platform mailing list
> dev-platform@lists.mozilla.org
> https://lists.mozilla.org/listinfo/dev-platform
>
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Re: nsIPresShell has gone

2019-05-02 Thread Cameron McCormack 
On Fri, May 3, 2019, at 11:44 AM, Masayuki Nakano wrote:
> Finally, I completely got rid of nsIPresShell from our tree.
> https://bugzilla.mozilla.org/show_bug.cgi?id=253889

Thank you for doing this, Masayuki!
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

nsIPresShell has gone

2019-05-02 Thread Masayuki Nakano 

Hi, everybody.

Finally, I completely got rid of nsIPresShell from our tree.
https://bugzilla.mozilla.org/show_bug.cgi?id=253889

If you need to access presentation shell, treat mozilla::PresShell 
directly (note that in some classes like nsIFrame and its subclasses, 
`mozilla::` prefix is necessary due to the class has a method 
`PresShell()`).


If you need to public `enum` or `struct` of `nsIPresShell`, they have 
been moved to `mozilla` namespace in `PresShellForwards.h`.

https://searchfox.org/mozilla-central/source/layout/base/PresShellForwards.h

I guess that this fix does not devirtualize the methods of them newly, 
they perhaps have already been done by compiler.


--
Masayuki Nakano 
Working on DOM, Events, editor and IME handling at Mozilla
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform