Re: running tests in HiDPI mode on the build machines
On 11.07.2013, at 09:11, Cameron McCormack c...@mcc.id.au wrote: This proposal is just to affect how content is rendered, by setting that pref. If it's a XUL UI it should render at the higher resolution. It wouldn't cause native UI to be rendered differently. I don't really know how we'd achieve that, on any platform, without actual HiDPI hardware. (Maybe those dongles that fake a monitor can be used on the Mac Minis?) On OS X, Quartz Debug should help: https://developer.apple.com/library/mac/ipad/#documentation/GraphicsAnimation/Conceptual/HighResolutionOSX/Testing/Testing.html#//apple_ref/doc/uid/TP40012302-CH6-SW1 Georg ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
Re: running tests in HiDPI mode on the build machines
Asa Dotzler wrote: Testing the only Firefox platform that isn't on the above list? Wouldn't it be smarter to test on Windows 7 or some combination of Windows machines where almost all of our users are? If we've got the resources for it, sure. ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
Re: running tests in HiDPI mode on the build machines
jmaher wrote: Can you explain what would need to be done for Android to get into this mode? It might be difficult to make this work with our current solution for automated tests. This proposal is just to affect how content is rendered, by setting that pref. If it's a XUL UI it should render at the higher resolution. It wouldn't cause native UI to be rendered differently. I don't really know how we'd achieve that, on any platform, without actual HiDPI hardware. (Maybe those dongles that fake a monitor can be used on the Mac Minis?) I just tried setting layout.css.devPixelsPerPx to 2 on my Galaxy Nexus, and though things look like they render OK, interaction is not quite working properly. I can't seem to set it back to -1, either. ;) ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
running tests in HiDPI mode on the build machines
Can you explain what would need to be done for Android to get into this mode? It might be difficult to make this work with our current solution for automated tests. ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
Re: running tests in HiDPI mode on the build machines
On 7/8/2013 8:18 PM, Cameron McCormack wrote: I think it's time we considered having tests running on the build machines in HiDPI mode so that we can catch regressions that only manifest themselves in high resolution configurations. We have at least three platforms we're targeting where this is going to be useful: Firefox on Retina MBPs, and Firefox for Metro and Firefox for Android on high res devices. Please add to this list Windows Firefox desktop. Given the capacity constraints we have in the build farm, would it be sufficient to run HiDPI tests on Linux or Linux64, where we can easily spin up more AWS machines? Testing the only Firefox platform that isn't on the above list? Wouldn't it be smarter to test on Windows 7 or some combination of Windows machines where almost all of our users are? - A ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
running tests in HiDPI mode on the build machines
I think it's time we considered having tests running on the build machines in HiDPI mode so that we can catch regressions that only manifest themselves in high resolution configurations. We have at least three platforms we're targeting where this is going to be useful: Firefox on Retina MBPs, and Firefox for Metro and Firefox for Android on high res devices. I believe we can get good HiDPI test coverage just by running tests with layout.css.devPixelsPerPx 1 on non-high resolution hardware. There is some work that needs to be done on the reftest framework to get that working -- https://bugzilla.mozilla.org/show_bug.cgi?id=821210 and its dependent -- to get high resolution snapshots happening, but that shouldn't be difficult. Last I tested in https://bugzilla.mozilla.org/show_bug.cgi?id=859742 there were around 300 test failures when running with layout.css.devPixelsPerPx = 2. I haven't looked into how many of those are real bugs or just tests that don't correctly test things in HiDPI mode. I think the main question to ask is: what platforms would we want/need to run tests in HiDPI mode on? Given the capacity constraints we have in the build farm, would it be sufficient to run HiDPI tests on Linux or Linux64, where we can easily spin up more AWS machines? There are probably few enough differences across platforms that we can just write individual tests to handle HiDPI on Mac/Metro/Android when we need to. (roc pointed out to me that reftest-zoom can be used for individual tests to get the same effect as setting layout.css.devPixelsPerPx.) As for getting the tree to a state where we can consider HiDPI test failures as critical, we can start off with these tests hidden on tbpl until we've fixed those ~300 tests, like we've done with other new platforms/configurations. Any reasons not to go ahead with this? If not, how do we proceed? ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
