Re: Proposal: Standardize initializer list formatting in our coding style guide

2014-12-04 Thread Cameron McCormack
Nicholas Nethercote wrote: This is already present in the example at https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style#Classes: class MyClass : public X // when deriving from more than one class, put each on its own line , public Y I have encountered far more

Re: Proposal: Standardize initializer list formatting in our coding style guide

2014-12-04 Thread Cameron McCormack
[Sorry, white space got eaten up in the previous mail...] Nicholas Nethercote wrote: This is already present in the example at https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style#Classes: class MyClass : public X // when deriving from more than one class, put each

Proposal: Change the coding style guide to allow an 'o' prefix to indicate out-params

2014-12-04 Thread Seth Fowler
I’d like to change the coding style guide to let us make out-params more obvious by using an ‘o’ prefix for their name instead of an ‘a’. For example, nsresult Modify(int aCount, size_t aSize, char* oResult); This will make it clear just from the declaration of a function or method which

Re: Proposal: Change the coding style guide to allow an 'o' prefix to indicate out-params

2014-12-04 Thread Eric Rescorla
On Thu, Dec 4, 2014 at 10:35 AM, Seth Fowler s...@mozilla.com wrote: I’d like to change the coding style guide to let us make out-params more obvious by using an ‘o’ prefix for their name instead of an ‘a’. For example, nsresult Modify(int aCount, size_t aSize, char* oResult); This will

Re: Proposal: Change the coding style guide to allow an 'o' prefix to indicate out-params

2014-12-04 Thread Nicholas Nethercote
On Fri, Dec 5, 2014 at 5:41 AM, Eric Rescorla e...@rtfm.com wrote: I’d like to change the coding style guide to let us make out-params more obvious by using an ‘o’ prefix for their name instead of an ‘a’. For example, What fraction of these cases can't be distinguished by making non-out

Re: Proposal: Change the coding style guide to allow an 'o' prefix to indicate out-params

2014-12-04 Thread L. David Baron
On Thursday 2014-12-04 10:35 -0800, Seth Fowler wrote: I’d like to change the coding style guide to let us make out-params more obvious by using an ‘o’ prefix for their name instead of an ‘a’. For example, nsresult Modify(int aCount, size_t aSize, char* oResult); This will make it clear

Re: Proposal: Change the coding style guide to allow an 'o' prefix to indicate out-params

2014-12-04 Thread Ben Kelly
I typically append Out to these parameter names. The o prefix would be more concise. +1 Thanks! Ben - Original Message - From: Seth Fowler s...@mozilla.com To: dev-platform dev-platform@lists.mozilla.org Sent: Thursday, December 4, 2014 1:35:06 PM Subject: Proposal: Change the coding

Re: Proposal: Change the coding style guide to allow an 'o' prefix to indicate out-params

2014-12-04 Thread Eric Rescorla
On Thu, Dec 4, 2014 at 10:51 AM, Nicholas Nethercote n.netherc...@gmail.com wrote: On Fri, Dec 5, 2014 at 5:41 AM, Eric Rescorla e...@rtfm.com wrote: I’d like to change the coding style guide to let us make out-params more obvious by using an ‘o’ prefix for their name instead of an ‘a’.

Re: Proposal: Change the coding style guide to allow an 'o' prefix to indicate out-params

2014-12-04 Thread Martin Thomson
On 2014-12-04, at 10:51, Nicholas Nethercote n.netherc...@gmail.com wrote: What fraction of these cases can't be distinguished by making non-out ref/pointer parameters const? The non-const-ness of a parameter is a weak, indirect indication that it's an outparam, and one that is probably

Re: Proposal: Change the coding style guide to allow an 'o' prefix to indicate out-params

2014-12-04 Thread Robert O'Callahan
On Thu, Dec 4, 2014 at 12:35 PM, Seth Fowler s...@mozilla.com wrote: I’d like to change the coding style guide to let us make out-params more obvious by using an ‘o’ prefix for their name instead of an ‘a’. For example, nsresult Modify(int aCount, size_t aSize, char* oResult); This will