Re: Removing "MathML View Source" menu item? [was: Can we remove nsIEntityConverter?]

Le 17/05/2017 à 17:14, J. Ryan Stinnett a écrit : > Looking at the add-on, it seems to miss one feature: Currently in m-c, you > can select a portion of a MathML expression, choose "View Selection > Source", and see the MathML source for the selection. If that's added to > your add-on, I believe

Re: Changing our thread APIs for Quantum DOM scheduling

Out of curiosity, how will this interact with nsCOMPtr thread-safe (or thread-unsafe) refcounting? Also, in code I have seen, `NS_IsMainThread` is used mainly for assertion checking. I *think* that the semantics you detail below will work, but do you know if there is a way to make sure of that?

Re: Avoiding jank in async functions/promises?

On Fri, May 19, 2017 at 4:18 AM, Mark Hammond wrote: > On 5/18/17 12:03 PM, Boris Zbarsky wrote: >> >> On 5/17/17 9:22 PM, Mark Hammond wrote: >>> >>> I'm wondering if there are any ideas about how to solve this optimally? >> >> >> I assume >>

Re: Is it OK to make allocations that intentionally aren't freed? (was: Re: Is Big5 form submission fast enough?)

There's also a pre-processor constant that we define in Valgrind/ASAN/etc. builds that you can check in order to free more stuff than you otherwise would. But I can't for the life of me remember what it's called :( Nick On Sat, May 20, 2017 at 5:09 AM, Jeff Muizelaar

Re: Is it OK to make allocations that intentionally aren't freed? (was: Re: Is Big5 form submission fast enough?)

On Fri, May 19, 2017 at 10:38 PM, Nicholas Nethercote wrote: > There's also a pre-processor constant that we define in Valgrind/ASAN/etc. > builds that you can check in order to free more stuff than you otherwise > would. But I can't for the life of me remember what it's

Re: Gecko Profiler Win64 stability

You've done a fantastic job of making it more stable - thank you. I'll make sure to flag you on any more synchronization issues I run into. On Thu, May 18, 2017 at 3:04 PM, David Major wrote: > Hi, > > The Gecko Profiler used to be notoriously unstable on 64-bit Windows. (If

Re: Intent to ship: NetworkInformation

Can the people who have concerns about the NetworkInformation API please provide the feedback to google on this blink-dev thread: https://groups.google.com/a/chromium.org/d/msg/blink-dev/UVfNMH50aaQ/CXY6S39TBQAJ In particular, I think they tried to consider privacy in this part of the spec:

Re: Improving visibility of compiler warnings

I'm not sure if this is exactly the same as the ALLOW_COMPILER_WARNINGS that we use for warnings-on-errors, but FWIW as of a couple of months ago I cleaned out the last warning-allowance in our "own" code. ALLOW_COMPILER_WARNINGS usage is now only in external libraries (I'm counting NSS and NSPR

Re: Quantum Flow Engineering Newsletter #9

On 2017-05-12 9:55 AM, Ehsan Akhgari wrote: This reminded me of https://bugzilla.mozilla.org/show_bug.cgi?id=1332680 (and https://bugzilla.mozilla.org/show_bug.cgi?id=1332682 ) Adding -Wsuggest-final-types and -Wsuggest-final-methods and looking at the output seems pretty low-effort to find a

Re: Is it OK to make allocations that intentionally aren't freed? (was: Re: Is Big5 form submission fast enough?)

On Fri, May 19, 2017 at 08:44:58AM +0300, Henri Sivonen wrote: The downsides would be that the memory for the tables wouldn't be reclaimed if the tables aren't needed anymore (the browser can't predict the future) and executions where any of the tables has been created wouldn't be

Improving visibility of compiler warnings

`mach build` attempts to parse compiler warnings to a persisted "database." You can view a list of compiler warnings post build by running `mach warnings-list`. The intent behind this feature was to make it easier to find and fix compiler warnings. After all, something out of sight is out of mind.

Re: Improving visibility of compiler warnings

I've actually been meaning to post about this, with some questions. I definitely like that we now print warnings at the end of builds, since it makes them harder to ignore. But the current amount of warnings spew at the end of every build is problematic, especially when a build fails and I

Re: Improving visibility of compiler warnings

With regard to ALLOW_COMPILER_WARNINGS, I'm strongly of the opinion that we should be providing an option to hide all warnings from modules marked as ALLOW_COMPILER_WARNINGS now, as they are only in "external" libraries which most of us are not working on, and they really clog up my compiler

Re: Is it OK to make allocations that intentionally aren't freed? (was: Re: Is Big5 form submission fast enough?)

We use functions like cairo_debug_reset_static_data() on shutdown to handle cases like this. -Jeff On Fri, May 19, 2017 at 1:44 AM, Henri Sivonen wrote: > On Tue, May 16, 2017 at 7:03 AM, Tim Guan-tin Chien > wrote: >> According to Alexa top 100

Re: Is it OK to make allocations that intentionally aren't freed? (was: Re: Is Big5 form submission fast enough?)

I second Kris' concern re: memory, particularly given this is in multiple processes. I'd suggest something more along the lines of a timeout; AFAICT 'memory-pressure' isn't actually fired in low-memory situations (it's still useful, and registering for it and handling it would make sense for

Re: Improving visibility of compiler warnings

On 2017-05-19 2:44 PM, Gregory Szorc wrote: The Perfherder alerts and tracking are informational only: nobody will be backing you out merely because you added a compiler warning. While the possibility of doing that now exists, I view that decision as up to the C++ module. I'm not going to

Re: Is it OK to make allocations that intentionally aren't freed? (was: Re: Is Big5 form submission fast enough?)

Might be good to serialize to/from disk after the first run, so only the first process pays the compute cost? On Thu, May 18, 2017 at 10:44 PM, Henri Sivonen wrote: > On Tue, May 16, 2017 at 7:03 AM, Tim Guan-tin Chien > wrote: >> According to Alexa

Re: Improving visibility of compiler warnings

It is great to see a good use for compiler warnings and alerts. We have added a lot of data to perfherder and the build metrics are not covered by any sheriffs by default. For these if it is clear who introduced them, we will comment in the bug as a note, but there are no intentions to file

Re: Improving visibility of compiler warnings

While I agree with that in general, it seems like the warnings in NSS and NSPR, at least, are our responsibility, and should be fixed. I notice the huge number of warnings scrolling by from NSS, in particular, every time I compile, and they make me worry. On Fri, May 19, 2017 at 04:27:47PM

Re: Improving visibility of compiler warnings

I strongly agree with you, Michael! Especially now that I'm using IceCC, I pretty much always have to use search-and-replace to find compiler errors. It's a pointless drain on productivity. On Fri, May 19, 2017 at 1:27 PM, Michael Layzell wrote: > With regard to

Re: Improving visibility of compiler warnings

On Fri, May 19, 2017 at 1:27 PM, Michael Layzell wrote: > With regard to ALLOW_COMPILER_WARNINGS, I'm strongly of the opinion that we > should be providing an option to hide all warnings from modules marked as > ALLOW_COMPILER_WARNINGS now, as they are only in "external"

Re: Changing our thread APIs for Quantum DOM scheduling

The Quantum DOM doc says only content processes will get cooperative threading. How will cooperative threading work with multiple content processes (e10s-multi)? Will there be inter-process scheduling? For example, if content process #1 has one or more foreground tabs (from multiple windows)