Upcoming changes to our C++ Coding Style

2018-11-21 Thread Ehsan Akhgari
(In case the formatting doesn't survive transit, a copy of this note can be found here: https://docs.google.com/document/d/1CTaWucldHxEri5BUB1kL4faF4prwPlBa31yHFd-l8uc .) TL;DR To improve developer productivity, we are planning to a) start automatically formatting all Gecko C++ code with

Re: Signals in Firefox

2018-11-21 Thread Mike Hommey
On Wed, Nov 21, 2018 at 10:22:38AM -0500, Nathan Froyd wrote: > On Wed, Nov 21, 2018 at 4:45 AM David Teller wrote: > > What is our policy on using Unix signals on Firefox? I am currently > > reviewing a patch by external contributors that involves inotify's > > signal API, and I assume it's a

Re: Intent to implement: implicit ref=noopener for target=_blank on anchor and area elements

2018-11-21 Thread Boris Zbarsky
On 11/21/18 2:22 PM, Daniel Veditz wrote: "opener" doesn't exist It does in WebKit's proposed changes and in our implementation of them. You'd specify a target name other than "_blank" to indicate it's a context you care about This seems backwards. What matters is whether the context

Re: Signals in Firefox

2018-11-21 Thread David Teller
Thanks for the suggestions. Given that they are on an academic deadline and they have already implemented the feature using straight inotify and a monitor thread, I'd favor a lesser refactoring with just removing the signals. Cheers, David On 21/11/2018 22:06, Mike Hommey wrote: > On Wed, Nov

Re: Intent to implement: implicit ref=noopener for target=_blank on anchor and area elements

2018-11-21 Thread Daniel Veditz
On Wed, Nov 21, 2018 at 7:08 AM Alex Gaynor wrote: > Do we have any sense of how large the breakage will be, and do we have any > docs for developers who are impacted? (I assume rel=opener is the fix?) > "opener" doesn't exist, and we shouldn't need it. You'd specify a target name other than

Intent to implement: implicit ref=noopener for target=_blank on anchor and area elements

2018-11-21 Thread Andrea Marchesini
*Summary*: WebKit is experimenting an interesting feature: target=_blank on anchor and area elements implies ref=noopener. https://trac.webkit.org/changeset/237144/webkit/ *Bug*: https://bugzilla.mozilla.org/show_bug.cgi?id=1503681 *Link to standard*: https://github.com/whatwg/html/issues/4078

Signals in Firefox

2018-11-21 Thread David Teller
Dear platformers, What is our policy on using Unix signals on Firefox? I am currently reviewing a patch by external contributors that involves inotify's signal API, and I assume it's a bad idea, but I'd like to ask around first before sending them back to the drawing board. Cheers,

Re: Signals in Firefox

2018-11-21 Thread Nathan Froyd
On Wed, Nov 21, 2018 at 4:45 AM David Teller wrote: > What is our policy on using Unix signals on Firefox? I am currently > reviewing a patch by external contributors that involves inotify's > signal API, and I assume it's a bad idea, but I'd like to ask around > first before sending them back to

Re: Intent to implement: implicit ref=noopener for target=_blank on anchor and area elements

2018-11-21 Thread Anne van Kesteren
On Wed, Nov 21, 2018 at 4:08 PM Alex Gaynor wrote: > Do we have any sense of how large the breakage will be, and do we have any > docs for developers who are impacted? (I assume rel=opener is the fix?) The "fix" would be to use target=someuniquename. And I don't think there's data, other than

Re: Intent to implement: implicit ref=noopener for target=_blank on anchor and area elements

2018-11-21 Thread Alex Gaynor
I'm very excited about this -- in my experience very few developers know about the dangers of target=_blank. Do we have any sense of how large the breakage will be, and do we have any docs for developers who are impacted? (I assume rel=opener is the fix?) Yay! Alex On Wed, Nov 21, 2018 at 3:29

Re: Intent to implement: implicit ref=noopener for target=_blank on anchor and area elements

2018-11-21 Thread Ehsan Akhgari
On Wed, Nov 21, 2018 at 3:55 PM Boris Zbarsky wrote: > On 11/21/18 2:22 PM, Daniel Veditz wrote: > > "opener" doesn't exist > > It does in WebKit's proposed changes and in our implementation of them. > > > You'd specify a target > > name other than "_blank" to indicate it's a context you care

Re: Intent to implement: implicit ref=noopener for target=_blank on anchor and area elements

2018-11-21 Thread Boris Zbarsky
On 11/21/18 11:50 PM, Ehsan Akhgari wrote: Would it be OK if the answer to that question be "use window.open()"? Can one do noreferrer with window.open()? Also, if your thing doing the navigation is a , not , then window.open is pretty hard to use for that. Then again, target="_blank"> is

Re: Intent to implement: implicit ref=noopener for target=_blank on anchor and area elements

2018-11-21 Thread Ehsan Akhgari
On Wed, Nov 21, 2018 at 11:55 PM Boris Zbarsky wrote: > On 11/21/18 11:50 PM, Ehsan Akhgari wrote: > > Would it be OK if the answer to that question be "use window.open()"? > > Can one do noreferrer with window.open()? > Yes, by passing 'noopener' in the features argument: