Re: Rust code coverage

2019-01-07 Thread Henri Sivonen
On Fri, Jan 4, 2019 at 2:54 PM Marco Castelluccio wrote: > Hi everyone, > we have recently enabled collecting code coverage for Rust code too, Nice! > running Rust tests in coverage builds. Does this mean running cargo test for each crate under third_party/rust, running Firefox test suites or b

Re: Proposal to adjust testing to run on PGO builds only and not test on OPT builds

2019-01-07 Thread Aki Sasaki
+1. The goal of shippable builds is twofold: 1. to make sure opt builds+tests, or similar (artifact builds?) answer the question "is my commit good?" as fast as possible, and 2. to make sure shippable builds+tests answer the question "are these binaries correct and ready to ship, if we decide to

Re: nasm will soon become a build dependency

2019-01-07 Thread Thomas Daede
On 12/21/18 3:09 PM, Mike Hommey wrote: > On Fri, Dec 21, 2018 at 04:21:03PM -0500, Kartikaya Gupta wrote: >> I would certainly prefer this, and having this work smoothly would >> also be good for new contributors. Having to build and install extra >> packages is always a hassle. > > It's a hassle

Re: Proposal to adjust testing to run on PGO builds only and not test on OPT builds

2019-01-07 Thread Randell Jesup
>* do we turn off builds as well? I had proposed just the tests, if we decide >to turn off talos it would make sense to turn off builds. Would turning off opt builds cause problems if you want to mozregression an opt build? And would this be an issue? (obviously it might be for opt-only failur