Re: Proposed style guide modification: using declarations and nested namespaces

2012-11-09 Thread Chris Peterson
On 11/9/12 11:53 AM, Ehsan Akhgari wrote: using namespace mozilla; using namespace mozilla::dom; The style guidelines recommend against using nested namespaces, so doing what you suggest would make them self-inconsistent. But we have some nested namespaces today, so `using` them like Kyle

Re: Integrating ICU into Mozilla build

2012-12-06 Thread Chris Peterson
On 12/6/12 6:36 PM, Robert O'Callahan wrote: How hard would it be to incrementally download data for the locales we need? It seems that most users won't ever need the collation tables for Chinese, for example. If we could figure out a way to make them available just-in-time, that could be a

Question about Bugzilla bug dependencies

2013-01-07 Thread Chris Peterson
I've seen some inconsistent usage, so I just wanted to get a group opinion. If a fix for bug X introduces regression bug Y, should Y block X (because X is not properly fixed until regression Y is fixed) or should Y depend on X (because regression Y does not exist without fix X)? thanks,

Re: The future of PGO on Windows

2013-01-31 Thread Chris Peterson
On 1/31/13 11:21 AM, L. David Baron wrote: On Thu, Jan 31, 2013 at 1:31 PM, L. David Baron dba...@dbaron.org wrote: Is it possible we might be able to make MOZ_LIKELY and MOZ_UNLIKELY meaningful on Windows (they currently only do anything on gcc or clang builds)? If we did, might that get back

Re: Running mousemove events from the refresh driver

2013-02-15 Thread Chris Peterson
On 2/14/13 6:36 PM, Robert O'Callahan wrote: I created http://people.mozilla.com/~roc/mousemove-freq.html. We get up to 120-ish mousemoves per second on my machine in Firefox, and a bit more in IE9, but it caps out at 60fps in Chrome which suggests to me they're doing something like what I

Re: Replacing gcc 4.5 as the default Linux compiler?

2013-04-01 Thread Chris Peterson
On 4/1/13 9:06 AM, Mike Hommey wrote: gcc 4.7.2 was installed on builders last week. Unfortunately, it comes with its own set of problems. See bugs 854085, 854103 and 854105. The worst part (which is unfiled at the moment) is that PGO builds OOM on x86. This is unfortunate because gcc 4.7's

Re: Replacing gcc 4.5 as the default Linux compiler?

2013-04-01 Thread Chris Peterson
btw, Firefox for Android currently uses gcc 4.6. Google's recent Android NDKs also include gcc 4.7 and clang 3.2 as optional compilers for testing. chris p. ___ dev-platform mailing list dev-platform@lists.mozilla.org

Re: Replacing gcc 4.5 as the default Linux compiler?

2013-04-01 Thread Chris Peterson
On 4/1/13 11:08 AM, Mike Hommey wrote: This is unfortunate because gcc 4.7's release notes specifically call out LTO improvements for Firefox: LTO != PGO. I know LTO != PGO. I just meant that gcc 4.7's PGO problems are unfortunate because they block testing of the LTO improvements. chris

Re: Using a pre-processing flag to auto-disable features in later Beta versions

2013-04-25 Thread Chris Peterson
On 4/25/13 8:20 AM, Robert Kaiser wrote: So, for the short term, I think those two outcomes (early-beta-flag and throttling) are the right thing to do here as we need to get that testing in time. For the longer run we IMHO need to think again about how we can get more people on the Aurora and

Increasing our Aurora and Nightly user populations?

2013-04-29 Thread Chris Peterson
(Sorry if this is not the right forum for this discussion.) To increase our testing populations, I'd like to suggest that we add a periodic channel upsell message to the about:home page (of Aurora and Beta) and the about box (of Aurora, Beta, and possibly Release). Beta and Aurora users have

Re: Upcoming changes to the Linux 32-bits and Android builders

2013-05-15 Thread Chris Peterson
On 5/15/13 2:42 AM, Mike Hommey wrote: Following this, we're going to switch all Linux builds to gcc 4.7, later this week. Android NDK r8e also includes gcc 4.7. We may want to investigate updating to gcc 4.7 on Android, too. chris ___

Re: Embracing git usage for Firefox/Gecko development?

2013-07-10 Thread Chris Peterson
/02013/03/stacked-git-mercurial-style-patch-queues-for-git/ chris peterson ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform

Re: Code Review Session

2013-07-10 Thread Chris Peterson
On 5/24/13 8:46 AM, Benoit Girard wrote: I've got some patches that import webkit's check-style script to check the style[1]. Google and Linux also have style lint scripts (cpplint.py [1] and checkstyle.pl [2] respectively) that don't depend on a particular compiler tool like clang-format.

Re: Making proposal for API exposure official

2013-07-10 Thread Chris Peterson
of standardization and limiting any market share they may attain chris peterson ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform

Re: review stop-energy (was 24hour review)

2013-07-10 Thread Chris Peterson
I really wish Bugzilla could let me flag myself as not available for reviews when I'm on vacation, say. Expecting people to comment about being on vacation while on vacation is, imo, not reasonable. I've seen people change their Bugzilla name to include a comment about being on PTO. We should

Re: Embracing git usage for Firefox/Gecko development?

2013-07-10 Thread Chris Peterson
On 7/10/13 3:01 PM, Justin Lebar wrote: I can't see how they are a good alternative. With patch queues, I can maintain a complex refactoring in a patch queue containing dozens of smallish patches. In particular, I can easily realize I made a mistake in patch 3 while working on patch 21 and

Re: Using C++0x auto

2013-07-15 Thread Chris Peterson
On 7/14/13 10:50 PM, Justin Lebar wrote: We can't require any c++11 feature until we drop support for gcc 4.4. [...] there are problems in the gcc 4.4 system headers that make using c++11 mode impossible (except on b2g/android). Is there any reason to support gcc 4.4 outside of B2G/Android?

Re: review stop-energy (was 24hour review)

2013-07-15 Thread Chris Peterson
On 7/15/13 7:10 AM, Honza Bambas wrote: - providing patch split to logically separated parts with numbers like part 1 of 6 - and also a complete (folded) patch for reference - strictly versioning the patch among review rounds - when submitting a new version of a patch after r- always explain

Re: Rethinking separate Mercurial repositories

2013-07-31 Thread Chris Peterson
On 7/31/13 2:54 AM, Marco Bonardo wrote: - handling queue of patches for different branches is a nightmare, I often have patches in queues for aurora, beta and central at the same time Wouldn't switching branches in the same repo clone touch many files and trigger unfortunately clobber

Re: Removing support for OS/2

2013-08-07 Thread Chris Peterson
On 8/7/13 1:00 PM, d...@dmik.org wrote: What about switching the build system, it's not our primary task of course but it will be done sooner or later — this is all to have a more robust build environment Why does the OS/2 port need a different build system? I'm not familiar with OS/2

Re: Proposal: Email individual patch authors who improve performance

2013-08-13 Thread Chris Peterson
We could also send a weekly congratulations to the person who removed the most lines of code that week. :) chris On 8/13/13 1:57 PM, Jet Villegas wrote: This is awesome! Is it possible to see a log of the recipients/patches? --Jet - Original Message - From: Matt Brubeck

This week's award for net lines of code deleted

2013-08-16 Thread Chris Peterson
... goes to Blake Kaplan! He deleted 11,336 lines of code when he excised the old about:blank parser in bug 903912. btw, I didn't write any fancy scripts to scrape hg logs. github has pretty graphs for mozilla-central. However, the stats are skewed by merges and backouts.

Re: Detection of unlabeled UTF-8

2013-08-30 Thread Chris Peterson
On 8/30/13 3:03 AM, Henri Sivonen wrote: Telemetry data suggests that these days the more common reason for seeing mojibake is that there is an encoding declaration but it is wrong. My guess is that this arises from Linux distributions silently changing their Apache defaults to send a charset

Re: JavaScript Style Guide. Emacs mode line.

2013-09-09 Thread Chris Peterson
On 9/9/13 6:58 AM, Dao wrote: Probably historic reasons (e.g. somebody started adding lots of Java files with 4-space indents and changing those wasn't considered worthwhile) or consistency with http://www.oracle.com/technetwork/java/javase/documentation/codeconventions-136091.html? Google's

Re: Including algorithm just to get std::min and std::max

2013-09-12 Thread Chris Peterson
On 9/12/13 6:35 AM, Mike Hommey wrote: Note we have *many* inline functions that the compiler decide to never inline. We should maybe try to detect those on all platforms and move those functions out of headers. gcc -Winline will report uninlined inline functions, but the warnings are VERY

Summit Innovation Fair: Improving developer productivity at Mozilla?

2013-10-03 Thread Chris Peterson
the beginning of an ongoing improvement program. :) See you there! * Chris Peterson (Santa Clara) * Erin Lancaster (Brussels) * Lawrence Mandel (Toronto) ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev

Transparent Black, or Are all transparent colors create equal?

2013-10-07 Thread Chris Peterson
I stumbled upon some layout code that for transparent colors using != or == NS_RGBA(0,0,0,0): http://dxr.mozilla.org/mozilla-central/search?q=regexp%3A%23[!%3D]%3D%20%3FNS_RGBA%23 Are those checks unnecessarily restrictive? One of the checks has a comment saying Use the strictest match for

Re: What platform features can we kill?

2013-10-09 Thread Chris Peterson
On 10/9/13 9:49 AM, Benjamin Smedberg wrote: In the spirit of learning from this, what's next on the chopping block? RDF I'm all for this, although the risk is probably quite small because we don't expose RDF to content. Bug 833098 - Kick RDF out of Firefox Comments in the bug suggest a

Re: What platform features can we kill?

2013-10-10 Thread Chris Peterson
On 10/9/13 8:18 PM, Nicholas Nethercote wrote: On Wed, Oct 9, 2013 at 2:36 PM, Ehsan Akhgariehsan.akhg...@gmail.com wrote: In the spirit of learning from this, what's next on the chopping block? JSD. Firebug's the main consumer, AFAIK. The meta bug for removing JSD is bug 800200. I

Re: Cost of ICU data

2013-10-15 Thread Chris Peterson
On 10/15/13 12:28 PM, Brian Smith wrote: I have no idea how to install a langpack. Presumably it is something that is done through AMO. I am skeptical that this is easy enough to make it acceptable to push this task off to the user. we should at least automate it for them. If this data is too

Re: Cost of ICU data

2013-10-16 Thread Chris Peterson
On 10/16/13 6:39 AM, Gervase Markham wrote: You have given on-disk footprint values, but surely download size values are the important ones for the issue you are raising? After all, some of this data may be very compressible, and some may not. Can we repackage the ICU data so we can compress

Re: devolution of cleartype rendering in Fx chrome

2013-10-17 Thread Chris Peterson
On 10/17/13 7:27 AM, Johnathan Nightingale wrote: If you (or others reading this) are helping to hunt down regression ranges in the future, consider this my regularly scheduled pitch for mozregression. http://harthur.github.io/mozregression/ It takes a minute to learn how it works, but it

Re: Cost of ICU data

2013-10-18 Thread Chris Peterson
On 10/17/13 11:43 AM, Matt Brubeck wrote: For this reason, I'm a bit confused at the level of scrutiny of ICU's size when we've added many times that amount to our download size over the past couple of years without any pushback or even discussion. Do we have Funnelcake data comparing download

Re: Cost of ICU data

2013-10-18 Thread Chris Peterson
On 10/18/13 4:06 PM, Chris Peterson wrote: On 10/17/13 11:43 AM, Matt Brubeck wrote: For this reason, I'm a bit confused at the level of scrutiny of ICU's size when we've added many times that amount to our download size over the past couple of years without any pushback or even discussion

Reminder: Nightly 27 uplift in T-7 days

2013-10-21 Thread Chris Peterson
This is a friendly reminder that the next channel merge date is only 7 days away! So land those important bug fixes this week and hold your destablizing or less important changes until next week. :) cpeterson ___ dev-platform mailing list

Re: how long are we continuing 32-bit OS X support?

2013-10-21 Thread Chris Peterson
On 10/21/13 3:28 PM, Mike Hommey wrote: Note OS X 10.6 runs in 32-bit mode*by default*, even on *64-bit capable* hardware. That's the whole problem. There are only a few Macbook models that aren't 64-bit capable. There are much more OSX installs that run in 32-bit mode. But the boat anchor is

Re: Cost of ICU data

2013-10-22 Thread Chris Peterson
On 10/22/13 11:34 AM, wsel...@mozilla.com wrote: The key point is that download size is very important in these markets. Also, it is important for us to think about two related topics: 1) How to get people in these markets to current versions of Firefox? 2) If downloading is not currently the

Re: Cost of ICU data

2013-10-22 Thread Chris Peterson
On 10/22/13, 2:09 PM, wsel...@gmail.com wrote: One suggestion that our team came up with is to provide Firefox-branded USB keys and distribute them through reps, chains like KFC and 7-11, and local computer vendors where people connect online. These would have installers for the latest

Re: A static analyzer found 3 potential security bugs in our code

2013-10-30 Thread Chris Peterson
On 10/30/13, 9:06 AM, André Reinald wrote: http://www.itworld.com/security/380406/how-your-compiler-may-be-compromising-application-security STACK was run against a number of systems written in C/C++ and it found 160 new bugs in the systems tested, including... Mozilla (3)... If they only

Re: Unified builds

2013-11-14 Thread Chris Peterson
On 11/14/13, 2:49 PM, Ehsan Akhgari wrote: The way that unified builds work is by using the UNIFIED_SOURCES instead of the SOURCES variable in moz.build files. With that, the build system creates files such as: // Unified_cpp_path_0.cpp #include Source1.cpp #include Source2.cpp // ... Are

Re: Unified builds

2013-11-18 Thread Chris Peterson
On 11/16/13, 1:34 AM, Ms2ger wrote: One way around it would be not to unify sources in automation. On one hand, this could cause more bustage when changes that built locally turn out not to have enough includes; on the other, it might be better than having to fix up a dozen unrelated files

Re: Thinking about the merge with unified build

2013-12-02 Thread Chris Peterson
On 11/29/13, 7:39 PM, Mike Hommey wrote: I think it's time, 9 days before the merge, to think about whether we want unified builds to ride the train or not. I'm almost tempted to suggest that we disable unified builds on nightlies, but that would probably hide the problems even more. I don't

FYI: Nightly 28 uplift in 7 days

2013-12-02 Thread Chris Peterson
This is a friendly reminder that the next channel merge date [1] is only 7 days away! So don't forget to land those last minute bug fixes this week. :) Also, you may want to hold destablizing or less important changes until next week for Nightly 29. cpeterson [1]

Re: Deciding whether to change the number of unified sources

2013-12-03 Thread Chris Peterson
On 12/3/13, 8:53 AM, Ted Mielczarek wrote: On 12/2/2013 11:39 PM, Mike Hommey wrote: Current setup (16): real11m7.986s user63m48.075s sys 3m24.677s Size of the objdir: 3.4GiB Size of libxul.so: 455MB Just out of curiosity, did you try with greater than 16? I

Re: Deciding whether to change the number of unified sources

2013-12-03 Thread Chris Peterson
On 12/3/13, 2:48 PM, Mike Hommey wrote: I tested unifying 99 files. On my not-super-fast MacBook Pro, I saw no significant difference (up or down) in real time compared to 16 files. This result is in line with Mike's results showing only small improvements between 8, 12, and 16 files. Did you

Re: (un)safety of NS_LITERAL_STRING(...).get()

2013-12-12 Thread Chris Peterson
On 12/12/13, 5:09 PM, L. David Baron wrote: The preferred form would now be: #include mozilla/Char16.h const PRUnichar *comma = MOZ_UTF16(,); I think char16_t is preferred over PRUnichar for new code. chris ___ dev-platform mailing list

Re: On the usefulness of style guides (Was: style guide proposal)

2013-12-19 Thread Chris Peterson
On 12/19/13, 5:35 PM, Jeff Gilbert wrote: The last bit of the problem is that*all of Gecko* is currently 'files with existing styles', so I'm not sure how that can mesh with having 'one true style' unless we have an initiative to actually convert over all mis-styled files. If we either fail

Re: On the usefulness of style guides (Was: style guide proposal)

2013-12-20 Thread Chris Peterson
On 12/19/13, 6:50 PM, Bobby Holley wrote: And that should include accepting patches to fix the style across their module. ;-) FWIW I'm totally fine with mass-conversions if people want to do them. Any mass conversions of code style should coincide with the next ESR release. Imagine the

Re: js-inbound as a separate tree

2013-12-21 Thread Chris Peterson
On 12/19/13, 4:20 PM, David Burns wrote: I know that RelEng are looking into how to do scheduling better, I am not sure where they are with this or if it is started but its a good first step. The whole a push can take hours to build/test is the thing that we need to be pushing against. I think

Re: PSA: Please stop using NULL in C++ code

2014-01-06 Thread Chris Peterson
On 1/6/14, 11:37 AM, Gregory Szorc wrote: Both are probably good clang-analyser plugins to write. http://clang-analyzer.llvm.org/ True. Although I don't believe we run clang-analyzer in automation... yet. I don't think the benefit of replacing NULL with nullptr is worth the developer and

Re: A proposal to reduce the number of styles in Mozilla code

2014-01-06 Thread Chris Peterson
On 1/6/14, 9:55 AM, Martin Thomson wrote: 2. create some tools These tools should help people conform to the style. Primarily, what is needed is a tool with appropriate configuration that runs on the command line — e.g., mach reformat … clang-format is looking like a good candidate for

Re: A proposal to reduce the number of styles in Mozilla code

2014-01-06 Thread Chris Peterson
On 1/6/14, 5:05 PM, Karl Tomlinson wrote: If we have a tool to skip the style change on any such unclear situations, then perhaps we can proceed more safely. I would replace skip with abort loudly, so a human can review the unclear code. :) chris

Re: JavaScript Style Guide. Emacs mode line.

2014-01-07 Thread Chris Peterson
On 1/7/14, 5:42 PM, Martin Thomson wrote: Yeah, I thought that was the whole point of having a .emacs file. I’ve never found those mode line things to be properly useful short of the point that it includes the entire c-offsets-alist for the buffer. I’d rather the mode line stuff be removed.

Re: Target Milestone field in bugzilla

2014-01-09 Thread Chris Peterson
On 1/9/14, 7:17 AM, Kartikaya Gupta wrote: I think the Target Milestone field is poorly named, at least with respect to what we use it for. In practice this field is set to the version of m-c on which the patches originally landed, and doesn't change when patches are uplifted to other branches.

Re: Exact rooting is now enabled on desktop

2014-01-19 Thread Chris Peterson
On 1/18/14, 9:04 AM, Terrence Cole wrote: Great question! We have a tool called GC zeal in builds with --enable-gc-zeal and in all debug builds unconditionally. It adds a small runtime overhead, but gives us fine-grained control over when GC's happen and adds several verification modes for

Re: Mozilla Location Services - Heads up

2014-02-04 Thread Chris Peterson
On 2/4/14, 10:08 AM, Mike Hoye wrote: We really need an ARG and some badges for this, to give people some sort of incentive to wander all over the place. Yes, though plenty of people (1000+) are happy to wander around collecting data today. :) We have a simple leaderboard [1], but we'd like

Retiring Bugzilla components?

2014-02-11 Thread Chris Peterson
What is the process for retiring obsolete Bugzilla components to the Graveyard? During a bug triage, I stumbled upon some old components that can probably be moved out of the Core product (or simply RESOLVED WONTFIX or INVALID): • Core:: Nanojit (from Adobe collaboration on Tamarin VM) •

Re: [e10s] Changes to the browser.tabs.remote preference in desktop Firefox

2014-02-13 Thread Chris Peterson
On 2/13/14, 5:33 PM, Bill McCloskey wrote: We're hoping that exposing the New OOP Window menu item will make it easier for people to test electrolysis. When you file e10s bugs, please include [e10s] in the bug summary and/or make your new bug block one of the e10s tracking bugs: • Bug

Re: [e10s] Changes to the browser.tabs.remote preference in desktop Firefox

2014-02-14 Thread Chris Peterson
On 2/14/14, 11:22 AM, Milan Sreckovic wrote: Changing the preferences requires restart, I presume? Changing the browser.tabs.remote or browser.tabs.remote.autostart prefs does require a browser restart, but browser.tabs.remote is already enabled by default in OS X. You will only need to

Re: PSA: Don't write out multiple Add/RemoveObserver calls manually, iterate over an array instead

2014-02-18 Thread Chris Peterson
On 2/17/14, 11:25 AM, Kyle Huey wrote: If you are observing several topics it's easy to forget to add a Remove call when adding new observer topic. If you instead write an array of topics and iterate over that it's impossible to screw up

Re: Fixing build warnings [was: Re: Always brace your ifs]

2014-02-24 Thread Chris Peterson
On 2/23/14, 8:54 PM, Daniel Holbert wrote: We currently have only 100-200 build warnings[1], if you filter out warnings from third-party libraries that we import (e.g. cairo, skia, protobuf, ICU, various media codecs). On my machine, Firefox for OS X has 284 warnings, but only 24 are from

Re: Use of MOZ_ARRAY_LENGTH for static constants?

2014-02-24 Thread Chris Peterson
On 2/23/14, 4:05 PM, Neil wrote: Both ArrayLength and MOZ_ARRAY_LENGTH are typesafe when compiled as C++, however ArrayLength has the disadvantage that it's not a constant expression in MSVC. In unoptimised builds this is direly slow as the templated function does not even get inlined, but even

Re: We live in a memory-constrained world

2014-02-24 Thread Chris Peterson
On 2/22/14, 1:39 PM, Nicholas Nethercote wrote: On Sat, Feb 22, 2014 at 11:22 PM, Andreas Gal andreas@gmail.com wrote: So, I'm wondering how much effort we should put in reducing the number of ChromeWorkers. We should continue to use JS in Chrome where it makes sense. Its often easier

Re: Fixing build warnings [was: Re: Always brace your ifs]

2014-02-27 Thread Chris Peterson
On 2/27/14, 2:02 PM, Nicholas Nethercote wrote: So I'm pleased to hear that -W{sometimes,maybe}-initialized have lower false positive rates. Investigating them sounds like the most promising avenue for progress. Just to be clear: gcc's -Wmaybe-uninitialized is still very spammy. gcc's

PSA: Nightly 31 will become the next ESR

2014-03-18 Thread Chris Peterson
So if you plan to remove any deprecated features or land major refactorings (like reformating all whitespace using using clang-format in bug 966840), Nightly 31 is a good opportunity to do so. Otherwise you will be supporting that code until ESR 31 is EOL'd in August 2015! :) If the

Re: MOZ_ASSUME_UNREACHABLE is being misused

2014-03-28 Thread Chris Peterson
On 3/28/14, 12:25 PM, Benoit Jacob wrote: Should we give typical code a macro that does what they want and sounds like what they want? Really, what typical code wants is a no-operation instead of undefined-behavior; now, that is exactly the same as MOZ_ASSERT(false, error). Maybe this syntax is

Re: MOZ_ASSUME_UNREACHABLE is being misused

2014-03-28 Thread Chris Peterson
On 3/28/14, 4:05 PM, Benoit Jacob wrote: #define MOZ_CRASH_UNREACHABLE() \ do { \ MOZ_ASSUME_UNREACHABLE_MARKER();\ MOZ_CRASH(MOZ_CRASH_UNREACHABLE); \ } while (0) MOZ_ASSUME_UNREACHABLE_MARKER tells the compiler feel free to

warp, Facebook's new C/C++ preprocessor

2014-03-28 Thread Chris Peterson
warp is Facebook's new C/C++ preprocessor, written by Walter Bright (in D, of course). They claim build time (not just preprocessing time) of 10% to 40%. https://code.facebook.com/posts/476987592402291/under-the-hood-warp-a-fast-c-and-c-preprocessor chris

Re: MOZ_ASSUME_UNREACHABLE is being misused

2014-03-31 Thread Chris Peterson
On 3/28/14, 7:03 PM, Joshua Cranmer  wrote: I included MOZ_ASSUME_UNREACHABLE_MARKER because that macro is the compiler-specific optimize me intrinsic, which I believe was the whole point of the original MOZ_ASSUME_UNREACHABLE. AFAIU, MOZ_ASSUME_UNREACHABLE_MARKER crashes on all Gecko

Re: Enable -Wswitch-enum? [was Re: MOZ_ASSUME_UNREACHABLE is being misused]

2014-04-01 Thread Chris Peterson
On 4/1/14, 10:22 AM, Daniel Holbert wrote: So, we have on the order of ~4400 switch statements that would potentially need expanding to avoid tripping this warning. clang on OS X reports 1635 -Wswitch-enum warnings (switch on enum not handling all enum cases). gcc reports 1048

Re: Policy for disabling tests which run on TBPL

2014-04-04 Thread Chris Peterson
On 4/4/14, 1:19 PM, Gavin Sharp wrote: The majority of the time identifying the regressing patch is difficult Identifying the regressing patch is only difficult because we have so many intermittently failing tests. Intermittent oranges are one of the major blockers for Autoland. If TBPL

Re: Policy for disabling tests which run on TBPL

2014-04-09 Thread Chris Peterson
On 4/9/14, 11:48 AM, Gregory Szorc wrote: I feel a lot of people just shrug shoulders and allow the test to be disabled (I'm guilty of it as much as anyone). From my perspective, it's difficult to convince the powers at be that fixing intermittent failures (that have been successfully swept

Re: Recommendations on source control and code review

2014-04-11 Thread Chris Peterson
Code review tool company SmartBear published an interesting study [1] of the effectiveness of code reviews at Cisco. (They used SmartBear's tools, of course.) Mozillian Mike Conley reviewed SmartBear's study on his blog [2]. The results are interesting and actionable. Some highlights: *

Re: Recommendations on source control and code review

2014-04-15 Thread Chris Peterson
On 4/14/14, 10:31 AM, smaug wrote: As a reviewer I usually want to see _also_ a patch which contains all the changes. Otherwise it can be very difficult to see the big picture. But sure, having large patches split to smaller pieces may help. btw, if you have opinions about code review tools,

Re: PSA: Nightly 31 will become the next ESR

2014-04-18 Thread Chris Peterson
Just a friendly reminder: next week is your last opportunity to remove all those deprecated features that you don't want to support in ESR 31 until August 2015! :) https://wiki.mozilla.org/Enterprise/Firefox/ExtendedSupport:Proposal#Version_Numbers chris On 3/18/14, 1:40 PM, Chris Peterson

Re: Relevance of Super-Review (Was: Hardening the review requirements for changing .webidl files)

2014-04-24 Thread Chris Peterson
As we consider the value of super-reviews, we should include the relationship between module owners and peers. Long review queues are a burden for reviewers. Slow review turnarounds force patch authors to juggle multiple patches to stay productive, but this has a high context-switch overhead.

Re: Time to revive the require SSE2 discussion

2014-05-09 Thread Chris Peterson
What does requiring SSE2 buy us? 1% of hundreds of millions of Firefox users is still millions of people. chris On 5/8/14, 5:42 PM, matthew.br...@gmail.com wrote: On Tuesday, January 3, 2012 4:37:53 PM UTC-8, Benoit Jacob wrote: 2012/1/3 Jeff Muizelaar jmuizel...@mozilla.com: On

Re: Time to revive the require SSE2 discussion

2014-05-09 Thread Chris Peterson
GMT-04:00 Chris Peterson cpeter...@mozilla.com: What does requiring SSE2 buy us? 1% of hundreds of millions of Firefox users is still millions of people. chris ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org

Re: OMTC on Windows

2014-05-18 Thread Chris Peterson
That's awesome news, Bas! OMTC on Windows has been one of the major dependencies for e10s. AFAIU, Nightly users on Windows should now be able to test per-window e10s without tweaking any prefs or restarting the browser. To open an e10s window, open File (or Hamburger) menu then New e10s

e10s: don't call it a comeback

2014-05-21 Thread Chris Peterson
Lassey, engineering manager * Chris Peterson, program manager * David handyman Parks, contractor dedicated to e10s gfx issues * Jim Mathies * Mike Conley * Tom evilpie Schuster * Tomislav zombie Jovanovic, GSoC student + Sid Stamm's team working on sandboxing + some new volunteer contributors

Re: Update on sheriff-assisted checkin-needed bugs

2014-05-21 Thread Chris Peterson
On 5/21/14, 1:51 PM, Mike Conley wrote: Or, alternatively, attempt to automate this with Autoland (https://bugzilla.mozilla.org/show_bug.cgi?id=657828). Is anyone actively working on Autoland? Rail had been working on Autoland, but when I spoke with him in 2013 Q4, I think he said he would

Re: Standardized assertion methods

2014-06-02 Thread Chris Peterson
On 6/2/14, 3:42 PM, Ehsan Akhgari wrote: 2. I also value consistency more than my personal preferences, and based on that, using the existing APIs in some tests and the new APIs in other tests (even if we agreed that #1 above doesn't matter) is strictly worse than the status quo. btw, in the

Re: Google announces Chrome builds for Win64

2014-06-04 Thread Chris Peterson
On 6/4/14, 10:32 AM, Brian Smith wrote: Does it make sense to ship 64-bit Firefox before shipping mutli-process/sandboxed Firefox? I worry that 64-bit Firefox will be more memory hungry than 32-bit Firefox and if it lands first then it will be harder to land multi-process Firefox which is

Re: Misunderstood the Assigned at bugs! Sorry !!!

2014-07-09 Thread Chris Peterson
hi Tobias, Bugzilla has many fields and teams use them in many different ways. :) It's usually best to let the people reporting or investigating the bugs update the bug fields. From my experience, many (most?) teams never change a bug's Status from NEW to ASSIGNED, but they still use Assigned

Re: Studying Lossy Image Compression Efficiency, July 2014

2014-07-15 Thread Chris Peterson
On 7/15/14 12:38 PM, stonecyp...@gmail.com wrote: On Tuesday, July 15, 2014 7:34:35 AM UTC-7, Josh Aas wrote: This is the discussion thread for Mozilla's July 2014 Lossy Compressed Image Formats Study and the Mozilla Research blog post entitled Mozilla Advances JPEG Encoding with mozjpeg 2.0.

Chromium Security Team's Q2 status report

2014-08-05 Thread Chris Peterson
The Chromium Security Team shared some interesting information about their recent work on fuzzing tools, new sandboxing, Win64, and SSL: https://groups.google.com/a/chromium.org/forum/#!topic/security-dev/ASLmY69v4Hk cp ___ dev-platform mailing list

Re: Are StaticAuto/RefPtr good?

2014-08-06 Thread Chris Peterson
On 8/6/14 7:11 AM, Benjamin Smedberg wrote: Not only that, but it also makes our code correct. There is nothing to guarantee that one of those destrcutors we're skipping right now would not have observable side effects passed shutdown. So until somone comes up with an idea on how to enforce

Re: Are StaticAuto/RefPtr good?

2014-08-06 Thread Chris Peterson
Thanks, I now see distinction you are making. :) On 8/6/14 10:32 AM, Benjamin Smedberg wrote: On 8/6/2014 1:20 PM, Chris Peterson wrote: I don't understand this sentence, but I strongly oppose automatically clearing Static*Ptr in the static destructor in any build. In the past we have had

Re: Non-backward compatible changes to JS 'let' semantics

2014-08-14 Thread Chris Peterson
On 8/13/14 3:02 PM, Shu-yu Guo wrote: About not changing the behavior for chrome JS, the prospect of having chrome JS becoming more divergent from standard JS is unwelcome to me. Having additional, orthogonal features is one thing, but a fundamental feature with the same syntax that behaves

Re: Experiment with running debug tests less often on mozilla-inbound the week of August 25

2014-08-21 Thread Chris Peterson
On 8/21/14 9:35 AM, Ed Morley wrote: 4) When merging into mozilla-central, sheriffs ensure that all jobs are green - including those that got coalesced and those that are only scheduled periodically (eg non-unified PGO builds are only run every 3 hours). (This is a fairly manual process

Re: Restricting gUM to authenticated origins only

2014-09-05 Thread Chris Peterson
On 9/5/14 4:39 AM, Henri Sivonen wrote: * Geolocation In principle, I think geolocation should be restricted to authenticated origins. Unfortunately, it might be too late compatibility-wise to do that at this point. Also, since the geolocation responses are easily proxied over postMessage, I

Re: Restricting gUM to authenticated origins only

2014-09-05 Thread Chris Peterson
On 9/5/14 2:38 PM, Ehsan Akhgari wrote: Google Maps and Yahoo Maps use HTTPS, but MapQuest and Bing Maps use HTTP. Before we could restrict geolocation to authenticated origins, we would need to convince Microsoft and MapQuest to use HTTPS (or whitelist their sites). Those are not the only

JSAPI PSA: RIP jschar. Hello char16_t.

2014-09-09 Thread Chris Peterson
Since Firefox 27 (bug 8950470), SpiderMonkey's jschar has been a typedef for char16_t, a new C++11 type distinct from uint16_t. With bug 1063962, SpiderMonkey's jschar typedef is gone. SpiderMonkey, its JSAPI, and Gecko now use char16_t directly. C++ code (outside mozilla-central) compiling

Re: Intent to implement: Touchpad event

2014-09-11 Thread Chris Peterson
On 9/11/14 3:49 AM, Mounir Lamouri wrote: On Thu, 11 Sep 2014, at 18:26, Ms2ger wrote: First of all, you neglected to explain the standardization situation here. Is this feature being standardized? If not, why not? How do other browser vendors feel about it? Where does this stand in the

Re: ES6 lexical temporal dead zone has landed on central

2014-09-17 Thread Chris Peterson
On 9/15/14 4:43 PM, Shu-yu Guo wrote: If you work with JS that contains `let` bindings, you may start encountering the following two errors: 1. TypeError: redeclaration of variable foo To fix, rename the variable or remove the extra `let` if you are assigning to an already-bound

Re: How many tests are disabled? (answer inside)

2014-09-30 Thread Chris Peterson
On 9/30/14 7:35 AM, Andrew Halberstadt wrote: A new project called Test Informant [1] is keeping track of this data and allows us to generate reports with it. Here is a report generated from yesterday's builds:

Re: JavaScript (strict) Warning from FF mochitest-plain test.

2014-10-02 Thread Chris Peterson
See bug 807862 - Use strict mode for all builtin JS Note that some of those warnings are from SpiderMonkey's non-standard extra warnings mode, not ES5 strict mode. To confuse matters, extra warnings were called strict warnings before ES5 and are controlled by the javascript.options.strict

Re: Breakdown of Firefox full installer

2014-10-13 Thread Chris Peterson
On 10/13/14 5:37 PM, Chris Hofmann wrote: and from last year Firefox installer size: How big is too big? - 2013 https://groups.google.com/forum/#!searchin/mozilla.dev.planning/installer$20size/mozilla.dev.planning/hPgUBzweL70/NeOjEf0hsh0J That thread about installer size was regarding the

Re: Compiler version expectations

2014-10-16 Thread Chris Peterson
On 10/16/14 12:49 PM, Jeff Muizelaar wrote: Are there reasons we can’t drop support for these compilers in the 37-38 time frame? Firefox 38 will become the next ESR. I don't know if that means we should drop old compilers *before* the ESR or after, but it should probably inform the

Re: Compiler version expectations

2014-10-16 Thread Chris Peterson
On 10/16/14 2:27 PM, Ehsan Akhgari wrote: On 2014-10-16, 5:01 PM, Chris Peterson wrote: On 10/16/14 12:49 PM, Jeff Muizelaar wrote: Are there reasons we can’t drop support for these compilers in the 37-38 time frame? Firefox 38 will become the next ESR. I don't know if that means we should

  1   2   3   >