Re: backtrace display in ASSERTION from debug build of TB (comm-central.)

2013-01-09 Thread ISHIKAWA, Chiaki
(2013/01/08 13:13), ishikawa wrote: On (2013年01月08日 13:03), Joshua Cranmer wrote: On 1/7/2013 10:00 PM, ishikawa wrote: If we can coerce the built-in traceback function to print something more meaningful, or if someone can suggest a way to attach gdb to a run of TB during make mozmill

How does one debug uninitialized value usage from JavaScript (TB) ?

2013-01-28 Thread ISHIKAWA, Chiaki
I noticed many uninitialied value usage warnings from the execution of TB under valgrind (memcheck). Many such usages, today, are related to JavaScript interpreter. memcheck can print the stack trace when this condition is noticed. However, we only get the traceback of the javascript

Re: How does one debug uninitialized value usage from JavaScript (TB) ?

2013-01-28 Thread ISHIKAWA, Chiaki
(2013/01/29 15:08), L. David Baron wrote: On Tuesday 2013-01-29 11:04 +0900, ISHIKAWA, Chiaki wrote: I noticed many uninitialied value usage warnings from the execution of TB under valgrind (memcheck). Many such usages, today, are related to JavaScript interpreter. memcheck can print

Re: How does one debug uninitialized value usage from JavaScript (TB) ?

2013-01-29 Thread ISHIKAWA, Chiaki
(2013/01/30 4:30), Gary Kwong wrote: There should be very few warnings within the current Spidermonkey. I suspect you may not be compiling with --enable-valgrind. This is necessary because Spidermonkey uses a conservative garbage collector that intentionally accesses lots of uninitialized

Re: How does one debug uninitialized value usage from JavaScript (TB) ?

2013-01-29 Thread ISHIKAWA, Chiaki
(2013/01/29 19:03), Julian Seward wrote: From: Chiaki ISHIKAWA ishik...@yk.rim.or.jp I could allocate 6 GB to linux 64 bits images for ordinary program execution on my PC But debug build of TB with all the symbols and such causes the memory usage (including the loading of symbols) I am

Re: How does one debug uninitialized value usage from JavaScript (TB) ?

2013-01-31 Thread ISHIKAWA, Chiaki
(2013/01/31 19:46), Neil wrote: ishikawa wrote: Neil wrote: ISHIKAWA, Chiaki wrote: I see some code most notably LDAP code in comm-central is not 64bit clean Really? Thunderbird has been releasing 64-bit Mac and Linux code for some time now... Now I cannot seem to find

Re: How does one debug uninitialized value usage from JavaScript (TB) ?

2013-01-31 Thread ISHIKAWA, Chiaki
(2013/02/01 0:41), ISHIKAWA, Chiaki wrote: (2013/01/31 19:46), Neil wrote: ishikawa wrote: Neil wrote: ISHIKAWA, Chiaki wrote: I see some code most notably LDAP code in comm-central is not 64bit clean Really? Thunderbird has been releasing 64-bit Mac and Linux code for some time now

Re: How does one debug uninitialized value usage from JavaScript (TB) ?

2013-01-31 Thread ISHIKAWA, Chiaki
(2013/02/01 1:48), Joshua Cranmer wrote: On 1/31/2013 9:41 AM, ISHIKAWA, Chiaki wrote: Sorry, it may not have been ldap code (my memory is now hazy). But please take a look at this code. I am using comm-central code for development/debugging TB. https://mxr.mozilla.org/comm-central/source

Re: How does one debug uninitialized value usage from JavaScript (TB) ?

2013-01-31 Thread ISHIKAWA, Chiaki
(2013/02/01 11:34), Joshua Cranmer wrote: On 1/31/2013 8:26 PM, ISHIKAWA, Chiaki wrote: (2013/02/01 1:48), Joshua Cranmer wrote: On 1/31/2013 9:41 AM, ISHIKAWA, Chiaki wrote: Sorry, it may not have been ldap code (my memory is now hazy). But please take a look at this code. I am using comm

Re: How does one debug uninitialized value usage from JavaScript (TB) ?

2013-02-06 Thread ISHIKAWA, Chiaki
(2013/02/01 11:47), ISHIKAWA, Chiaki wrote: (2013/02/01 11:34), Joshua Cranmer wrote: On 1/31/2013 8:26 PM, ISHIKAWA, Chiaki wrote: (2013/02/01 1:48), Joshua Cranmer wrote: On 1/31/2013 9:41 AM, ISHIKAWA, Chiaki wrote: Sorry, it may not have been ldap code (my memory is now hazy

Re: Cycle collection for workers

2013-02-10 Thread ISHIKAWA, Chiaki
This is a report of a possible bug related to this. It also has the serious disadvantage that mistakes result in exploitable use-after-frees, rather than unexploitable leaks. It also causes various problems with the WebIDL binding codegenerator in its current incarnation. I just ran across an

Re: How does one debug uninitialized value usage from JavaScript (TB) ?

2013-02-27 Thread ISHIKAWA, Chiaki
(2013/02/27 0:53), Neil wrote: ishikawa wrote: By the way, does looking at IDL header/declaration files help me to figure out where the double is returned? You would have to peek in the locals on the stack to find out exactly which interface is being called. I don't know how to do this. I

Re: How does one debug uninitialized value usage from JavaScript (TB) ?

2013-03-01 Thread ISHIKAWA, Chiaki
(2013/03/01 11:10), ISHIKAWA, Chiaki wrote: (2013/02/27 22:35), ISHIKAWA, Chiaki wrote: (2013/02/27 0:53), Neil wrote: ishikawa wrote: By the way, does looking at IDL header/declaration files help me to figure out where the double is returned? You would have to peek in the locals

Re: Bug 851818 - Modernizing the Enter Bug Entry Page in Bugzilla

2013-03-18 Thread ISHIKAWA,chiaki
(2013/03/19 2:31), Mark Banner wrote: On 18/03/2013 16:27, Jason Smith wrote: - BootToGecko - Big focus at Mozilla with a lot of people working on this project, so I think this could benefit greatly from being on the front page. This should be Firefox OS as that's what the users will know it

Re: Replacing gcc 4.5 as the default Linux compiler?

2013-04-03 Thread ISHIKAWA, Chiaki
(2013/04/03 16:32), ishikawa wrote: On (2013年04月03日 15:32), Mike Hommey wrote: On Wed, Apr 03, 2013 at 02:22:35PM +0900, ishikawa wrote: FYI: Upgrading binutils to 2.23.2 did not help. (Well, at least I got a better memory usage report when memory was exhausted. ld printed out that it fails

Re: [devtools] Ready to replace the Error Console: the Browser Console landed

2013-04-11 Thread ISHIKAWA, Chiaki
(2013/04/11 4:24), Mihai Sucan wrote: Hello Joshua! Le 10/04/2013 20:41, Joshua Cranmer  a écrit : On 4/10/2013 12:05 PM, Mihai Sucan wrote: If anyone has any concerns about us replacing the Error Console, please shout loud and clear! We plan to do the aforementioned steps to replace the

Re: TB Tryserver WIN32 Build question: merge failure of the change to M-C portion of the source.

2013-04-11 Thread ISHIKAWA,chiaki
(2013/04/11 23:43), Joshua Cranmer  wrote: On 4/11/2013 2:43 AM, ishikawa wrote: Has anyone seen the problem of the patches to M-C portion of the COMM-CENTRAL not accepted by Thunderbird TryServer because the patches fail although linux32 and linux64 work as expected? The bug is that the

Re: JavaScript Style Guide. Emacs mode line.

2013-09-09 Thread ISHIKAWA,chiaki
(2013/09/09 21:18), Dao wrote: On 09.09.2013 05:15, ishikawa wrote: I have been recently editing javascript files to reduce warnings but found an issue of adopted styls in comm-central thunderbird codes. I checked for the preferred style: [1] I found one reference here:

Re: JavaScript Style Guide. Emacs mode line.

2013-09-14 Thread ISHIKAWA,chiaki
(2013/09/14 13:37), Reuben Morais wrote: On Sep 11, 2013, at 12:04 PM, Scott Johnson sjohn...@mozilla.com wrote: I understand the merit of leaving the code as is since hg blame won't work nicely with such file-wide format change as in step-1. (Or maybe we can teach hg blame to ignore such

Re: Supercharge your mach commands with external Python packages

2013-09-20 Thread ISHIKAWA,chiaki
(2013/09/21 9:03), Gregory Szorc wrote: The mach script in the root directory of mozilla-central is a generic command dispatching tool. Have a piece of commonly used functionality useful to many people? Create a mach command so others can use it easily! While mach started with commands dealing

temporary Problem with MXR (?)

2013-10-28 Thread ISHIKAWA, Chiaki
Hi, I noticed that either mxr behaves erratically, or there is a single incorrect entry for HG blame. Case in point: From mxr's comm-central page https://mxr.mozilla.org/comm-central/ I searched for an ID: nsresultForErrno and obtained a few lines of listing. There is only one definition.

Re: #define TEST_MODE* for TBPL builds?

2013-11-13 Thread ISHIKAWA,chiaki
(2013/11/14 9:18), Ted Mielczarek wrote: On 11/13/13 3:34 PM, Mike Habicher wrote: Hello everyone, I'm working on automated tests for Gecko's camera code on B2G, and I want to replace different pieces of the implementation with fake objects that return one or more injected error codes so that

Re: Unified builds

2013-11-21 Thread ISHIKAWA,chiaki
(2013/11/22 1:47), Ehsan Akhgari wrote: On 2013-11-21 11:41 AM, ISHIKAWA,chiaki wrote: (2013/11/15 7:49), Ehsan Akhgari wrote: I've started to work on a project in my spare time to switch us to use unified builds for C/C++ compilation. The way that unified builds work is by using

Re: Unified builds

2013-11-21 Thread ISHIKAWA,chiaki
(2013/11/22 2:17), Ehsan Akhgari wrote: FWIW if this proves to be common, it's a huge problem since it would affect our crash stats etc... :( Well, if the problem is related to the symptom that I observed with the use of -gsplit-dwarf option with ccache, then we may be in for a big surprise.

Re: Unified builds

2013-11-21 Thread ISHIKAWA,chiaki
(2013/11/15 7:49), Ehsan Akhgari wrote: I've started to work on a project in my spare time to switch us to use unified builds for C/C++ compilation. The way that unified builds work is by using the UNIFIED_SOURCES instead of the SOURCES variable in moz.build files. With that, the build system

Re: Unified builds

2013-11-23 Thread ISHIKAWA,chiaki
(2013/11/23 1:41), Ehsan Akhgari wrote: On 2013-11-21 1:12 PM, ISHIKAWA,chiaki wrote: (2013/11/22 2:17), Ehsan Akhgari wrote: FWIW if this proves to be common, it's a huge problem since it would affect our crash stats etc... :( Well, if the problem is related to the symptom that I observed

Content of $MOZ_OBJECT/mozilla/_tests/mozmill/mozmillprofile/

2013-11-23 Thread ISHIKAWA,chiaki
I am trying to create a low-disk condition for testing I/O errors during |make mozmill| test suite run of thunderbird. I am not sure where the various files are stored during |make mozmill|. I can think of TMP, TMPDIR, and a few other settings. Does anyone have an idea of overview of the file

elf-hack may not be performing its job: reduction of memory size by a negative value.

2013-12-25 Thread ISHIKAWA,chiaki
For quite some time (a few months at least), I noticed during the build of thunderbird (comm-central) that shows the memory reduction by elf-hack is NEGATIVE value. For example, the following is from the compilation of latest source (refreshed in the last 72 hours or so). [...] === If you get

Re: JavaScript Style Guide. Emacs mode line.

2014-01-07 Thread ISHIKAWA,chiaki
(2013/09/10 19:17), ishikawa wrote: [ omissions ] I am getting the hang of emacs mode line. /* -*- Mode: javascript; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 ; js-indent-level : 2 ; js-curly-indent-offset: 0 -*- */ /* vim: set ts=2 et sw=2 tw=80: */ seem to do the job.

TB comm-central under valgrind: Strange lock issue, and startup cache issue?

2014-01-15 Thread ISHIKAWA, Chiaki
nvoking |make mozmill| TB test suite by running DEBUG BUILD of TB under valgrind has turned out to be useful in finding memory-related errors, AND timing-related thread race issues. The issues of second kind, i.e., timing issues, are not usually noticed, but often they become obvious due to the

Re: Support for non-UTF-8 platform charset

2014-01-16 Thread ISHIKAWA,chiaki
(2014/01/16 12:22), Zack Weinberg wrote: On 2013-11-26 5:40 AM, Neil wrote: Henri Sivonen wrote: On Windows, do we really need to pay homage to the pre-NT legacy when doing Save As? How about we just use UTF-8 for HTML Page, complete reserialization like on Mac? You'll need a BOM, of

Re: Support for non-UTF-8 platform charset

2014-01-17 Thread ISHIKAWA,chiaki
for this.) (2014/01/17 18:39), Henri Sivonen wrote: On Thu, Jan 16, 2014 at 7:28 PM, ISHIKAWA,chiaki ishik...@yk.rim.or.jp wrote: (2014/01/16 12:22), Zack Weinberg wrote: On 2013-11-26 5:40 AM, Neil wrote: Henri Sivonen wrote: On Windows, do we really need to pay homage to the pre-NT legacy when

Firefox developer beware: Re: TB comm-central under valgrind: Strange lock issue, and startup cache issue?

2014-01-27 Thread ISHIKAWA, Chiaki
(2014/01/16 2:07), ISHIKAWA, Chiaki wrote: ... Since refreshing my local copy of comm-central tree a couple of days ago (my previous update was around Dec 25+ last year), I have not been able to run the test suite |make mozmill| for TB (local DEBUG BUILD) under valgrind (Debian GNU/Linux

Re: Tagging legitimate main thread I/O

2014-02-07 Thread ISHIKAWA, Chiaki
(2014/02/08 0:31), David Rajchenbach-Teller wrote: When we encounter main thread I/O, most of the time, it is something that should be rooted out. However, in a few cases (e.g. early during startup, late during shutdown), these pieces of I/O should actually be left untouched. Since main thread

Re: Tagging legitimate main thread I/O

2014-02-07 Thread ISHIKAWA, Chiaki
(2014/02/08 4:13), David Keeler wrote: On 02/07/14 10:31, ISHIKAWA, Chiaki wrote: Message: [10549] WARNING: Security network blocking I/O on Main Thread: file /REF-COMM-CENTRAL/comm-central/mozilla/security/manager/ssl/src/nsNSSCallbacks.cpp, line 422 This generally happens when javascript

Warning about mutating the [[Prototype]] of an object ?

2014-03-28 Thread ISHIKAWA,chiaki
Recently after a refesh of code from comm-central, I noticed that running |make mozmill| TB test suite using full DEBUG BUILD of TB produced the following warning lines: System JS : WARNING file:///REF-OBJ-DIR/objdir-tb3/mozilla/dist/bin/components/steelApplication.js:783 - mutating the

Re: Warning about mutating the [[Prototype]] of an object ?

2014-03-28 Thread ISHIKAWA,chiaki
(2014/03/29 12:27), Boris Zbarsky wrote: On 3/28/14 6:42 PM, Neil wrote: Boris Zbarsky wrote: But slow here is a relative term. Last I measured, something like a basic property get in Ion code went from 2-3 instructions to 20-30 instructions when we deoptimize. ... What about calls from

Re: Enable -Wswitch-enum? [was Re: MOZ_ASSUME_UNREACHABLE is being misused]

2014-04-06 Thread ISHIKAWA,chiaki
(2014/04/07 10:16), Karl Tomlinson wrote: because enumeration types may hold values that don't match any of their enumerator values. Is this allowed by C (or C++) specification today? [Yes, I know the compiler in the past did not care much.] I thought the stricter warnings of compilers today

Re: Enable -Wswitch-enum? [was Re: MOZ_ASSUME_UNREACHABLE is being misused]

2014-04-07 Thread ISHIKAWA,chiaki
(2014/04/07 14:27), Karl Tomlinson wrote: It is allowed in N3242. I think the relevant sections are 5.2.9 Static cast Thank you for the pointer. I found a floating copy of n3242.pdf at the following url. http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2011/n3242.pdf I think 7.2 10 is

Removing [PID] prefix from |make mozmill| warning/error/assertion lines?

2014-04-18 Thread ISHIKAWA,chiaki
Hi, I have been analyzing warning/error/assertion lines produced by full debug version of TB (comm-central). To facilitate the analysis I created a few scripts to process the error statistically. Staring 1Q of 2014, I think such lines are prefixed with [pid] . Now that probably is very good, but

Re: Landing c-c-breaking changes that remove c-c-only code from m-c

2014-04-22 Thread ISHIKAWA,chiaki
(2014/04/22 2:09), Joshua Cranmer  wrote: On 4/21/2014 11:50 AM, Ehsan Akhgari wrote: You can check CONFIG['MOZ_BUILD_APP'] against what you pass to --enable-application in mozconfig files. So that would be 'mailnews' (or 'mail'?) and 'suite' for Thunderbird and Seamonkey respectively.

Re: Policing dead/zombie code in m-c

2014-04-24 Thread ISHIKAWA,chiaki
(2014/04/24 21:49), Till Schneidereit wrote: (CC'ing people who have worked on the ICU integration) On Thu, Apr 24, 2014 at 2:31 PM, Henri Sivonen hsivo...@hsivonen.fi wrote: However, especially in the context of slimming down our own set of encoding converters, it's rather demotivating to

Enabling |fdatasync| for Thunderbird compilation under linux

2014-05-20 Thread ISHIKAWA,chiaki
Hi, This was discussed before somewhere (in bugzilla ?) although I could not find it now) I noticed a rather slow processing of POP3 e-mail fetching on a PC with scsi disk. At each message download, I can hear a clicking sound coming from a SCSI disk suggesting a large amount of disk activity.

Re: error running mochitest-browser

2014-05-31 Thread ISHIKAWA,chiaki
(2014/05/22 22:40), thills wrote: Hi All, I'm facing an error when downloading the latest code from mercurial, doing a build and then trying to run the mochitest-browser tests. I face the following error about 6 minutes into the test run. console.error: 6:30.14 [CustomizableUI] 6:30.14

JavaScript (strict) Warning from FF mochitest-plain test.

2014-10-02 Thread ISHIKAWA,chiaki
Hi, I was looking at a large number of JavaScript (strict) warnings, and errors from the recording of |make mozmill| test run of locall-built DEBUG BUILD of TB last several days after a refresh of C-C source tree. The number of such has increased very much both - due to the seemingly stricter

Re: JavaScript (strict) Warning from FF mochitest-plain test.

2014-10-03 Thread ISHIKAWA,chiaki
Dear Steve, Thank you for the feedback. Also I would like to thank other people whose e-mails also give an glimpse of the depth of the problem. On 2014/10/03 4:49, Steve Fink wrote: On 10/02/2014 11:59 AM, ISHIKAWA,chiaki wrote: Hi, I was looking at a large number of JavaScript (strict

Re: Fwd: JavaScript (strict) Warning from FF mochitest-plain test.

2014-10-04 Thread ISHIKAWA,chiaki
I am for this proposal, too. We need to spend a little man-power in the areas other than implementing new features :-) Fixing seemingly innocent warnings, etc. may not look a glorious task, but we need to do this to ship quality software (not that today's versions are not good quality, but we

Testing framework does not wait for correct dialog sometimes.

2014-10-11 Thread ISHIKAWA,chiaki
Hi, I am not sure where to post, but since this affects every platform, here it goes. I noticed several months ago that some javascript test programs that run during |make mozmill| test suite wait for dialogs during the execution. But I also realized that there is no distinction for dialogs.

Incorrect line number reported by JS engine for warnings?

2014-10-12 Thread ISHIKAWA, Chiaki
Lately, the stricter checks from JS engines produced many warnings during the test suite run (|make mozmill|) of locally built DEBUG BUILD of C-C thunderbird. These in themselves are very good to make code better, more robust, etc. However, today I noticed a few problems of line numbers thus

Re: Incorrect line number reported by JS engine for warnings?

2014-10-12 Thread ISHIKAWA, Chiaki
warning: resource://gre/modules/FormHistory.jsm, line 639: ReferenceError: reference to undefined property change.guid TIA On 2014/10/13 11:45, Boris Zbarsky wrote: On 10/12/14, 9:54 PM, ISHIKAWA, Chiaki wrote: In this bugzilla, line 693 is actually out of range for the file reported. The file

Re: Removing ancient and unused code from tools/

2014-10-12 Thread ISHIKAWA, Chiaki
On 2014/10/13 13:36, Nicholas Nethercote wrote: - tools/rb/ -- most, if not all, scripts actively used Thank you for the clean up work. I am using fix_linux_stack tool under tools/rb/ for cleaning up non symbolic stack trace in the log of DEBUG BUILD of TB when I am testing

Has something changed about nsITreeView (nsItreeView.setTree) lately?

2014-10-17 Thread ISHIKAWA,chiaki
Hi, I posted the following message to mozilla.dev.builds newsgroup, but I wonder if there is a mozilla-wide change to nsITreeView lately? I noticed this while testing a patch to C-C TB locally. (Considering that COMM-CENTRAL may have a slight delay in getting M-C changes, it may be that

Re: MSE WebM/VP9 enabled on nightly

2014-10-24 Thread ISHIKAWA,chiaki
On 2014/10/24 13:46, Anthony Jones wrote: I just wanted to give a heads up to everyone that we enabled Media Source Extensions on nightly for WebM/VP9. This brings Adaptive Streaming capability to Firefox video playback. The feature is not complete so the pref will automatically turn off when it

profiler in TB

2014-10-25 Thread ISHIKAWA,chiaki
Hi, I thought I try profiler to see how it works in TB, but I get the following error. It looks a module called |panel| is not usable in TB. I looked at jetpack-panel-apps web page noted in the message, but am clueless. Error Message: error: geckoprofiler: An exception occurred. Error: The

Re: profiler in TB

2014-10-25 Thread ISHIKAWA,chiaki
, and I could not create a new message any more. I had to restart TB. I was checking the issue, and left an empty composite window lying around, and I must have used THAT window for this message. Sorry about broken threading info.) On 2014/10/26 11:48, ISHIKAWA,chiaki wrote: Hi, I thought I

Re: Unified compilation is going to ride the train

2014-11-27 Thread ISHIKAWA,chiaki
On 2014/11/28 10:12, Mike Hommey wrote: Hi, A year ago, when unified compilation was introduced to speed up builds, a couple issues were raised and we conservatively restricted them out of aurora/beta/release/esr. A year later, it's time to revisit this decision, and since afaik we haven't had

Re: Unified compilation is going to ride the train

2014-11-28 Thread ISHIKAWA,chiaki
On 2014/11/28 18:26, Mike Hommey wrote: On Fri, Nov 28, 2014 at 11:57:56AM +0900, ISHIKAWA,chiaki wrote: On 2014/11/28 10:12, Mike Hommey wrote: Hi, A year ago, when unified compilation was introduced to speed up builds, a couple issues were raised and we conservatively restricted them out

Re: Is anyone still using JS strict warnings?

2014-12-19 Thread ISHIKAWA,Chiaki
(2014/12/20 5:19), Jason Orendorff wrote: So if you go to about:config and set the javascript.options.strict pref, you'll get warnings about accessing undefined properties. js Math.TAU undefined /!\ ReferenceError: reference to undefined property Math.TAU (It says

C-C TB performance issue: unbuffered write where it can use buffering.

2014-12-27 Thread ISHIKAWA, Chiaki
(I posted this to https://bugzilla.mozilla.org/show_bug.cgi?id=558528#c46 as a permanent record, but I am posting this to a couple of newsgroups with a few typo fixes and added comments to solicit a solution re how to fix this performance issue from a wider audience.) I have spotted a very

Re: PSA: Non-unified builds no longer occurring on central/inbound and friends

2015-02-03 Thread ISHIKAWA,chiaki
On 2015/02/03 15:24, Mike Hommey wrote: On Tue, Feb 03, 2015 at 02:27:52PM +0900, ISHIKAWA,chiaki wrote: I did a non-unified build and saw the expected failure. This is a summary of what I saw. Background: I may need to modify and debug basic I/O routines on local PC, and so want to avoid

Re: PSA: Non-unified builds no longer occurring on central/inbound and friends

2015-01-15 Thread ISHIKAWA,chiaki
On 2015/01/15 10:37, Steve Fink wrote: On 01/14/2015 11:26 AM, Ehsan Akhgari wrote: From now on, the only supported build mode is unified compilation. I am planning to follow-up with removing support for the --disable-unified-compilation configure option altogether in bug 1121000. I

Using address sanitizer with GCC 4.9 to compile C-C TB

2015-03-24 Thread ISHIKAWA,chiaki
Hi, I filed the following bugzilla to share my experience of using address sanitizer with GCC 4.9 (*NOT CLANG*) to compile C-C TB. Bug 1147248 - GCC 4.9 + Address Sanitizer + C-C TB: Compiling comm-central thunderbird using address sanitizer, -fsanitize=address using GCC 4.9 I wonder what I did

Re: Using address sanitizer with GCC 4.9 to compile C-C TB

2015-03-25 Thread ISHIKAWA, Chiaki
on Linux are a supported and tested Firefox configuration so there is a good chance that it works well for Thunderbird as well. ASAN builds using gcc is neither tested nor supported as far as I know. On 2015-03-24 10:15 PM, ISHIKAWA,chiaki wrote: Hi, I filed the following bugzilla to share my

Re: Memory management in C programs

2015-01-29 Thread ISHIKAWA, Chiaki
On 2015/01/12 22:46, Philip Chee wrote: One large difference between C and most other programming languages is that in C, you have to handle memory yourself rather than having a garbage collector do it for you. Ensuring that memory is allocated at the correct moment is not very difficult (and

Re: Excessive inbound bustage

2015-04-22 Thread ISHIKAWA,chiaki
On 2015/04/22 22:15, Ehsan Akhgari wrote: Note that it's not just the turn around time that can become an issue. For me personally the reasons I choose to not use the try server are: 1) If I have ~20 unlanded patches in my queue (which is normal for my workflow on an average day), I need to

A question about do_QueryInterface()

2015-04-30 Thread ISHIKAWA, Chiaki
Lately, I refreshed comm-central thunderbird code and tested my local modification to enable buffering of writing downloaded message to a local mail store. (This is about when one uses POP3. Please bear this in mind. Imap testing is further along.) I noticed a couple of things: (1) File API

Re: A question about do_QueryInterface()

2015-04-30 Thread ISHIKAWA, Chiaki
Thank you for the clarification. On 2015/05/01 3:38, Boris Zbarsky wrote: On 4/30/15 2:25 PM, ISHIKAWA, Chiaki wrote: Is this to be expected? Sure. You're taking an _output_ stream and QIing it to nsI_Input_Stream. Yes, that is how the original code was written. It might happen

Re: Replacing Mozmill driven tests for Firefox with Marionette

2015-05-13 Thread ISHIKAWA, Chiaki
Ouch, there was a line near the end. Successfully installed jsbridge-2.4.14 mozmill-1.5.16 This is from a local C-C TB build. CI ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform

Re: Running C-C TB under valgrind during mozmill test: extending timeout values (but where?)

2015-04-18 Thread ISHIKAWA, Chiaki
(Just this once, I post to m.d.platform and m.d.a.firefox) I found out that firefox's mochitest can be run under valgrind according to How Do I Run A Mochitest Under Valgrind? in https://developer.mozilla.org/en-US/docs/Mozilla/Testing/Valgrind e.g.: ./mach mochitest-plain --debugger=valgrind

Re: The War on Warnings

2015-06-08 Thread ISHIKAWA,chiaki
Hi, On 2015/06/06 2:39, Eric Rahm wrote: On Friday, June 5, 2015 at 8:23:53 AM UTC-7, ISHIKAWA,chiaki wrote: After coping with voluminous messages in C-C TB |make mozmill| test suite log [much smaller volume than full FF logs], I think we should have NS_INFORMATION() macro that prints out

Re: The War on Warnings

2015-06-05 Thread ISHIKAWA,chiaki
On 2015/06/04 21:38, Robert O'Callahan wrote: Usually I use NS_WARNING to mean something weird and unexpected is happening, e.g. a bug in Web page code, but not necessarily a browser bug. Sometimes I get useful hints from NS_WARNING spew leading up to a serious failure, but for those usages

Re: The War on Warnings

2015-06-17 Thread ISHIKAWA,chiaki
On 2015/06/17 8:29, Eric Rahm wrote: An update on progress. I've landed bugs which should clean up ~180,000 warnings. I have bugs pending for another ~26,000. The latest top 40: *Note: I improved my normalization a bit so it might look a bit different Are there documents explaining why

Re: Revisiting modelines in source files

2015-06-17 Thread ISHIKAWA,chiaki
Assessing style compliance as == clang-format(whole file) is by far the easiest to implement. I'd be in favor of a flag day (or set of mini flag days) where we mass rewrite the tree with clang-format's output. To be honest, I don't care WHICH particular style we follow, but please set the

DBM code too old (Re: mozmill test: Hightail ???)

2015-05-29 Thread ISHIKAWA, Chiaki
I changed the subject: Followup-to: mozilla.dev.platform On 2015/05t/29 16:41, ishikawa wrote: Hi, I have been testing locally built FULL DEBUG C-C thunderbird using |make mozmill| test suite. When I tinkered with low-level I/O testing by simulating short read, I saw about a couple of

Re: Strange Error: Reentrancy error: some client, attempted to display a message to the console while in a console,listener

2015-07-01 Thread ISHIKAWA,chiaki
On 2015/07/02 4:30, Andrew Sutherland wrote: This is probably due to https://dxr.mozilla.org/comm-central/source/mailnews/test/resources/logHelper.js that registers itself as a console listener and its low-tech feedback loop prevention. (NB: The quippy file-level comment should be

Re: Strange Error: Reentrancy error: some client, attempted to display a message to the console while in a console,listener

2015-07-01 Thread ISHIKAWA,chiaki
On 2015/07/01 15:53, Robert Strong wrote: I've only seen those when anything tries to print to the console after a test has called do_test_finish and in that case I suspect it is due to xpcshell shutting down, etc. Robert Thank you for your observation. I will investigate if this happens

Error of OS X build (c-c TB)

2015-11-13 Thread ISHIKAWA,chiaki
Hi, I am trying to test my patches by building C-C TB under OS X using try server. However, the build fails with the following compilation error. Since I don't have OS X (my local PC runs linux), I have no idea why the error occurs under OS X. BTW, I can build C-C TB under linux on my local PC,

Re: Error of OS X build (c-c TB)

2015-11-14 Thread ISHIKAWA,chiaki
not sure why others don't bump into this issue under OS X. My patch does NOT touch anything related to "TextArea", etc. TIA On Sat, Nov 14, 2015 at 1:05 PM, ISHIKAWA,chiaki <ishik...@yk.rim.or.jp> wrote: Hi, I am trying to test my patches by building C-C TB under OS X using try

Re: Error of OS X build (c-c TB)

2015-11-15 Thread ISHIKAWA,chiaki
On 2015/11/15 11:05, ISHIKAWA,chiaki wrote: On 2015/11/14 12:31, Xidorn Quan wrote: Have you checked your log here: https://treeherder.mozilla.org/logviewer.html#?job_id=11934=try-comm-central - Xidorn Yes, I have looked at it. The information there is sparse. The error indicates

Re: Error of OS X build (c-c TB)

2015-11-16 Thread ISHIKAWA,chiaki
On 2015/11/16 17:03, ISHIKAWA,chiaki wrote: On 2015/11/15 14:28, Xidorn Quan wrote: On Sun, Nov 15, 2015 at 1:05 PM, ISHIKAWA,chiaki <ishik...@yk.rim.or.jp> wrote: On 2015/11/14 12:31, Xidorn Quan wrote: Have you checked your log here: https://treeherder.mozilla.org/logviewer.html#?

Re: Error of OS X build (c-c TB)

2015-11-16 Thread ISHIKAWA,chiaki
On 2015/11/15 14:28, Xidorn Quan wrote: On Sun, Nov 15, 2015 at 1:05 PM, ISHIKAWA,chiaki <ishik...@yk.rim.or.jp> wrote: On 2015/11/14 12:31, Xidorn Quan wrote: Have you checked your log here: https://treeherder.mozilla.org/logviewer.html#?job_id=11934=try-comm-central - Xidorn Yes,

Re: Merging comm-central into mozilla-central (summary v1)

2015-11-06 Thread ISHIKAWA,chiaki
On 2015/10/27 9:06, Philipp Kewisch wrote: Hi all, I'd love to see if we can move towards an agreement. For those of you that would prefer not to merge, I'd love to hear what your absolute minimum requirements would be that you'd accept a merge with. Changes to hg? Changes to dxr? A policy

Re: Strange errors n OS X platform

2015-12-15 Thread ISHIKAWA, Chiaki
On 2015/12/15 23:40, Philip Chee wrote: On 13/12/2015 16:26, ISHIKAWA, Chiaki wrote: {"fun":"getCurrentDirectory","id":2} 14:54:20 INFO - PROCESS | 5963 | OS Controller Message posted 14:54:20 INFO - PROCESS | 5963 | OS Controller Expecting reply

Re: Question: "Chrome file doesn't exist: ..." in |make mozmill| log by running DEBUG versions of C-C TB

2015-11-24 Thread ISHIKAWA,chiaki
On 2015/11/24 20:21, Philip Chee wrote: On 22/11/2015 03:20, ISHIKAWA,chiaki wrote: 35 Chrome file doesn't exist: /NREF-COMM-CENTRAL/objdir-tb3/dist/bin/chrome/toolkit/skin/classic/global/icons/information-64.png information-64.png only exists in the osx theme http://mxr.mozilla.org

Question: why an external DTD is accessed (or not)? (svg11.dtd)

2015-11-21 Thread ISHIKAWA,chiaki
Hi, I have been puzzled at a pair of strange warning messages over the last few years, but can't hold the curiosity any longer. So here is my question. During the invocation of TB |make mozmill| test suite by running locally produced DEBUG version of C-C test, I have seen the following

Re: Question: why an external DTD is accessed (or not)? (svg11.dtd)

2015-11-21 Thread ISHIKAWA,chiaki
Thank you for the clarification. It is assuring to know that some people are aware of the issue. On 2015/11/22 3:59, Kyle Huey wrote: Bug 994305 is on file for this. - Kyle On Sat, Nov 21, 2015 at 10:57 AM, ISHIKAWA,chiaki <ishik...@yk.rim.or.jp> wrote: Hi, I have been puzzled at

Question: "Chrome file doesn't exist: ..." in |make mozmill| log by running DEBUG versions of C-C TB

2015-11-21 Thread ISHIKAWA,chiaki
Here is another question of mine that has bothered me for a long time. During the invocation of TB |make mozmill| test suite by running locally produced DEBUG version of C-C test, I have seen the following WARNING messages in the log regarding "Chrome file doesn't exist". I checked the

Re: Question: "Chrome file doesn't exist: ..." in |make mozmill| log by running DEBUG versions of C-C TB

2015-11-23 Thread ISHIKAWA,chiaki
On 2015/11/23 14:00, Philip Chee wrote: On 22/11/2015 03:20, ISHIKAWA,chiaki wrote: 100 Chrome file doesn't exist: /NREF-COMM-CENTRAL/objdir-tb3/dist/bin/chrome/classic/skin/classic/messenger/icons/dropbox.png Was removed in Bug 763471 - Convert Dropbox Filelink provider code to addon

Re: Using rr chaos mode to find intermittent bugs

2016-02-10 Thread ISHIKAWA,chiaki
On 2016/02/11 5:47, Robert O'Callahan wrote: On Thu, Feb 11, 2016 at 9:32 AM, Ted Mielczarek wrote: BenWa tried doing some work on this but kept getting hung up on hitting test failures unrelated to the ones we see in production, possibly due to environment issues. Yes.

Re: Using rr chaos mode to find intermittent bugs

2016-02-10 Thread ISHIKAWA,chiaki
On 2016/02/11 7:04, Robert O'Callahan wrote: rr should work fine with c-c xpcshell tests (and most other Linux programs). This sounds great! CI ___ dev-platform mailing list dev-platform@lists.mozilla.org

Re: Should &&/|| really be at the end of lines?

2017-02-17 Thread ISHIKAWA,chiaki
On 2017/02/18 7:28, Bobby Holley wrote: On Fri, Feb 17, 2017 at 2:18 PM, wrote: Hi again Nick, Someone made me realize that I didn't fully read your message, sorry for that. I now see that as well as &&/||, you have grepped for other operators, and shown that the

Re: Changing the representation of rectangles in platform code

2017-02-13 Thread ISHIKAWA,chiaki
On 2017/02/14 8:37, gsquel...@mozilla.com wrote: On Tuesday, February 14, 2017 at 3:25:05 AM UTC+11, Ehsan Akhgari wrote: On 2017-02-11 3:27 AM, ISHIKAWA,chiaki wrote: On 2017/02/11 7:07, Botond Ballo wrote: On Fri, Feb 10, 2017 at 3:45 PM, Milan Sreckovic <msrec...@mozilla.com> wrote:

Re: A reminder about MOZ_MUST_USE and [must_use]

2017-01-20 Thread ISHIKAWA,chiaki
On 2017/01/20 8:10, Nicholas Nethercote wrote: There are lots of functions where not checking the return value is reasonable, such as close(). A file opened for writing and is buffered will flush pending data to disk upon Close() and may encounter the error such as disk full AT THAT POINT,

Re: mach and ccache failure?

2016-08-20 Thread ISHIKAWA,chiaki
On 2016/08/20 10:03, Jan Varga wrote: I see the same problem on my mac, but I didn't investigate why it's not working anymore. Did ccacge ever work on the Mac to support two directories? (I mean the compilation result in one object directory could be substituted for the other object

Re: All profile settings lost in new version

2016-09-02 Thread ISHIKAWA,chiaki
On 2016/09/02 20:15, Wayne wrote: I'm wondering, under what circumstances would a user have a prefs.js-1 and prefs.js be missing? ref https://support.mozilla.org/en-US/questions/1136992 ___ dev-platform mailing list dev-platform@lists.mozilla.org

Re: NS_WARN_IF_FALSE has been renamed NS_WARNING_ASSERTION

2016-09-21 Thread ISHIKAWA,chiaki
On 2016/09/02 16:02, Nicholas Nethercote wrote: Greetings, NS_WARN_IF_FALSE has been renamed NS_WARNING_ASSERTION. See https://bugzilla.mozilla.org/show_bug.cgi?id=1299727 for details, including the justification. See https://bugzilla.mozilla.org/show_bug.cgi?id=137 for a bug that this

Strange error message on try-comm-central: Error: Invalid addon ID: expected addon ID specialpow...@mozilla.org, found special-pow...@mozilla.org in manifest

2016-09-22 Thread ISHIKAWA,chiaki
While perusing error log of try-comm-central run of Windows 7 debug version run of |make mozmill| test on try-comm-central treeherder, I noticed a strange error message. 3:07:56 INFO - 1474488476446 addons.xpi-utils WARN addMetadata: Add-on specialpow...@mozilla.org is invalid: Error:

Re: NS_WARN_IF_FALSE has been renamed NS_WARNING_ASSERTION

2016-09-21 Thread ISHIKAWA,chiaki
On 2016/09/22 5:56, Daniel Holbert wrote: On 09/21/2016 12:48 PM, ISHIKAWA,chiaki wrote: In the following URL about coding style, https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style --- begin quote --- if (NS_WARN_IF(somethingthatshouldbetrue)) { return

Re: New [must_use] property in XPIDL

2016-08-25 Thread ISHIKAWA,chiaki
On 2016/08/25 6:38, Mike Hommey wrote: On Mon, Aug 22, 2016 at 04:39:15PM -0700, R Kent James wrote: On 8/21/2016 9:14 PM, Nicholas Nethercote wrote: I strongly encourage people to do likewise on any IDL files with which they are familiar. Adding appropriate checks isn't always easy Exactly,

Heads up: valgrind/memcheck issues

2016-08-25 Thread ISHIKAWA,chiaki
Hi, I occasionally check C-C TB by running |make mozmill| test suite under valgrind/memcheck for detecting memory issues. I ran such a test the day before and saw a flurry of memcheck warnings which I did not see in the test that was run back on May 12th. So in three months between, some

  1   2   >