Re: PSA: Landing Rust code that warns is no longer ok

2018-12-15 Thread Kris Maglione
On Sat, Dec 15, 2018 at 04:06:05AM +0100, Emilio Cobos Álvarez wrote: In https://bugzilla.mozilla.org/show_bug.cgi?id=1513009 I just landed a patch so that warnings for non-third-party Rust code get reported as errors in automation, and thus fail to build (also if you build locally with --enabl

Re: PSA: Landing Rust code that warns is no longer ok

2018-12-15 Thread Emilio Cobos Álvarez
On 12/15/18 1:35 PM, Xidorn Quan wrote: Does it affect third-party crates? If there is a new warning hits a crate we use, would that cause the build to fail? I suppose not, otherwise there needs to be some additional policy to handle that case I gues? It does not. Cargo is very helpful and it

Re: PSA: Landing Rust code that warns is no longer ok

2018-12-15 Thread Xidorn Quan
On Sat, Dec 15, 2018, at 9:44 PM, Emilio Cobos Álvarez wrote: > In https://bugzilla.mozilla.org/show_bug.cgi?id=1513009 I just landed a > patch so that warnings for non-third-party Rust code get reported as > errors in automation, and thus fail to build (also if you build locally > with --enable