On Sat, Dec 15, 2018, at 9:44 PM, Emilio Cobos Álvarez wrote:
> In https://bugzilla.mozilla.org/show_bug.cgi?id=1513009 I just landed a
> patch so that warnings for non-third-party Rust code get reported as
> errors in automation, and thus fail to build (also if you build locally
> with --enable-warnings-as-errors).
>
> This is the equivalent of what we already do for C++ code (it's
> effectively the same of building with -Werror). It will hopefully avoid
> noise and catch mistakes early.
>
> This may make slightly more painful to update Rust toolchains, but not
> more than any other compiler update (plus I'm happy to help with that if
> needed). I suspect that this in practice won't be a big deal since a
> bunch of us build with Rust Nightly, and thus may notice and fix
> warnings earlier than they get to our automation.
>
> Anyway, let me know if you have any issues or complaints about that, and
> happy warning-free builds :)
Does it affect third-party crates? If there is a new warning hits a crate we
use, would that cause the build to fail? I suppose not, otherwise there needs
to be some additional policy to handle that case I gues?
- Xidorn
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform
