Re: Rust and --enable-shared-js

2018-10-03 Thread Mike Hommey
On Tue, Oct 02, 2018 at 03:25:04PM +0300, Henri Sivonen wrote: > On Mon, Sep 24, 2018 at 3:24 PM, Boris Zbarsky wrote: > > On 9/24/18 4:04 AM, Henri Sivonen wrote: > >> > >> How important is --enable-shared-js? I gather its use case is making > >> builds faster for SpiderMonkey developers. > > >

Re: Rust and --enable-shared-js

2018-10-02 Thread Luke Wagner
(Sorry, I polled #jsapi about this issue back when you first posted and then forgot to reply with the response.) It doesn't seem like any SM devs use --enable-shared-js for their own development but we do know that various embedders (e.g. GNOME) use the JS shared library and so we'd like to keep

Re: Rust and --enable-shared-js

2018-10-02 Thread Henri Sivonen
On Mon, Sep 24, 2018 at 3:24 PM, Boris Zbarsky wrote: > On 9/24/18 4:04 AM, Henri Sivonen wrote: >> >> How important is --enable-shared-js? I gather its use case is making >> builds faster for SpiderMonkey developers. > > > My use case for it is to be able to use the "exclude samples from library

Re: Rust and --enable-shared-js

2018-09-24 Thread Boris Zbarsky
On 9/24/18 4:04 AM, Henri Sivonen wrote: How important is --enable-shared-js? I gather its use case is making builds faster for SpiderMonkey developers. My use case for it is to be able to use the "exclude samples from library X" or "collapse library X" tools in profilers (like Instruments)

Re: Rust and --enable-shared-js

2018-09-24 Thread Mike Hommey
On Mon, Sep 24, 2018 at 11:04:43AM +0300, Henri Sivonen wrote: > There's an effort to add Rust code to SpiderMonkey: > https://bugzilla.mozilla.org/show_bug.cgi?id=1490948 > > This will introduce a jsrust_shared crate that will just depend on all > the Rust crates that SpiderMonkey needs like