Re: [dev-servo] Rustfmt now checked on CI

2018-11-07 Thread Keith Yeung
Woohoo! Great work everyone! On Wed, Nov 7, 2018 at 11:22 AM Josh Bowman-Matthews wrote: > > Thank you for all your help in formatting the existing code and enabling > rustfmt in CI! I'm very pleased that we've adopted rustfmt and that we > now have consistent formatting with the rest of the Rust

Re: [dev-servo] Outstanding concerns with WPT platform?

2018-09-26 Thread Keith Yeung
Following on your 3rd point about reducing code patterns that lead to TIMEOUTs, I'm wondering if the test harness has a function that allows you to fail the WPT entirely, without running the remaining tests? Here's an example of what I mean: suppose this function is named fail(), and we have the

Re: [dev-servo] Incremental compilation and other compile time tricks

2017-03-31 Thread Keith Yeung
This is a great write-up on the details of our compilation process, thanks Simon! > There is a risk that preserved files could be left by a previous builds in a broken state, leading to failures that only happen on CI. We’re monitoring this and will consider reverting this change it this turns

Re: [dev-servo] Android support

2017-03-07 Thread Keith Yeung
Have you also looked at https://github.com/paulrouget/servoshell/projects/2 ? I believe that some issues listed there are being addressed, maybe it also addresses the issues arising from supporting use case 3-5. On Tue, Mar 7, 2017 at 3:15 PM, Michael Howell wrote: >

Re: [dev-servo] Mentors needed (on IRC)

2016-08-23 Thread Keith Yeung
I happen to sleep pretty late, and actually write and read Traditional Chinese, so I'm quite likely to be on that time! Otherwise, I think Ms2ger, Manishearth, nox and waffles will be the people who are compatible with the GMT+8 timezone. On Tue, Aug 23, 2016 at 8:39 AM, Jack Moffitt

Re: [dev-servo] Please don't leave PRs without an assignee

2016-03-09 Thread Keith Yeung
Should we have a list of people who are familiar with a certain crate within Servo? I think the wiki has a list, but it seems oudated. On Mar 9, 2016 11:16 AM, "Jack Moffitt" wrote: > On Wed, Mar 9, 2016 at 8:25 AM, Josh Matthews > wrote: > > Hi

Re: [dev-servo] New Outreachy Intern

2015-12-06 Thread Keith Yeung
Welcome, welcome, Nikki Bee! My name is Keith and I was working on the Fetch spec (specifically, the files under components/net/fetch). If you have any questions or problems or just any hiccups you've encountered, don't hesistate to ping me in IRC (KiChjang) or Ms2ger or jdm, we'd all be happy to