Re: [dev-servo] 4/7 meeting notes (governance; q2 goals; rust upgrade; weekly status; web platform tests; build system; acid 2 epilogue)

2014-04-07 Thread Matt Brubeck
On 04/07/2014 12:20 PM, Andrew McCreight wrote: From context, it sounds like you are talking about module owners. I was curious, so I looked over the Core module owner list ( https://wiki.mozilla.org/Modules/Core ), and there are no modules with three owners. You're right - thanks for the

[dev-servo] RFC: Type-checked unit conversions for rust-geom and servo

2014-05-15 Thread Matt Brubeck
I've submitted the following pull request to add `Length` and `ScaleFactor` types to rust-geom. These types allow us to specify the unit of measure for any geometric quantity, and check at compile time that the correct conversion is applied before sending a value expressed in one unit to a fun

Re: [dev-servo] Fwd: Servo on Android

2014-07-10 Thread Matt Brubeck
On 10/07/14 14:39, Cristian Silaghi wrote: Can you share with me one recent build of Servo for Android? I want to test it on my phone, but it seems my distro is not able to build one (I'm using BBQLinux, based on Arch Linux). So can you send me "ServoAndroid-debug.apk" ? :) Here's my local Andro

[dev-servo] Important Cargo fixes

2014-09-14 Thread Matt Brubeck
Today's Cargo nightly contains some recent fixes to make it rebuild the correct crates after changes to non-Rust source files, like the codegen input files in Servo's |`script/dom/bindings`| and |`style/properties`| crates. To update to the newest Cargo nightly, run this command in your Servo

Re: [dev-servo] Important Cargo fixes

2014-09-15 Thread Matt Brubeck
On 09/15/2014 12:26 AM, Simon Sapin wrote: On 15/09/14 05:13, Matt Brubeck wrote: Today's Cargo nightly contains some recent fixes [...] Which version is that? I just updated to 3f6af3d 2014-09-13, which may or may not be today’s because of https://github.com/rust-lang/rust/issues

Re: [dev-servo] (Lack of) XML parser

2014-10-14 Thread Matt Brubeck
On 10/13/2014 09:26 PM, Simon Sapin wrote: https://github.com/servo/servo/wiki/Meeting-2014-10-13 kmc: [...] I was just reading about XML5 which uses an HTML parsing algorithm; possibly we could use for XML that instead of wiring up a proper XML parser. There are two different things. I sho

Re: [dev-servo] Meeting notes 10/20 (work week agenda; intermittent failure troubles; inversion of control; sync script loading; document load tracking)

2014-10-20 Thread Matt Brubeck
On 10/20/2014 11:08 AM, Boris Zbarsky wrote: I'm not sure I understand the sync script bit. You don't want to block user interaction with the page while fetching a

[dev-servo] Fwd: Firefox.html: rebuilding Firefox UI in HTML

2014-12-10 Thread Matt Brubeck
Paul Rouget started an experimental re-implementation of the Firefox desktop UI in HTML instead of XUL, using the Browser API ("iframe mozbrowser") from Firefox OS. One of his motivations was to build a browser UI that could someday be powered by Servo. See his email below, or read the full t

[dev-servo] Cargo top-level overrides

2016-04-19 Thread Matt Brubeck
Cargo recently gained the ability for the top-level crate (e.g. servo) to override any crate in the dependency tree. This is similar to the "paths" key in .cargo/config, but designed for longer-term shared use (rather than just for local development): https://github.com/rust-lang/cargo/pull/2385

Re: [dev-servo] Moving away from merge commits

2016-04-27 Thread Matt Brubeck
On Wed, Apr 27, 2016 at 7:25 AM, Manish Goregaokar wrote: > Another reason I prefer merge commits is that it becomes very easy to hunt > down which PR caused a bug (after using blame or pickaxe). We could potentially also make homu add this info (PR# and head commit) to the commit message or he

Re: [dev-servo] Moving away from merge commits

2016-04-27 Thread Matt Brubeck
On Tue, Apr 26, 2016 at 11:20 AM, Gregory Szorc wrote: > May I propose Servo change its landing bot to rebase commits instead of > merging them so that the repo history be linear so all the complexities > around merge commits can go away? > Personally I am in favor of this, though I don't feel s

[dev-servo] Intermittent shutdown panics on Mac

2016-05-06 Thread Matt Brubeck
We have a new intermittent failure that has been wreaking havoc on our CI all day. It's an intermittent shutdown panic in the script thread, possibly only on the Mac builders: https://github.com/servo/servo/issues/11059 Our usual trick of disabling tests won't work, since it seems to happen indi

Re: [dev-servo] Asynchronous image loading in layout

2016-05-25 Thread Matt Brubeck
In ancient double-digit-issue times, our forefather brson suggested that we could store some sort of promise or future in the display list, for images pending load: https://github.com/servo/servo/issues/43 Would something like this work? It might make sense to store the futures in the flow tree i

Re: [dev-servo] Servo without Bluetooth

2016-06-01 Thread Matt Brubeck
If the `bluetooth` feature is enabled by default, then you will also need to pass `--no-default-features` to the `cargo build` command (and then add back any features that you *do* want). We don't currently have a way to do this through `mach build` but it would be easy to add by adding a new argu

[dev-servo] Servo tree closed; testing issues

2017-01-24 Thread Matt Brubeck
Please do not approve any PRs in the servo/servo repo until #15164 is merged. #15064 accidentally caused our test automation to silently fail to run most of the CSS and WPT tests. This means that our builds will stay green and PRs will land even if they contain changes that break these tests. ht

Re: [dev-servo] Servo tree closed; testing issues

2017-01-24 Thread Matt Brubeck
This is now fixed and the Servo tree is open again. On Tue, Jan 24, 2017 at 11:21 AM, Matt Brubeck wrote: > Please do not approve any PRs in the servo/servo repo until #15164 is > merged. > > #15064 accidentally caused our test automation to silently fail to run > most of the CS

Re: [dev-servo] Standalone NDK concerns?

2018-03-06 Thread Matt Brubeck
We used to use a standalone toolchain: https://github.com/servo/servo/wiki/Building-for-Android/16f371c68d7da393d178646dcb18dac2c2ea8826 but this changed back in 2016; I'm not clear on the exact reasons: https://github.com/servo/servo/pull/13945 On Tue, Mar 6, 2018 at 4:46 PM, Josh Bowman-Matthew

Re: [dev-servo] ./mach build vs. cargo build

2018-04-05 Thread Matt Brubeck
We can set rustflags in the `[build]` section of .cargo/config: https://doc.rust-lang.org/cargo/reference/config.html On Wed, Apr 4, 2018 at 6:47 AM, Manish Goregaokar wrote: > IMO those reasons do not apply to toplevel flags; and given that Cargo > profiles are a thing we really should have a