Re: [JS-internals] Optimization tracking API landed

2015-02-06 Thread Nick Fitzgerald
Congrats on landing! Looking forward to seeing this used in the devtools! On Thu, Feb 5, 2015 at 4:20 PM, Shu-yu Guo wrote: > Greetings, fellow subtrahend incrementers! > > I recently landed bug 1030389 to track the high-level optimizations > decisions > (i.e., deciding what MIR is emitted) made

Re: [JS-internals] Updating JSClass of an Object?

2015-02-10 Thread Nick Fitzgerald
On Tue, Feb 10, 2015 at 9:14 AM, Jason Orendorff wrote: > On Tue, Feb 10, 2015 at 10:27 AM, Jason Hill > wrote: > > > 1 - Is it possible to update an object properties created on the JS land > ? > > What I need to do is that setting private data / data slot into any > Object > > created on the J

[JS-internals] PSA: Dump GC's retaining paths for any GC thing while debugging with JS::ubi::dumpPaths

2016-04-25 Thread Nick Fitzgerald
Hi everyone! Friendly PSA: sometimes you're debugging a "leak" where the GC considers something reachable and therefore won't collect it, and this happens at an inopportune time for using the devtools memory panel (eg right before a DESTROY_RUNTIME collection), so you can't use the nice GUI for vi

Re: [JS-internals] PSA: Dump GC's retaining paths for any GC thing while debugging with JS::ubi::dumpPaths

2016-04-25 Thread Nick Fitzgerald
uses this? > > On Mon, Apr 25, 2016 at 10:19 AM, Nick Fitzgerald > wrote: > >> Hi everyone! >> >> Friendly PSA: sometimes you're debugging a "leak" where the GC considers >> something reachable and therefore won't collect it, and this happen

Re: [JS-internals] OOM exceptions

2016-05-09 Thread Nick Fitzgerald
If we are going to leave bool behind, I think we should use something Rustic: template class MOZ_MUST_USE_TYPE Result : public mozilla::Variant { public: // Helper methods here... explicit operator bool () { return is(); } // Etc... }; Or, if we don't want to boil too many ocean

Re: [JS-internals] Rust JSAPI bindings in js/src?

2016-05-24 Thread Nick Fitzgerald
On Wed, May 11, 2016 at 8:33 AM, Steve Fink wrote: > On 05/11/2016 02:42 AM, Ms2ger wrote: > >> On 11/05/16 08:36, Jim Blandy wrote: >> >>> It looks like the lack of any CI of the SM-only distribution is a >>> non-trivial source of pain. That seems independent of where the Rust >>> JSAPI >>> bind

[JS-internals] Heads up: Don't use NSPR threading anymore, use js/src/threading/* instead!

2016-08-15 Thread Nick Fitzgerald
You may have seen some bug mail for https://bugzilla.mozilla.org/show_bug.cgi?id=956899 and its dependent bugs. Well, the migration off of NSPR threading is almost complete! Please don't introduce any more uses of NSPR threading or jslock.h, and if you're reviewing a patch, don't r+ any new uses.

Re: [JS-internals] Heads up: Don't use NSPR threading anymore, use js/src/threading/* instead!

2016-08-16 Thread Nick Fitzgerald
On Tue, Aug 16, 2016 at 10:01 AM, Ehsan Akhgari wrote: > On 2016-08-15 2:15 PM, Nick Fitzgerald wrote: > > You may have seen some bug mail for > > https://bugzilla.mozilla.org/show_bug.cgi?id=956899 and its dependent > bugs. > > Well, the migration off of NSPR thre

Re: [JS-internals] Heads up: Don't use NSPR threading anymore, use js/src/threading/* instead!

2016-08-22 Thread Nick Fitzgerald
actual NSPR headers or vm/PosixNSPR.h). Happy hacking! Nick ​[0] https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=4b6f61ea7594ae263945c95fc652d1aaad01042b [1] https://bugzilla.mozilla.org/show_bug.cgi?id=1295741​ On Mon, Aug 15, 2016 at 11:15 AM, Nick Fitzgerald w

Re: [JS-internals] Introducing new NSPR dependencies

2016-08-23 Thread Nick Fitzgerald
I was under the impression that NSPR threading in particular (and not the rest of NSPR) was one of the biggest reasons why --disable-shared-js was broken. I think we should be able to statically link NSPR inside js now. See https://bugzilla.mozilla.org/show_bug.cgi?id=1275639#c13 and that whole di

Re: [JS-internals] Overriding Error constructors

2016-09-27 Thread Nick Fitzgerald
We could probably switch to V8's stack string format and save you some trouble. * V8's format is more human readable * Error().stack's format is not constrained by any standard, so in theory changing it is web compatible... On Tue, Sep 27, 2016 at 1:54 PM, Ehsan Akhgari wrote: > I'd like to em

Re: [JS-internals] Overriding Error constructors

2016-09-28 Thread Nick Fitzgerald
​On Wed, Sep 28, 2016 at 9:25 AM, Ehsan Akhgari wrote: > On 2016-09-27 5:44 PM, Bobby Holley wrote: > > I heard some years ago that there exist websites which sniffs UAs and > > invokes separate stack parsing routines for each browser. I have no idea > > if we'd hit significant breakage in practi

Re: [JS-internals] JS engine multithreading

2017-01-27 Thread Nick Fitzgerald
What an exciting time! On Fri, Jan 27, 2017 at 7:36 AM, Brian Hackett wrote: > > To help avoid threading bugs during and after this transition, > ​​ > bug > 1325050 also adds a ProtectedData class, which is a template that can > be used on class fields to specify the conditions under which the >

Re: [JS-internals] Should we remove TraceLogger?

2017-08-11 Thread Nick Fitzgerald
On Fri, Aug 11, 2017 at 2:17 AM, Nicolas B. Pierron < nicolas.b.pier...@mozilla.com> wrote: > Also, as much good as I think of perf-html, we should be careful of what > we expose in perf-html. Remember that all users of perf-html are not Jit > experts, and that even exposing small information suc

[JS-internals] Rust bindings to SpiderMonkey on inbound

2017-09-01 Thread Nick Fitzgerald
(cc dev-servo, dev-platfrom; reply to js-engine-internals) Hello everyone! The Rust bindings to SpiderMonkey that Servo uses just landed in mozilla-inbound[0]! You can monitor their test results on taskcluster as the `SM-tc[tier-2](rust)` job. If any of your patches break these tests, please pin

Re: [JS-internals] C++ coding style rule for keeping class fields together

2017-09-29 Thread Nick Fitzgerald
There's also `ddbug`[0] for dumping layouts, but while such tools are useful, its annoying to be staring at a struct definition and not know what data members exist because their definitions interspersed with methods... [0] https://github.com/philipc/ddbug On Fri, Sep 29, 2017 at 2:43 AM, Lars Ha