[GitHub] activemq-artemis issue #1457: ARTEMIS-1343 Update Configuring Transports Doc...

Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1457 @clebertsuconic this is to support the original epoll work, we forgot to document, and obviously the new kqueue bits. --- If your project is set up for it, you can reply to

[GitHub] activemq-artemis pull request #1460: ARTEMIS-1347 - Pass the QueueBinding to...

GitHub user cshannon opened a pull request: https://github.com/apache/activemq-artemis/pull/1460 ARTEMIS-1347 - Pass the QueueBinding to beforeCreateConsumer Instead of just the queue name the entire QueueBinding object is now passed to the beforeCreateConsumer plugin method.

Re: Oracle - delivered Messages remain in ACTIVEMQ_MSGS

That DELETE statement is for durable topic subscribers. For queues, a delete is done when the message is acked, does you application acknowledge receipt of the message after onDelivery or is the session auto ack? On Thu, 10 Aug 2017 at 23:02 Heike Potter wrote: > We

[GitHub] activemq-artemis issue #1461: ARTEMIS-1348 Support LVQ for AMQP

Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1461 There is the _properties section (but these are predefined in qpid (org.apache.qpid.proton.amqp.messaging.Properties). e.g. you cannot add to this section as far as i can

[GitHub] activemq-artemis pull request #1461: ARTEMIS-1348 Support LVQ for AMQP

GitHub user michaelandrepearce opened a pull request: https://github.com/apache/activemq-artemis/pull/1461 ARTEMIS-1348 Support LVQ for AMQP Add support for LVQ, using the same property key as core "_AMQ_LVQ_NAME" Add test case for AMQP LVQ. You can merge this pull request into

[GitHub] activemq-artemis issue #1461: ARTEMIS-1348 Support LVQ for AMQP

Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1461 The reason I didn't implement it was the reason @tabish121 mentioned.. there's a proper way to do that with AMQPMessage (some property I don't remember now). --- If your project

[GitHub] activemq-artemis issue #1461: ARTEMIS-1348 Support LVQ for AMQP

Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1461 @tabish121 On point 1: This only is queried (and parsed) if the address is configured for LVQ. I believe on QPID java broker it is set in the same place

[GitHub] activemq-artemis issue #1461: ARTEMIS-1348 Support LVQ for AMQP

Github user tabish121 commented on the issue: https://github.com/apache/activemq-artemis/pull/1461 This approach has a couple of negatives going for it. First the use of application properties for message handling directives now requires that every incoming message will

[GitHub] activemq-artemis issue #1461: ARTEMIS-1348 Support LVQ for AMQP

Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1461 As i dig through this, it seems the only option if using QPID JMS wrapper without making that vendor specific (aka that i think should remain agnostic to artemis), is to use

[GitHub] activemq-artemis issue #1461: ARTEMIS-1348 Support LVQ for AMQP

Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1461 I guess if the parse properties only happens inside the last value queue it will be ok. I had tried to only parse properties when needed. E.g. Filters. --- If your project is

[GitHub] activemq-artemis issue #1461: ARTEMIS-1348 Support LVQ for AMQP

Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1461 Added to test case to check the property in JMS is the consumed message. Added to test case for it to check the behaviour is identical to Core protocol Lastly also I

[GitHub] activemq-artemis issue #1461: ARTEMIS-1348 Support LVQ for AMQP

Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1461 So I can confirm the method on interface Message.getLastValueProperty is only invoked by LastValueQueue. --- If your project is set up for it, you can reply to this email and

[GitHub] activemq-artemis issue #1459: ARTEMIS-1346 Add initial Management Console Do...

Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1459 @clebertsuconic this is to go with the new console, I'm sure there lots more to add, but thinking it can be an initial with the first release of it. --- If your project is set