[GitHub] activemq-artemis issue #1771: ARTEMIS-1600 Support masked passwords in boots...

2018-01-16 Thread gaohoward
Github user gaohoward commented on the issue: https://github.com/apache/activemq-artemis/pull/1771 well, almost done. Just found a unused var. I'll delete it right away. Sorry about that. :) ---

[GitHub] activemq-artemis pull request #1781: ARTEMIS-1613 Integrating JDBC into CLI ...

2018-01-16 Thread clebertsuconic
GitHub user clebertsuconic opened a pull request: https://github.com/apache/activemq-artemis/pull/1781 ARTEMIS-1613 Integrating JDBC into CLI (create print-data and exp) You can merge this pull request into a Git repository by running: $ git pull

[GitHub] activemq-artemis issue #1771: ARTEMIS-1600 Support masked passwords in boots...

2018-01-16 Thread gaohoward
Github user gaohoward commented on the issue: https://github.com/apache/activemq-artemis/pull/1771 @jbertram Hi Justin, I think it's done. Can you take a look again? Thanks ---

[GitHub] activemq-artemis pull request #1779: ARTEMIS-1612 Fix redistribution of pref...

2018-01-16 Thread mtaylor
Github user mtaylor closed the pull request at: https://github.com/apache/activemq-artemis/pull/1779 ---

[GitHub] activemq-artemis pull request #1774: ARTEMIS-1602 avoid potential NPE if pro...

2018-01-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1774 ---

[GitHub] activemq-artemis pull request #1778: ARTEMIS-1609 restore 'name' to ActiveMQ...

2018-01-16 Thread jmesnil
Github user jmesnil commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1778#discussion_r161788189 --- Diff: artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQDestination.java --- @@ -244,22 +249,30 @@ public

[GitHub] activemq-artemis issue #1778: ARTEMIS-1609 restore 'name' to ActiveMQDestina...

2018-01-16 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1778 @jbertram Can you please change SerializationTest on the compatibility test to make sure such field is translating correctly? ---

[GitHub] activemq-artemis pull request #1778: ARTEMIS-1609 restore 'name' to ActiveMQ...

2018-01-16 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/1778 ARTEMIS-1609 restore 'name' to ActiveMQDestination You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis

[GitHub] activemq-artemis pull request #1778: ARTEMIS-1609 restore 'name' to ActiveMQ...

2018-01-16 Thread jmesnil
Github user jmesnil commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1778#discussion_r161788722 --- Diff: artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQDestination.java --- @@ -273,6 +286,14 @@ public void

[GitHub] activemq-artemis pull request #1778: ARTEMIS-1609 restore 'name' to ActiveMQ...

2018-01-16 Thread jmesnil
Github user jmesnil commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1778#discussion_r161789136 --- Diff: artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQDestination.java --- @@ -309,7 +330,7 @@ public

[GitHub] activemq-artemis pull request #1780: ARTEMIS-1610 - Properly remove an addre...

2018-01-16 Thread cshannon
GitHub user cshannon opened a pull request: https://github.com/apache/activemq-artemis/pull/1780 ARTEMIS-1610 - Properly remove an address from the WildcardAddressManager When an address is removed from the address manager its linked addresses also need to be removed if there

[GitHub] activemq-artemis pull request #1778: ARTEMIS-1609 restore 'name' to ActiveMQ...

2018-01-16 Thread jbertram
Github user jbertram commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1778#discussion_r161794632 --- Diff: artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQDestination.java --- @@ -273,6 +286,14 @@ public void

[GitHub] activemq-artemis pull request #1778: ARTEMIS-1609 restore 'name' to ActiveMQ...

2018-01-16 Thread jbertram
Github user jbertram commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1778#discussion_r161794644 --- Diff: artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQDestination.java --- @@ -309,7 +330,7 @@ public

[GitHub] activemq-artemis issue #1778: ARTEMIS-1609 restore 'name' to ActiveMQDestina...

2018-01-16 Thread jbertram
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/1778 @clebertsuconic, will do. ---

[GitHub] activemq-artemis issue #1778: ARTEMIS-1609 restore 'name' to ActiveMQDestina...

2018-01-16 Thread jmesnil
Github user jmesnil commented on the issue: https://github.com/apache/activemq-artemis/pull/1778 @jbertram Could you also cherry pick https://github.com/jmesnil/activemq-artemis/commit/7769d43b610cf10dd5f2d82c1d0a3de3385109f0 That's built on top of what you are doing so

[GitHub] activemq-artemis pull request #1779: ARTEMIS-1612 Fix redistribution of pref...

2018-01-16 Thread mtaylor
GitHub user mtaylor opened a pull request: https://github.com/apache/activemq-artemis/pull/1779 ARTEMIS-1612 Fix redistribution of prefixed messages You can merge this pull request into a Git repository by running: $ git pull https://github.com/mtaylor/activemq-artemis

[GitHub] activemq-artemis issue #1778: ARTEMIS-1609 restore 'name' to ActiveMQDestina...

2018-01-16 Thread jbertram
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/1778 Take a look at the latest push and let me know what you think. I think I've got everything in there! ---

[GitHub] activemq-artemis pull request #1778: ARTEMIS-1609 restore 'name' to ActiveMQ...

2018-01-16 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1778#discussion_r161865199 --- Diff: tests/compatibility-tests/src/main/resources/serial/serial.groovy --- @@ -24,30 +24,46 @@ import

[GitHub] activemq-artemis pull request #1778: ARTEMIS-1609 restore 'name' to ActiveMQ...

2018-01-16 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1778#discussion_r161865850 --- Diff: tests/compatibility-tests/src/main/resources/serial/serial.groovy --- @@ -24,30 +24,46 @@ import

[GitHub] activemq-artemis pull request #1778: ARTEMIS-1609 restore 'name' to ActiveMQ...

2018-01-16 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1778#discussion_r161866462 --- Diff: tests/compatibility-tests/src/main/resources/serial/serial.groovy --- @@ -24,30 +24,46 @@ import

[GitHub] activemq-artemis pull request #1778: ARTEMIS-1609 restore 'name' to ActiveMQ...

2018-01-16 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1778#discussion_r161868236 --- Diff: tests/compatibility-tests/src/main/resources/serial/serial.groovy --- @@ -24,30 +24,46 @@ import

[GitHub] activemq-artemis pull request #1778: ARTEMIS-1609 restore 'name' to ActiveMQ...

2018-01-16 Thread jbertram
Github user jbertram commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1778#discussion_r161868488 --- Diff: tests/compatibility-tests/src/main/resources/serial/serial.groovy --- @@ -24,30 +24,46 @@ import