[GitHub] activemq-artemis pull request #:

2018-02-15 Thread clebertsuconic
Github user clebertsuconic commented on the pull request: https://github.com/apache/activemq-artemis/commit/6470e7e64d883282624619adc9d4816fa1688a1e#commitcomment-27598084 Any way we could use this for the full testsuite ? ---

[GitHub] activemq-artemis issue #1793: ARTEMIS-1498: Openwire internal headers should...

2018-02-15 Thread RaiSaurabh
Github user RaiSaurabh commented on the issue: https://github.com/apache/activemq-artemis/pull/1793 @michaelandrepearce I have implemented the changes asked and also checked that this persists to disk and is recoverable on restart of the broker without converting to the core message.

[GitHub] activemq-artemis pull request #1793: ARTEMIS-1498: Openwire internal headers...

2018-02-15 Thread RaiSaurabh
Github user RaiSaurabh commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1793#discussion_r168675085 --- Diff: artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireMessage.java ---

[GitHub] activemq-artemis pull request #1793: ARTEMIS-1498: Openwire internal headers...

2018-02-15 Thread RaiSaurabh
Github user RaiSaurabh commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1793#discussion_r168675067 --- Diff: artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireMessage.java ---

[GitHub] activemq-artemis pull request #1793: ARTEMIS-1498: Openwire internal headers...

2018-02-15 Thread RaiSaurabh
Github user RaiSaurabh commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1793#discussion_r168675045 --- Diff: artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireMessage.java ---

[GitHub] activemq-artemis issue #1793: ARTEMIS-1498: Openwire internal headers should...

2018-02-15 Thread RaiSaurabh
Github user RaiSaurabh commented on the issue: https://github.com/apache/activemq-artemis/pull/1793 Seems some issue with Travis and Jenkins for this project is disabled. ---

[GitHub] activemq-artemis issue #1866: ARTEMIS-1660: Remove oracle12 autoincrement fr...

2018-02-15 Thread franz1981
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/1866 Please run the JDBC tests with Oracle 12 (now possible using the right sys properties) and fix the PR tile/message ---

[GitHub] activemq-artemis issue #1822: Allow existing empty tables

2018-02-15 Thread franz1981
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/1822 @nlippke If possible change the name of the PR with the reporting JIRA + title ---

[GitHub] activemq-artemis issue #1822: ARTEMIS-1653 Allow database tables to be creat...

2018-02-15 Thread nlippke
Github user nlippke commented on the issue: https://github.com/apache/activemq-artemis/pull/1822 @franz1981 Done. ---

[GitHub] activemq-artemis issue #1869: ARTEMIS-1680 - Message load balancing type isn...

2018-02-15 Thread Skiler
Github user Skiler commented on the issue: https://github.com/apache/activemq-artemis/pull/1869 Hi @clebertsuconic , I hope it's good now. Let me know if you have any thing else. Thanks ---

[GitHub] activemq-artemis issue #1866: ARTEMIS-1660: Remove oracle12 autoincrement fr...

2018-02-15 Thread graben
Github user graben commented on the issue: https://github.com/apache/activemq-artemis/pull/1866 @franz1981 : sorry I don't understand what you would like to tell? Do you think the title is wrong? Do you think my patch is wrong? ---

[GitHub] activemq-artemis issue #1864: ARTEMIS-1677:On Linux machine AIO journal type...

2018-02-15 Thread franz1981
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/1864 @RaiSaurabh Please change the JIRA/PR title into something more explicit related to the wrong documentation, because while reading it seems that Artemis doesn't support ASYNCIO on NFS

[GitHub] activemq-artemis issue #1866: ARTEMIS-1660: Remove oracle12 autoincrement fr...

2018-02-15 Thread franz1981
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/1866 @graben > Please run the JDBC tests with Oracle 12 (now possible using the right sys properties) Currently we're not supporting Oracle into the Jenkins CI hence please

[GitHub] activemq-artemis issue #1866: ARTEMIS-1660: Remove oracle12 autoincrement fr...

2018-02-15 Thread graben
Github user graben commented on the issue: https://github.com/apache/activemq-artemis/pull/1866 Well, I'm actually not able to test against oracle 12 only have a oracle 11 express instance. But a it is obvious that the autoincrement of id is wrong, since it is 1st managed by the

Re: [DISCUSS] Rework NMS.AMQP

2018-02-15 Thread Duane Pauls
In particular, I think we are wondering whether it would be considered feasible to work towards an initial release with the VS2017 project and solution files. This would require those who want to build it to either use VS2017 to build, or to use the dotnet sdk tool, as is described in the

[GitHub] activemq-artemis pull request #1872: ARTEMIS-1684 enable Travis CI

2018-02-15 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/1872 ARTEMIS-1684 enable Travis CI You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-1684 Alternatively

Re: [DISCUSS] Rework NMS.AMQP

2018-02-15 Thread Duane Pauls
Thanks for the feedback Tim. We're relatively new to the community so it's very much appreciated. We had planned to setup the 2017 project files to automatically pull in the NMS and AmqpNetLite packages via NuGet. So there shouldn't be a need for those planning to build this project to build

Re: [DISCUSS] Rework NMS.AMQP

2018-02-15 Thread Timothy Bish
On 02/15/2018 11:57 AM, Duane Pauls wrote: In particular, I think we are wondering whether it would be considered feasible to work towards an initial release with the VS2017 project and solution files. This would require those who want to build it to either use VS2017 to build, or to use the

Using Environment Variables in Activemq.xml

2018-02-15 Thread jason_pacino
Is it possible to use environment variables in the activemq.xml file? For anything that is specific to my cluster. Broker name, Lockdb location and user, persistence db location etc? -- Sent from: http://activemq.2283324.n4.nabble.com/ActiveMQ-Dev-f2368404.html