[GitHub] activemq-artemis pull request #2003: ARTEMIS-1788 JDBC HA should use JDBC Ne...

2018-04-09 Thread franz1981
GitHub user franz1981 opened a pull request: https://github.com/apache/activemq-artemis/pull/2003 ARTEMIS-1788 JDBC HA should use JDBC Network Timeout JdbcNodeManager is configured to use the same network timeout value of the journal and to validate all the timeout values

[GitHub] activemq-artemis pull request #2003: ARTEMIS-1788 JDBC HA should use JDBC Ne...

2018-04-09 Thread dudaerich
Github user dudaerich commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2003#discussion_r180128459 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/jdbc/JdbcSharedStateManager.java --- @@ -73,7 +77,27 @@

[GitHub] activemq-artemis issue #2003: ARTEMIS-1788 JDBC HA should use JDBC Network T...

2018-04-09 Thread dudaerich
Github user dudaerich commented on the issue: https://github.com/apache/activemq-artemis/pull/2003 @franz1981 ok :) So the rest of code looks good to me. Thank you! ---

Re: Board report for April 2018

2018-04-09 Thread Bruce Snyder
Happy Monday morning! The board report for April has not received any contributions yet and I must submit it by Wednesday, April 11th. The report needs information on project activity for the following three categories: * ActiveMQ * Artemis * Other If you can contribute any information about

[GitHub] activemq-artemis pull request #2000: ARTEMIS-1791 Large message files are no...

2018-04-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2000 ---

[GitHub] activemq-artemis pull request #1999: ARTEMIS-1790 Improve Topology Member Fi...

2018-04-09 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1999#discussion_r180162324 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/TopologyMemberImpl.java --- @@ -105,12 +105,16

[GitHub] activemq-artemis pull request #2002: ARTEMIS-1796 AMQP flush during handshak...

2018-04-09 Thread clebertsuconic
GitHub user clebertsuconic opened a pull request: https://github.com/apache/activemq-artemis/pull/2002 ARTEMIS-1796 AMQP flush during handshake can break SASL You can merge this pull request into a Git repository by running: $ git pull

[GitHub] activemq-artemis pull request #1999: ARTEMIS-1790 Improve Topology Member Fi...

2018-04-09 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1999#discussion_r180134239 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/TopologyMemberImpl.java --- @@ -105,12 +105,16

[GitHub] activemq-artemis pull request #2003: ARTEMIS-1788 JDBC HA should use JDBC Ne...

2018-04-09 Thread dudaerich
Github user dudaerich commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2003#discussion_r180127063 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/jdbc/JdbcNodeManager.java --- @@ -95,18 +98,25 @@ public

[GitHub] activemq-artemis pull request #1999: ARTEMIS-1790 Improve Topology Member Fi...

2018-04-09 Thread gaohoward
Github user gaohoward commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1999#discussion_r180155663 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/TopologyMemberImpl.java --- @@ -105,12 +105,16 @@

[GitHub] activemq-artemis issue #2003: ARTEMIS-1788 JDBC HA should use JDBC Network T...

2018-04-09 Thread franz1981
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/2003 @dudaerich I've not yet pushed the PR that uses just the DB time, that's why that property it not removed ---

[GitHub] activemq-artemis issue #2003: ARTEMIS-1788 JDBC HA should use JDBC Network T...

2018-04-09 Thread franz1981
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/2003 @dudaerich Please check if the bits of documentation and the validation performed makes sense/are complete. I will provide an additional test on it if it will pass :+1: ---

[GitHub] activemq-artemis pull request #2003: ARTEMIS-1788 JDBC HA should use JDBC Ne...

2018-04-09 Thread dudaerich
Github user dudaerich commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2003#discussion_r180128804 --- Diff: docs/user-manual/en/persistence.md --- @@ -456,6 +456,7 @@ To configure Apache ActiveMQ Artemis to use a database for persisting

[GitHub] activemq-artemis pull request #2002: ARTEMIS-1796 AMQP flush during handshak...

2018-04-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2002 ---

[GitHub] activemq-artemis pull request #2004: ARTEMIS-1793 fix 'destination-type' STO...

2018-04-09 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/2004 ARTEMIS-1793 fix 'destination-type' STOMP header You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis

Re: Board report for April 2018

2018-04-09 Thread Michael André Pearce
Hi Bruce, It seems same issue as last time, i don’t have rights to edit directly. Can you check the space permissions for my user: michael.andre.pearce Bits i would add / comment on are: Artemis released 2.5.0 Effort to create updated website continues but slowly, a webex was had last month

[GitHub] activemq-artemis pull request #1999: ARTEMIS-1790 Improve Topology Member Fi...

2018-04-09 Thread gaohoward
Github user gaohoward commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1999#discussion_r180279022 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/TopologyMemberImpl.java --- @@ -105,12 +105,16 @@

[GitHub] activemq-artemis pull request #1999: ARTEMIS-1790 Improve Topology Member Fi...

2018-04-09 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1999#discussion_r180281260 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/TopologyMemberImpl.java --- @@ -105,12 +105,16

[GitHub] activemq-artemis pull request #1999: ARTEMIS-1790 Improve Topology Member Fi...

2018-04-09 Thread gaohoward
Github user gaohoward commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1999#discussion_r180281379 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/TopologyMemberImpl.java --- @@ -105,12 +105,16 @@

[GitHub] activemq-artemis issue #2003: ARTEMIS-1788 JDBC HA should use JDBC Network T...

2018-04-09 Thread dudaerich
Github user dudaerich commented on the issue: https://github.com/apache/activemq-artemis/pull/2003 I've also noticed that in the documentation there is still `jdbc-max-allowed-millis-from-db-time` which was already removed. ---

[GitHub] activemq-artemis pull request #2003: ARTEMIS-1788 JDBC HA should use JDBC Ne...

2018-04-09 Thread franz1981
Github user franz1981 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2003#discussion_r180129827 --- Diff: docs/user-manual/en/persistence.md --- @@ -456,6 +456,7 @@ To configure Apache ActiveMQ Artemis to use a database for persisting

[GitHub] activemq-artemis pull request #1975: [ARTEMIS-1761] Log warning if cluster i...

2018-04-09 Thread rstancel
Github user rstancel commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1975#discussion_r180048729 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/impl/BridgeImpl.java --- @@ -930,9 +930,7 @@ protected

[GitHub] activemq-artemis issue #1997: ARTEMIS-1653 Allow database tables to be creat...

2018-04-09 Thread nlippke
Github user nlippke commented on the issue: https://github.com/apache/activemq-artemis/pull/1997 👍 ---

[GitHub] activemq-artemis issue #1994: ARTEMIS-1787 Openwire message should not conta...

2018-04-09 Thread stanlyDoge
Github user stanlyDoge commented on the issue: https://github.com/apache/activemq-artemis/pull/1994 This PR is partly reverting https://github.com/apache/activemq-artemis/pull/1734 AFAIK including some internal properties break JMS API specification. ---

[GitHub] activemq-artemis pull request #1997: ARTEMIS-1653 Allow database tables to b...

2018-04-09 Thread nlippke
Github user nlippke commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1997#discussion_r180005903 --- Diff: artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/drivers/AbstractJDBCDriver.java --- @@ -179,32 +179,61 @@

[GitHub] activemq-artemis pull request #1997: ARTEMIS-1653 Allow database tables to b...

2018-04-09 Thread franz1981
Github user franz1981 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1997#discussion_r180007702 --- Diff: artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/drivers/AbstractJDBCDriver.java --- @@ -179,32 +179,61 @@

[GitHub] activemq-artemis pull request #1997: ARTEMIS-1653 Allow database tables to b...

2018-04-09 Thread franz1981
Github user franz1981 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1997#discussion_r180007558 --- Diff: artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/drivers/AbstractJDBCDriver.java --- @@ -179,32 +179,61 @@

[GitHub] activemq-artemis pull request #1997: ARTEMIS-1653 Allow database tables to b...

2018-04-09 Thread nlippke
Github user nlippke commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1997#discussion_r180006216 --- Diff: artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/drivers/AbstractJDBCDriver.java --- @@ -179,32 +179,61 @@

[GitHub] activemq-artemis pull request #2000: ARTEMIS-1791 Large message files are no...

2018-04-09 Thread gaohoward
GitHub user gaohoward opened a pull request: https://github.com/apache/activemq-artemis/pull/2000 ARTEMIS-1791 Large message files are not removed after redistribution across a cluster You can merge this pull request into a Git repository by running: $ git pull

[GitHub] activemq-artemis pull request #:

2018-04-09 Thread jclagache
Github user jclagache commented on the pull request: https://github.com/apache/activemq-artemis/commit/7fc895d27097bc9f7247f760831391eb4e7e506d#commitcomment-28486183 `-Djava.security.auth.login.config=%ARTEMIS_INSTANCE_ETC%\login.config` should then become :

[GitHub] activemq-artemis pull request #2001: ARTEMIS-1792 race in STOMP unsubscribe

2018-04-09 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/2001 ARTEMIS-1792 race in STOMP unsubscribe You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-1792