[GitHub] activemq-artemis pull request #2097: ARTEMIS-1876 InVMNodeManager shouldn't ...

2018-05-22 Thread franz1981
GitHub user franz1981 opened a pull request: https://github.com/apache/activemq-artemis/pull/2097 ARTEMIS-1876 InVMNodeManager shouldn't be used if no JDBC HA is configured (cherry picked from commit f886c0bdb451c947143fba6cf07cbf8ce7f3ff4d) You can merge this pull request into a

Re: [DISCUSS] Commits report

2018-05-22 Thread Robbie Gemmell
If its being linked to later I'd just put it in a subdir of the website. I'd do that even before/during the vote so it isnt complicating the final release steps as it did this time. Alternatively, or if it isnt being linked to later, at least moving it to a different subdir of the dist dev area

[GitHub] activemq-artemis pull request #2096: ARTEMIS-1876 InVMNodeManager shouldn't ...

2018-05-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2096 ---

[GitHub] activemq-artemis issue #2096: ARTEMIS-1876 InVMNodeManager shouldn't be used...

2018-05-22 Thread franz1981
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/2096 @andytaylor The tests seems fine to me, so it is ok :+1: ---

[GitHub] activemq-artemis pull request #2093: ARTEMIS-1872 Check for queue exists bef...

2018-05-22 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2093#discussion_r189874889 --- Diff: artemis-commons/src/main/java/org/apache/activemq/artemis/api/core/SimpleString.java --- @@ -150,6 +150,10 @@ public

[ANNOUNCE] ActiveMQ Artemis 2.6.0 Released

2018-05-22 Thread Clebert Suconic
I'm pleased to announce the release of ActiveMQ Artemis 2.6.0 Downloads are now available at: http://activemq.apache.org/artemis/download.html For a complete list of updates: http://activemq.apache.org/artemis/release-notes-2.6.0.html A detailed list of git commits:

[GitHub] activemq-artemis pull request #2093: ARTEMIS-1872 Check for queue exists bef...

2018-05-22 Thread franz1981
Github user franz1981 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2093#discussion_r189859957 --- Diff: artemis-commons/src/main/java/org/apache/activemq/artemis/api/core/SimpleString.java --- @@ -150,6 +150,10 @@ public CharSequence

[GitHub] activemq-artemis issue #2093: ARTEMIS-1872 Check for queue exists before cre...

2018-05-22 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/2093 @jbertram fixed checkstyle introduced in last change, to address franz's review comment. ---

Re: [DISCUSS] Commits report

2018-05-22 Thread Clebert Suconic
What I meant was the project itself.. It's currently living on my github fork. I don't have an issue with it living on my page only.. I was just checking if anyone want a better home for it. I will add a step (tomorrow) on how to generate the report. On Tue, May 22, 2018 at 6:06 AM, Robbie

Re: [DISCUSS] Commits report

2018-05-22 Thread Robbie Gemmell
Ah, I thought you meant the reports themselves. I dont see an issue with it being where it is, most of the tools we use come from other places, but it might be simple to use if it was in the website repo or dist dev area, alongside where the output is being generated. On 22 May 2018 at 14:47,

[GitHub] activemq-artemis issue #2093: ARTEMIS-1872 Check for queue exists before cre...

2018-05-22 Thread jbertram
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/2093 Looks like a checkstyle violation. ---

[GitHub] activemq-artemis issue #2097: ARTEMIS-1876 InVMNodeManager shouldn't be used...

2018-05-22 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2097 @franz1981 close this PR.. it was merged with a rebase.. IDs were changed. ---

[GitHub] activemq-artemis issue #2093: ARTEMIS-1872 Check for queue exists before cre...

2018-05-22 Thread jbertram
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/2093 This looks good to me. @clebertsuconic, what do you think? ---

[GitHub] activemq-artemis issue #2093: ARTEMIS-1872 Check for queue exists before cre...

2018-05-22 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2093 I took a day off after the release:) If you are happy with it feel free to merge it. We can amend later if anything is failing. Or I can merge later tonight or tomorrow

[GitHub] activemq-nms-amqp pull request #1: AMQNET-576: Clean out old code base for N...

2018-05-22 Thread RagnarPaulson
GitHub user RagnarPaulson opened a pull request: https://github.com/apache/activemq-nms-amqp/pull/1 AMQNET-576: Clean out old code base for NMS AMQP client provider. The first step to replacing the NMS AMQP client with a fully managed client based on AMQPNetLite is to remove the

[GitHub] activemq-artemis pull request #2098: ARTEMIS-1873 STOMP heartbeater left ali...

2018-05-22 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/2098 ARTEMIS-1873 STOMP heartbeater left alive on cxn destroy You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis

[GitHub] activemq-artemis issue #2098: ARTEMIS-1873 STOMP heartbeater left alive on c...

2018-05-22 Thread jbertram
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/2098 I've got a test I want to add to this so don't merged it yet. ---

[GitHub] activemq-artemis pull request #2098: ARTEMIS-1873 STOMP heartbeater left ali...

2018-05-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2098 ---

[GitHub] activemq-artemis issue #2098: ARTEMIS-1873 STOMP heartbeater left alive on c...

2018-05-22 Thread jbertram
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/2098 Test has been added. Please review and merge. ---

Re: [ANNOUNCE] Apache ActiveMQ 5.15.4 Released

2018-05-22 Thread Anindya Haldar
How does the this version relate to the Apache ActiveMQ Artemis versioning? Is there a mapping, or is it completely separate from Artemis? We are evaluating Artemis; so are wondering. Thanks, Anindya Haldar Oracle Marketing Cloud > On May 22, 2018, at 11:34 AM, Christopher Shannon >

[ANNOUNCE] Apache ActiveMQ 5.15.4 Released

2018-05-22 Thread Christopher Shannon
Hi everyone, The ActiveMQ team is pleased to announce that Apache ActiveMQ 5.15.4 has been released. A list of issues resolved in this release is available here: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311210=12342685 The Wiki page for the release is here:

[GitHub] activemq-artemis issue #2093: ARTEMIS-1872 Check for queue exists before cre...

2018-05-22 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/2093 Ill have a look i think i know what it is (need to add filter check at same point as exists check and should be super simple. ---

[GitHub] activemq-artemis issue #2093: ARTEMIS-1872 Check for queue exists before cre...

2018-05-22 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/2093 Should be sorted now. Added checks for address and filterstring at along side checking the queue exists. Ive run locally SharedConsumerTest you mentioned and

[GitHub] activemq-artemis pull request #2096: ARTEMIS-1876 InVMNodeManager shouldn't ...

2018-05-22 Thread franz1981
GitHub user franz1981 opened a pull request: https://github.com/apache/activemq-artemis/pull/2096 ARTEMIS-1876 InVMNodeManager shouldn't be used if no JDBC HA is configured When database persistence and no shared store option is being used, Artemis is choosing to use

[GitHub] activemq-artemis issue #2096: ARTEMIS-1876 InVMNodeManager shouldn't be used...

2018-05-22 Thread franz1981
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/2096 @andytaylor It is causing several regressions on Oracle tests, so it needs to be ported on 1.x as well. ATM I'm waiting the tests to finish and I will push it for 1.x as well ---