[GitHub] activemq-artemis pull request #2103: ARTEMIS-1872 Improving Security Checks ...

2018-05-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2103 ---

[GitHub] activemq-artemis pull request #2101: ARTEMIS-1853 Adding Netty OpenSSL provi...

2018-05-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2101 ---

[GitHub] activemq-artemis pull request #2097: ARTEMIS-1876 InVMNodeManager shouldn't ...

2018-05-23 Thread franz1981
Github user franz1981 closed the pull request at: https://github.com/apache/activemq-artemis/pull/2097 ---

Re: [ANNOUNCE] Apache ActiveMQ 5.15.4 Released

2018-05-23 Thread michael.andre.pearce
It does not. This is the classic ActiveMQ 5.x range that just had release. ActiveMq Artemis has its own versioning currently 2.6.0 just released this week also. You can find artemis latest and historic versions here: https://activemq.apache.org/artemis/download.html Sent from my Samsung Galaxy

[GitHub] activemq-artemis pull request #2099: [ARTEMIS-1879] Warnings in log when fai...

2018-05-23 Thread JiriOndrusek
GitHub user JiriOndrusek opened a pull request: https://github.com/apache/activemq-artemis/pull/2099 [ARTEMIS-1879] Warnings in log when failover is executed after clean … …shut down Issue: https://issues.apache.org/jira/browse/ARTEMIS-1879 Test is not

[GitHub] activemq-artemis pull request #2105: ARTEMIS-1872 Fixing address security ch...

2018-05-23 Thread michaelandrepearce
GitHub user michaelandrepearce opened a pull request: https://github.com/apache/activemq-artemis/pull/2105 ARTEMIS-1872 Fixing address security checks Ensure CREATE_ADDRESS is honored and behavior is consistent across protocols. You can merge this pull request into a Git

[GitHub] activemq-artemis pull request #2104: ARTEMIS-1872 Fixing Security test

2018-05-23 Thread clebertsuconic
GitHub user clebertsuconic opened a pull request: https://github.com/apache/activemq-artemis/pull/2104 ARTEMIS-1872 Fixing Security test You can merge this pull request into a Git repository by running: $ git pull https://github.com/clebertsuconic/activemq-artemis

[GitHub] activemq pull request #284: Avoid overflow errors with timestamps

2018-05-23 Thread thisthat
GitHub user thisthat opened a pull request: https://github.com/apache/activemq/pull/284 Avoid overflow errors with timestamps Some comparisons with timestamp values are not safe. This comparisons can trigger errors that were found in other Apache projects, e.g. KAFKA-4290. I

[GitHub] activemq-artemis pull request #2103: ARTEMIS-1872 Improving Security Checks ...

2018-05-23 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2103#discussion_r190438892 --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/server/SecureConfigurationTest.java ---

[GitHub] activemq-artemis pull request #2103: ARTEMIS-1872 Improving Security Checks ...

2018-05-23 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2103#discussion_r190437791 --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/server/SecureConfigurationTest.java ---

[GitHub] activemq-artemis pull request #2103: ARTEMIS-1872 Improving Security Checks ...

2018-05-23 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2103#discussion_r190437930 --- Diff: tests/integration-tests/src/test/resources/multicast_topic.xml --- @@ -85,13 +85,13 @@ under the License.

[GitHub] activemq-artemis pull request #2102: ARTEMIS-1882 verify PKCS12 keystores wo...

2018-05-23 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2102#discussion_r190442460 --- Diff: tests/compatibility-tests/src/main/resources/servers/artemisServer.groovy --- @@ -44,7 +44,7 @@ try { if

[GitHub] activemq-artemis pull request #2104: ARTEMIS-1872 Fixing Security test

2018-05-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2104 ---

[GitHub] activemq-artemis issue #2093: ARTEMIS-1872 Check for queue exists before cre...

2018-05-23 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2093 @michaelandrepearce Maybe I'm being slow.. but why do you need to check for version here? shouldn't this be a simple fix on checking the address before? from

[GitHub] activemq-artemis pull request #2100: Amending fixes from #2093

2018-05-23 Thread clebertsuconic
GitHub user clebertsuconic opened a pull request: https://github.com/apache/activemq-artemis/pull/2100 Amending fixes from #2093 Amending fixes from #2093 You can merge this pull request into a Git repository by running: $ git pull

[GitHub] activemq-artemis issue #2093: ARTEMIS-1872 Check for queue exists before cre...

2018-05-23 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2093 that would mean older clients will still hit the bug if you keep the version check ---

[GitHub] activemq-artemis issue #2093: ARTEMIS-1872 Check for queue exists before cre...

2018-05-23 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2093 compatibility tests are passing with this.. do you know any cases where this would brea compatibility and the current tests have missed it? if that's the case we need to add a test

[GitHub] activemq-artemis issue #2093: ARTEMIS-1872 Check for queue exists before cre...

2018-05-23 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2093 the more I digg.. the more I'm convinced there's no need for the version check... if we can speak on IRC before we merge this? The version check was basically for wire

[GitHub] activemq-artemis pull request #2101: ARTEMIS-1853 Adding Netty OpenSSL provi...

2018-05-23 Thread gaohoward
GitHub user gaohoward opened a pull request: https://github.com/apache/activemq-artemis/pull/2101 ARTEMIS-1853 Adding Netty OpenSSL provider test Added an example to demonstrate how to configure and use openssl Moved/Added netty-tcnative dependency to artemis-distribution

[GitHub] activemq-artemis issue #2100: Amending fixes from #2093

2018-05-23 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/2100 Could you send PR to my branch so i can see what youve changed from my intial solution i think we may jusy have cross wires but i cant figure the change out. Im out today and

[GitHub] activemq-artemis issue #2100: Amending fixes from #2093

2018-05-23 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/2100 Thanks for sending pr to my private fork, looks fine and just cross wires / my misunderstanding of what you meant. Im happy, ---

[GitHub] activemq-artemis issue #2100: Amending fixes from #2093

2018-05-23 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/2100 So as i said im away from a computer so i cant test it but as long as the test passes i added im happy. ---

[GitHub] activemq-artemis issue #2100: Amending fixes from #2093

2018-05-23 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2100 @michaelandrepearce I was just trying to understand if you really needed the semantic difference on the client.. but I couldn't find a reason.. if you are happy on just reverting

[GitHub] activemq-artemis issue #2093: ARTEMIS-1872 Check for queue exists before cre...

2018-05-23 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/2093 Ill close this if you merge yours, im happy with yours. ---

[GitHub] activemq-artemis issue #2100: Amending fixes from #2093

2018-05-23 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/2100 Eg +1 Im happy with what you have i think its all fine ---

[GitHub] activemq-artemis issue #2100: Amending fixes from #2093

2018-05-23 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2100 @michaelandrepearce this is removing the version bumping check. I don't think we need it. If we merge this PR, #2093 would be closed automatically by the apache bot.

[GitHub] activemq-artemis issue #2100: Amending fixes from #2093

2018-05-23 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/2100 Version check was because after the version its fixed client side. ---

[GitHub] activemq-artemis issue #2100: Amending fixes from #2093

2018-05-23 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/2100 Re test its to run the test i added with old client. I did this manually, i couldnt figure how automatically ---

[GitHub] activemq-artemis issue #2100: Amending fixes from #2093

2018-05-23 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2100 The only change I saw on the client was a queueQuery done first... the server's change would still be compatible with older clients from what I saw. If we really need a

[GitHub] activemq-artemis pull request #2102: ARTEMIS-1882 verify PKCS12 keystores wo...

2018-05-23 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/2102 ARTEMIS-1882 verify PKCS12 keystores work You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-1882

[GitHub] activemq-artemis issue #2093: ARTEMIS-1872 Check for queue exists before cre...

2018-05-23 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2093 I am merging your changes.. however I'm reverting the portion of the version properties check. we may revisit this later if you see any other issues. To make eventual

[GitHub] activemq-artemis issue #2100: Amending fixes from #2093

2018-05-23 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2100 #2093 is merged. .this is no longer needed. ---

[GitHub] activemq-artemis pull request #2100: Amending fixes from #2093

2018-05-23 Thread clebertsuconic
Github user clebertsuconic closed the pull request at: https://github.com/apache/activemq-artemis/pull/2100 ---

[GitHub] activemq-artemis pull request #2093: ARTEMIS-1872 Check for queue exists bef...

2018-05-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2093 ---

[GitHub] activemq-artemis pull request #2103: ARTEMIS-1872 Fixing some extra bits on ...

2018-05-23 Thread clebertsuconic
GitHub user clebertsuconic opened a pull request: https://github.com/apache/activemq-artemis/pull/2103 ARTEMIS-1872 Fixing some extra bits on AMQP + improving the test You can merge this pull request into a Git repository by running: $ git pull