[GitHub] activemq-artemis issue #2113: [ARTEMIS-1890] Any-word wildcard fix

2018-06-01 Thread mtaylor
Github user mtaylor commented on the issue: https://github.com/apache/activemq-artemis/pull/2113 I see it's already merged. This is an enhancement not a bug. But, +1 on the change and it landing in 2.7.0 there's a clear use case for it. I think the important thing here is

[GitHub] activemq-artemis pull request #2119: Artemis 1902

2018-06-01 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2119#discussion_r192514909 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/QueueInfo.java --- @@ -107,7 +108,11 @@ public

Re: Regular and intermittent interrupt/resume between broker and client connector

2018-06-01 Thread gerardl
Thanks Art. Some good feedback. The guaranteed delivery is important, so I'm going to need to implement an extension to support local storage of unsent messages so they can be redelivered when a resume has been detected. -- Sent from:

[GitHub] activemq-artemis issue #2118: STOMP work

2018-06-01 Thread jbertram
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/2118 Probably not. I'd leave it for 2.7.0. ---

[GitHub] activemq-artemis pull request #2118: STOMP work

2018-06-01 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/2118 STOMP work Work for ARTEMIS-1896 and ARTEMIS-1897. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis

[GitHub] activemq-artemis issue #2118: STOMP work

2018-06-01 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2118 @jbertram is this suitable for 2.6.x ---

[GitHub] activemq-artemis issue #2117: NO-JIRA update release instruction with git-re...

2018-06-01 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2117 @gemmellr you're a good person to review this :) ---

[GitHub] activemq-artemis pull request #2119: Artemis 1902

2018-06-01 Thread mtaylor
GitHub user mtaylor opened a pull request: https://github.com/apache/activemq-artemis/pull/2119 Artemis 1902 You can merge this pull request into a Git repository by running: $ git pull https://github.com/mtaylor/activemq-artemis ARTEMIS-1902 Alternatively you can review and

[GitHub] activemq-artemis issue #2117: NO-JIRA update release instruction with git-re...

2018-06-01 Thread gemmellr
Github user gemmellr commented on the issue: https://github.com/apache/activemq-artemis/pull/2117 Looks good. Minor nit that I prefer numbered list entries don't all have "1." as the deliminator since it makes the raw file more awkward to read, but I also don't care so much as to

[GitHub] activemq-artemis issue #2119: Artemis 1902

2018-06-01 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2119 @mtaylor I know I have in the past asked to separate test and fix.. but I went back on that.. as it's easier to cherry-pick.. and the gitreport would make a better correlation.

[GitHub] activemq-artemis pull request #2120: ARTEMIS-1892 allow whitespace in accept...

2018-06-01 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/2120 ARTEMIS-1892 allow whitespace in acceptor and connector URIs You can merge this pull request into a Git repository by running: $ git pull

[CANCEL]: [VOTE] Apache ActiveMQ Artemis 2.6.1

2018-06-01 Thread Clebert Suconic
Cancelling, For the reason I explained earlier. On Fri, Jun 1, 2018 at 1:31 PM, Clebert Suconic wrote: > Actually.. -1 > > > I will respin.. the main reason I pushed this release was for the AMQP > & Clustering issue, and the security issue raised by Michael. > It happens that there's still an

Re: [VOTE] Apache ActiveMQ Artemis 2.6.1

2018-06-01 Thread Clebert Suconic
Actually.. -1 I will respin.. the main reason I pushed this release was for the AMQP & Clustering issue, and the security issue raised by Michael. It happens that there's still an issue with AMQP & Clustering, and Martyn fixed it here: https://github.com/apache/activemq-artemis/pull/2119 I