[GitHub] activemq-artemis pull request #2237: [ARTEMIS-2022] Create count messages 'g...

2018-08-10 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2237#discussion_r209381661 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/QueueControlImpl.java --- @@ -711,6 +712,32

[GitHub] activemq-artemis issue #2235: Make JDBC OpenFile Thread Safe

2018-08-10 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2235 @mtaylor / @andytaylor no JIRA? ---

[GitHub] activemq-artemis pull request #2237: [ARTEMIS-2022] Create count messages 'g...

2018-08-10 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2237#discussion_r209312787 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/QueueControlImpl.java --- @@ -711,6 +712,32

[GitHub] activemq-artemis pull request #2237: [ARTEMIS-2022] Create count messages 'g...

2018-08-10 Thread ArthurFritz
Github user ArthurFritz commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2237#discussion_r209314996 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/QueueControlImpl.java --- @@ -711,6 +712,32 @@

[GitHub] activemq-artemis pull request #2237: [ARTEMIS-2022] Create count messages 'g...

2018-08-10 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2237#discussion_r209315364 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/QueueControlImpl.java --- @@ -711,6 +712,32

[GitHub] activemq-artemis pull request #2237: [ARTEMIS-2022] Create count messages 'g...

2018-08-10 Thread ArthurFritz
Github user ArthurFritz commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2237#discussion_r209317077 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/QueueControlImpl.java --- @@ -711,6 +712,32 @@

[GitHub] activemq-artemis pull request #2237: [ARTEMIS-2022] Create count messages 'g...

2018-08-10 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2237#discussion_r209317084 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/QueueControlImpl.java --- @@ -711,6 +712,32

[GitHub] activemq-artemis pull request #2237: [ARTEMIS-2022] Create count messages 'g...

2018-08-10 Thread ArthurFritz
Github user ArthurFritz commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2237#discussion_r209317397 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/QueueControlImpl.java --- @@ -711,6 +712,32 @@

[GitHub] activemq-artemis pull request #2237: [ARTEMIS-2022] Create count messages 'g...

2018-08-10 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2237#discussion_r209369043 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/QueueControlImpl.java --- @@ -711,6 +712,32

[GitHub] activemq-artemis issue #2237: [ARTEMIS-2022] Create count messages 'group by...

2018-08-10 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/2237 @ArthurFritz i sent your branch a PR with a number of improvements on this, see here: https://github.com/ArthurFritz/activemq-artemis/pull/1 ---

[GitHub] activemq-artemis pull request #2238: ARTEMIS-2023 Support 1x prefixes for JM...

2018-08-10 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/2238 ARTEMIS-2023 Support 1x prefixes for JMS dests created using session In some cases users who migrate from 1.x to 2.x may still want to keep the legacy prefixes for their JMS

[GitHub] activemq-artemis pull request #2237: [ARTEMIS-2022] Create count messages 'g...

2018-08-10 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2237#discussion_r209369424 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/QueueControlImpl.java --- @@ -711,6 +712,32

[GitHub] activemq-artemis pull request #2237: [ARTEMIS-2022] Create count messages 'g...

2018-08-10 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2237#discussion_r209373519 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/QueueControlImpl.java --- @@ -63,6 +63,7 @@

[GitHub] activemq-artemis pull request #2237: [ARTEMIS-2022] Create count messages 'g...

2018-08-10 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2237#discussion_r209375108 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/QueueControlImpl.java --- @@ -711,6 +712,32

[GitHub] activemq-artemis pull request #2237: [ARTEMIS-2022] Create count messages 'g...

2018-08-10 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2237#discussion_r209386511 --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/management/QueueControlTest.java --- @@

[GitHub] activemq-artemis pull request #2239: ARTEMIS-2022 Create count messages 'gro...

2018-08-10 Thread michaelandrepearce
GitHub user michaelandrepearce opened a pull request: https://github.com/apache/activemq-artemis/pull/2239 ARTEMIS-2022 Create count messages 'group by' this property filter Checking build You can merge this pull request into a Git repository by running: $ git pull

[GitHub] activemq-artemis pull request #2239: ARTEMIS-2022 Create count messages 'gro...

2018-08-10 Thread michaelandrepearce
Github user michaelandrepearce closed the pull request at: https://github.com/apache/activemq-artemis/pull/2239 ---

[GitHub] activemq-artemis pull request #2236: [ARTEMIS-2022] Create count messages 'g...

2018-08-10 Thread ArthurFritz
GitHub user ArthurFritz opened a pull request: https://github.com/apache/activemq-artemis/pull/2236 [ARTEMIS-2022] Create count messages 'group by' this property filter Create a new function this is responsibility count messages determined property filter, e return one object in

[GitHub] activemq-artemis pull request #2236: [ARTEMIS-2022] Create count messages 'g...

2018-08-10 Thread ArthurFritz
Github user ArthurFritz closed the pull request at: https://github.com/apache/activemq-artemis/pull/2236 ---

[GitHub] activemq-artemis issue #2236: [ARTEMIS-2022] Create count messages 'group by...

2018-08-10 Thread ArthurFritz
Github user ArthurFritz commented on the issue: https://github.com/apache/activemq-artemis/pull/2236 Alter destination feature. ---

[GitHub] activemq-artemis pull request #2237: [ARTEMIS-2022] Create count messages 'g...

2018-08-10 Thread ArthurFritz
GitHub user ArthurFritz opened a pull request: https://github.com/apache/activemq-artemis/pull/2237 [ARTEMIS-2022] Create count messages 'group by' this property filter Create a new function this is responsibility count messages determined property filter, e return one object in

[GitHub] activemq-artemis issue #2235: Make JDBC OpenFile Thread Safe

2018-08-10 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2235 I will push -f without this commit.. it should have had a JIRA ---

[ANNOUNCE] Apache ActiveMQ 5.15.5 Released

2018-08-10 Thread Christopher Shannon
Hi everyone, The ActiveMQ team is pleased to announce that Apache ActiveMQ 5.15.5 has been released. A list of issues resolved in this release is available here: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311210=12343307 The Wiki page for the release is here:

[GitHub] activemq-artemis issue #2237: [ARTEMIS-2022] Create count messages 'group by...

2018-08-10 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/2237 This should probably filter using the selectors logic, rather than some seperate logic, so the fiktering expectations are the same. ---

[GitHub] activemq-artemis pull request #2237: [ARTEMIS-2022] Create count messages 'g...

2018-08-10 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2237#discussion_r209312103 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/QueueControlImpl.java --- @@ -711,6 +712,32

Re: OpenWire Version 2 is not the latest version

2018-08-10 Thread Arthur Naseef
The openwire generator is executed by the activemq-client project when the " openwire-generate" build profile is enabled and the "antrun:run" goal is executed (according to the comments in the pom): mvn -P openwire-generate antrun:run This runs a complex script that appears to ultimately boil

[GitHub] activemq-artemis issue #2236: [ARTEMIS-2022] Create count messages 'group by...

2018-08-10 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2236 2.6.x is bug fixes only... this has to go on master. ---

[GitHub] activemq-artemis issue #2236: [ARTEMIS-2022] Create count messages 'group by...

2018-08-10 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2236 even if it was going on 2.6.x, we first send to master, than cherry-pick into 2.6.x ---

[GitHub] activemq-artemis issue #2235: Make JDBC OpenFile Thread Safe

2018-08-10 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2235 will leave it as it is. ---

[GitHub] activemq-artemis pull request #2237: [ARTEMIS-2022] Create count messages 'g...

2018-08-10 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2237#discussion_r209381476 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/QueueControlImpl.java --- @@ -711,6 +712,32

[GitHub] activemq-artemis issue #2199: ARTEMIS-1996 MappedSequentialFileFactory may c...

2018-08-10 Thread franz1981
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/2199 @michaelandrepearce good point! I will need to modify it because my solution do not create any ByteBuffer at all (or will dispose it immediately with Asyncio) and the test proposed

[GitHub] activemq-artemis issue #2199: ARTEMIS-1996 MappedSequentialFileFactory may c...

2018-08-10 Thread franz1981
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/2199 @clebertsuconic I think that using a near-to-deprecation feature to solve the issue can be avoided: https://github.com/franz1981/activemq-artemis/tree/mmap_ro_2_read_journal It is a

[GitHub] activemq-artemis issue #2199: ARTEMIS-1996 MappedSequentialFileFactory may c...

2018-08-10 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/2199 @franz1981 , @morefuntang provided a testcase to reproduce the issue, i note on your branch you havent copied the test, to prove your alternative change also would fix the

[GitHub] activemq-artemis issue #2232: ARTEMIS-1482 Enhance test to ensure len check ...

2018-08-10 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2232 It’s already on 2.6.x ---

[GitHub] activemq-artemis pull request #2235: Make JDBC OpenFile Thread Safe

2018-08-10 Thread mtaylor
GitHub user mtaylor opened a pull request: https://github.com/apache/activemq-artemis/pull/2235 Make JDBC OpenFile Thread Safe You can merge this pull request into a Git repository by running: $ git pull https://github.com/mtaylor/activemq-artemis OpenFileSync Alternatively

[GitHub] activemq-artemis issue #2232: ARTEMIS-1482 Enhance test to ensure len check ...

2018-08-10 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/2232 So we have no idea of the cause, it is a consumer so we think its a producer where producee maybe on older version. It happend 4 times since monday our app team said ---

[GitHub] activemq-artemis pull request #2235: Make JDBC OpenFile Thread Safe

2018-08-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2235 ---

[GitHub] activemq-artemis issue #2232: ARTEMIS-1482 Enhance test to ensure len check ...

2018-08-10 Thread mtaylor
Github user mtaylor commented on the issue: https://github.com/apache/activemq-artemis/pull/2232 @michaelandrepearce How did they do this? It's really only legitimate if the SimpleString is encoded incorrectly? i.e. Set the first 4 bytes as something like Integer.MAX. Other checks

[GitHub] activemq-artemis issue #2232: ARTEMIS-1482 Enhance test to ensure len check ...

2018-08-10 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/2232 @mtaylor i giggle, its like there are forces out there that just know, literally came into work today, and one of our app teams just experienced this issue this morning...

[GitHub] activemq-artemis issue #2232: ARTEMIS-1482 Enhance test to ensure len check ...

2018-08-10 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/2232 @clebertsuconic can this be ported to the 2.6.x branch? ---

Re: HEADS-UP ActiveMQ Artemis 2.6.3 to be cut Friday the 10th

2018-08-10 Thread Clebert Suconic
I will have to postpone to Monday... I have started working on a compatibility issue between 1.5 and 2.x that I want to make sure before we release. Meanwhile: I have cut a master git report, where I added a XREF of commits on 2.6.x this is a current list I just cut of master versus 2.6.x,