[GitHub] activemq-artemis issue #2392: ARTEMIS-2100 address routing-type overridden o...

2018-10-24 Thread franz1981
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/2392 @jbertram I need to run the whole test suite on this first, but feel free to review it given that you're the last one that has worked near this same code :+1: ---

[GitHub] activemq-artemis pull request #2392: ARTEMIS-2100 address routing-type overr...

2018-10-24 Thread franz1981
GitHub user franz1981 opened a pull request: https://github.com/apache/activemq-artemis/pull/2392 ARTEMIS-2100 address routing-type overridden on attaching AMQP sender AMQPSender has to honor an already existing routingType of an address while attempting to create a fresh new

[GitHub] activemq-artemis issue #2384: ARTEMIS-2141 Add Filter column to Consumers Vi...

2018-10-24 Thread sebthom
Github user sebthom commented on the issue: https://github.com/apache/activemq-artemis/pull/2384 @michaelandrepearce I updated the ConsumerFilterPredicate too now and also changed the filter related implementation of the getField() method in ConsumerView according to QueueView. ---

[GitHub] activemq-artemis pull request #2393: ARTEMIS-2146 Avoiding NPE on AMQP Flow ...

2018-10-24 Thread clebertsuconic
GitHub user clebertsuconic opened a pull request: https://github.com/apache/activemq-artemis/pull/2393 ARTEMIS-2146 Avoiding NPE on AMQP Flow Control AMQP Flow control will disable consumer flow control (setting credits to null) This will avoid a race checking flow control.

[GitHub] activemq-artemis issue #1733: [DO NOT MERGE] ARTEMIS-1545 Support JMS 2.0 Co...

2018-10-24 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1733 Closing as merged by another PR ---

[GitHub] activemq-artemis pull request #1733: [DO NOT MERGE] ARTEMIS-1545 Support JMS...

2018-10-24 Thread michaelandrepearce
Github user michaelandrepearce closed the pull request at: https://github.com/apache/activemq-artemis/pull/1733 ---

[VOTE] Apache ActiveMQ 5.15.7

2018-10-24 Thread Christopher Shannon
Hi Everyone, I have created the 5.15.7 release and it is ready for a vote. The list of resolved issues is here: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311210=12344049 You can get the release artifacts here:

Re: [VOTE] Apache ActiveMQ 5.15.7

2018-10-24 Thread jgenender
+1 Jeff -- Sent from: http://activemq.2283324.n4.nabble.com/ActiveMQ-Dev-f2368404.html

Re: [VOTE] Apache ActiveMQ 5.15.7

2018-10-24 Thread Francois Papon
+1 (non-binding) Thanks! regards, François Papon fpa...@apache.org Le 24/10/2018 à 18:41, Christopher Shannon a écrit : > Hi Everyone, > > I have created the 5.15.7 release and it is ready for a vote. > > The list of resolved issues is here: >

[GitHub] activemq-artemis issue #2379: NO-JIRA Minor edit in HA doc

2018-10-24 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/2379 Thanks for the contribution. ---

[GitHub] activemq-artemis pull request #2379: NO-JIRA Minor edit in HA doc

2018-10-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2379 ---

Re: [VOTE] Apache ActiveMQ 5.15.7

2018-10-24 Thread Daniel Kulp
+1 Dan > On Oct 24, 2018, at 10:41 AM, Christopher Shannon > wrote: > > Hi Everyone, > > I have created the 5.15.7 release and it is ready for a vote. > > The list of resolved issues is here: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311210=12344049 > > You can

[GitHub] activemq-artemis pull request #2393: ARTEMIS-2146 Avoiding NPE on AMQP Flow ...

2018-10-24 Thread franz1981
Github user franz1981 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2393#discussion_r227822843 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ServerConsumerImpl.java --- @@ -349,7 +349,9 @@ public

[GitHub] activemq-artemis pull request #2393: ARTEMIS-2146 Avoiding NPE on AMQP Flow ...

2018-10-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2393 ---

Re: [VOTE] Apache ActiveMQ 5.15.7

2018-10-24 Thread Arthur Naseef
+1 Thank you. On Wed, Oct 24, 2018 at 9:45 AM Daniel Kulp wrote: > +1 > > Dan > > > > On Oct 24, 2018, at 10:41 AM, Christopher Shannon < > christopher.l.shan...@gmail.com> wrote: > > > > Hi Everyone, > > > > I have created the 5.15.7 release and it is ready for a vote. > > > > The list of

Re: [VOTE] Apache ActiveMQ 5.15.7

2018-10-24 Thread alan protasio
+1 :D Att.. Alan Diego On Wed, Oct 24, 2018 at 9:55 AM Arthur Naseef wrote: > +1 > > Thank you. > > On Wed, Oct 24, 2018 at 9:45 AM Daniel Kulp wrote: > > > +1 > > > > Dan > > > > > > > On Oct 24, 2018, at 10:41 AM, Christopher Shannon < > > christopher.l.shan...@gmail.com> wrote: > > > > > >

[GitHub] activemq-artemis issue #2392: ARTEMIS-2100 address routing-type overridden o...

2018-10-24 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/2392 @franz1981, i dont follow this, its seems to break some of the flexibility, e.g. if the sender sends to address as multicast then a multicast queue should be created if no

Re: activemq.password : can not change PW für System user

2018-10-24 Thread jgoodyear
Hi Gregor, Are you attempting to browse via the WebConsole or JMX client? Which file(s) are you editing? Cheers, Jamie -- Sent from: http://activemq.2283324.n4.nabble.com/ActiveMQ-Dev-f2368404.html

Re: [VOTE] Apache ActiveMQ 5.15.7

2018-10-24 Thread trevdyck
+1 -- Sent from: http://activemq.2283324.n4.nabble.com/ActiveMQ-Dev-f2368404.html

[GitHub] activemq-artemis issue #2369: ARTEMIS-2123 Paging not stopped if there are n...

2018-10-24 Thread wy96f
Github user wy96f commented on the issue: https://github.com/apache/activemq-artemis/pull/2369 @clebertsuconic @franz1981 Hi, this bug occurred in our production environment yesterday. Our topic has one subscription without messages at the moment. Though the consumers subscribed to

Re: [VOTE] Apache ActiveMQ 5.15.7

2018-10-24 Thread trevdyck
+1 -- Sent from: http://activemq.2283324.n4.nabble.com/ActiveMQ-Dev-f2368404.html

Re: [VOTE] Apache ActiveMQ 5.15.7

2018-10-24 Thread Jean-Baptiste Onofré
+1 Thanks ! Regards JB On 24/10/2018 16:41, Christopher Shannon wrote: > Hi Everyone, > > I have created the 5.15.7 release and it is ready for a vote. > > The list of resolved issues is here: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311210=12344049 > > You can

[GitHub] activemq-artemis pull request #2388: ARTEMIS-1856 support delays before dele...

2018-10-24 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2388#discussion_r227665143 --- Diff: artemis-server/src/main/resources/schema/artemis-configuration.xsd --- @@ -336,6 +336,14 @@

[GitHub] activemq-artemis pull request #2388: ARTEMIS-1856 support delays before dele...

2018-10-24 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2388#discussion_r227665421 --- Diff: artemis-server/src/main/resources/schema/artemis-configuration.xsd --- @@ -2953,6 +2961,15 @@

[GitHub] activemq-artemis issue #2388: ARTEMIS-1856 support delays before deleting ad...

2018-10-24 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/2388 @jbertram went to merge this morning and during the process and noticed something, have added comment inline ---

[GitHub] activemq-artemis issue #2376: [ARTEMIS-2130]Web console display blank Client...

2018-10-24 Thread shailendra14k
Github user shailendra14k commented on the issue: https://github.com/apache/activemq-artemis/pull/2376 @michaelandrepearce @jbertram Thank you for the review. Yes, session and consumer models need to be re-worked and should have a generic method to get/set client_id accros the

[GitHub] activemq-artemis pull request #2376: [ARTEMIS-2130]Web console display blank...

2018-10-24 Thread shailendra14k
Github user shailendra14k closed the pull request at: https://github.com/apache/activemq-artemis/pull/2376 ---