Github user mtaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/2392
> If the queue and topic with the same name/address were independent, then
clients explicitly selecting one or the other would not see each others
messages. Messages from a sender with
GitHub user feuillemorte opened a pull request:
https://github.com/apache/activemq-artemis/pull/2397
ARTEMIS-2116 Extend tests on producer CLI command with message body
Added tests on producer cli command
Cases:
* Produce 10 messages with default message body
*
Github user grs commented on the issue:
https://github.com/apache/activemq-artemis/pull/2392
Yes, I am sure iof all these points.
---
Github user grs commented on the issue:
https://github.com/apache/activemq-artemis/pull/2392
If the queue and topic with the same name/address were independent, then
clients explicitly selecting one or the other would not see each others
messages. Messages from a sender with
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2399
@ArthurFritz LGTM, thanks for fixing up the commit message. Just waiting on
PR build if good ill look to merge. Thanks for the contribution.
---
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2398#discussion_r228623226
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/QueueControlImpl.java
---
@@ -740,6 +733,56
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2388
---
GitHub user ArthurFritz opened a pull request:
https://github.com/apache/activemq-artemis/pull/2399
ARTEMIS-2150 Counts the number of delivering messages in this queue
Create function this counts the number of delivering messages in this queue
matching the specified filter.
Github user ArthurFritz closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2398
---
Github user ArthurFritz commented on the issue:
https://github.com/apache/activemq-artemis/pull/2398
Okay, i created new Merge Request, adjusted commit message :smiley:
---
GitHub user ArthurFritz opened a pull request:
https://github.com/apache/activemq-artemis/pull/2398
[ARTEMIS-2150] Counts the number of delivering messages in this queue
Create function this counts the number of delivering messages in this queue
matching the specified filter.
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2398#discussion_r228619277
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/QueueControlImpl.java
---
@@ -740,6 +733,56
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2388
@jbertram it wasn't a biggie, i guess more important things are a foot, so
merging. And can always add the extra config to the other as and when needed in
future.
---
Github user ArthurFritz commented on the issue:
https://github.com/apache/activemq-artemis/pull/2399
@michaelandrepearce Nice, Tks
---
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2398
@ArthurFritz LGTM (when build passes for checkstyle etc etc) could you
merge the commits? Also could you tidy the commit message to be in the form:
"ARTEMIS- You
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2399
---
+1
Bruce
On Tue, Oct 23, 2018 at 2:26 PM Clebert Suconic
wrote:
> What about this. WE could :
>
> - commit this on git
> - upload a snapshot for review under our web-site.
> On Mon, Oct 22, 2018 at 8:46 AM Clebert Suconic
> wrote:
> >
> > +1000. We had that options discussed here a few times.
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2396
Another thing ive noticed is currently where validBuffer is changed its not
protected its only volatile, so you could enter syncronized method do the
validBuffer check, but
Github user grs commented on the issue:
https://github.com/apache/activemq-artemis/pull/2392
I am talking only about the AMQP support. It is inconsistent. It does not
as you say 'honour the sender'. It effectively forces the behaviour of anycast
on all subsequent clients, unless
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2392
Disagree AMQP is just a protocol. A broker is just another client. There is
nothing to say an address cannot be both anycast and multicast.
And as such if you have
Github user mtaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/2392
There are two things at play here. AMQP raw protocol and extensions to
AMQP that are broker specific.
With AMQP raw, there is no such thing as a routing type (this is a broker
Github user grs commented on the issue:
https://github.com/apache/activemq-artemis/pull/2392
> With AMQP raw, there is no such thing as a routing type (this is a broker
concept). Therefore messages sent via AMQP to an address should be routed to
any routing type currently configured
Github user mtaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/2392
> > With AMQP raw, there is no such thing as a routing type (this is a
broker concept). Therefore messages sent via AMQP to an address should be
routed to any routing type currently
23 matches
Mail list logo
