[GitHub] activemq-artemis issue #2401: ARTEMIS-1710 Allow management msgs to pass the...

Github user lulf commented on the issue: https://github.com/apache/activemq-artemis/pull/2401 As a user, I think the first alternative is the clearest, it explicitly states the intention and does not change any existing behavior (i.e. auto tune -1 which we already rely on). In our

[GitHub] activemq-artemis pull request #2405: ARTEMIS-2158 don't get pagedMessage if ...

Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2405 ---

Re: [GitHub] activemq-artemis issue #2401: ARTEMIS-1710 Allow management msgs to pass the...

That is a sagaciously composed article and this is actually what I was searching for. Great motivational counsel, and more info just as exactly what I require. I altogether making the most of your top to bottom audit and have

[GitHub] activemq-artemis issue #2401: ARTEMIS-1710 Allow management msgs to pass the...

Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/2401 @clebertsuconic I have added some additional unit tests on `PagingStoreImpl` ---

[GitHub] activemq-artemis pull request #2400: ARTEMIS-2151 JMS Selectors broken in so...

Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2400 ---

[GitHub] activemq-artemis pull request #:

Github user orpiske commented on the pull request: https://github.com/apache/activemq-artemis/commit/9490e745c5431e681c768e6fdd20ed5dda0b7b95#commitcomment-31119234 @andytaylor I didn't know about that one! I think that might do the trick. We'll try and I'll close if it solves the

[GitHub] activemq-artemis issue #2401: ARTEMIS-1710 Allow management msgs to pass the...

Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/2401 @clebertsuconic I'm fixing a couple of things on this one too ---

[GitHub] activemq-artemis issue #2406: New profile to allow skipping or including the...

Github user orpiske commented on the issue: https://github.com/apache/activemq-artemis/pull/2406 > how to run a single test: > > ``` > mvn -Ptests -DfailIfNoTests=false -Pextra-tests -DskipStyleCheck=true -DskipPerformanceTests=false -Dtest=$1 test > ``` > >

[GitHub] activemq-artemis pull request #2406: New profile to allow skipping or includ...

Github user orpiske closed the pull request at: https://github.com/apache/activemq-artemis/pull/2406 ---

[GitHub] activemq-artemis issue #2406: New profile to allow skipping or including the...

Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2406 how to run a single test: ``` mvn -Ptests -DfailIfNoTests=false -Pextra-tests -DskipStyleCheck=true -DskipPerformanceTests=false -Dtest=$1 test ```

[GitHub] activemq-artemis pull request #:

Github user andytaylor commented on the pull request: https://github.com/apache/activemq-artemis/commit/9490e745c5431e681c768e6fdd20ed5dda0b7b95#commitcomment-31119169 Im not sure this is needed, you can do -DskipIntegrationTests=true ---

[GitHub] activemq-artemis issue #2406: New profile to allow skipping or including the...

Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2406 There is a script. One-test.sh. Or you can run the test in an ide. ---

[GitHub] activemq-artemis pull request #2404: ARTEMIS-2157 Extra information on Criti...

Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2404 ---

[GitHub] activemq-artemis pull request #2407: openWire would allow one extra send

GitHub user clebertsuconic opened a pull request: https://github.com/apache/activemq-artemis/pull/2407 openWire would allow one extra send You can merge this pull request into a Git repository by running: $ git pull https://github.com/clebertsuconic/activemq-artemis

[GitHub] activemq-artemis issue #2407: openWire would allow one extra send

Github user orpiske commented on the issue: https://github.com/apache/activemq-artemis/pull/2407 Looking at the test, I think it correctly reproduces the problem we were seeing. Thanks for the quick fix! ---

[GitHub] activemq-artemis issue #2406: New profile to allow skipping or including the...

Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2406 This is not needed at all. can you close it? ---

[GitHub] activemq-artemis issue #2406: New profile to allow skipping or including the...

Github user orpiske commented on the issue: https://github.com/apache/activemq-artemis/pull/2406 We have tried the proposed approach and it did not skip the integration tests. We received a suggestion from @andytaylor to use "-PDev" in addition to that. Any solution that does not

[GitHub] activemq-artemis issue #2401: ARTEMIS-1710 Allow management msgs to pass the...

Github user mtaylor commented on the issue: https://github.com/apache/activemq-artemis/pull/2401 I don't really like the idea of the double threshold. I think the global-max-size limit should be the catch all case. What would work better here is an accumulative-max-size

[GitHub] activemq-artemis issue #2401: ARTEMIS-1710 Allow management msgs to pass the...

Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/2401 This would work and i like the flexibility. I assume here in this option proposed. Global would remain as is today. ---

[GitHub] activemq-artemis issue #2401: ARTEMIS-1710 Allow management msgs to pass the...

Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/2401 @mtaylor @michaelandrepearce I can't ignore all these useful comments/feedbacks guys so I will work more on this one to see if it can be done in a better way; thanks for the reviews

[GitHub] activemq-artemis pull request #2407: openWire would allow one extra send

Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2407 ---

[GitHub] activemq-artemis issue #2401: ARTEMIS-1710 Allow management msgs to pass the...

Github user mtaylor commented on the issue: https://github.com/apache/activemq-artemis/pull/2401 > This would work and i like the flexibility. I assume here in this option proposed. Global would remain as is today. Yes. ---

[GitHub] activemq-artemis issue #2401: ARTEMIS-1710 Allow management msgs to pass the...

Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/2401 @michaelandrepearce @lulf @mtaylor I will continue on the issue comments :+1: ---

[GitHub] activemq-artemis pull request #2408: ARTEMIS-2160: Addressed occurance where...

GitHub user RoddieKieley opened a pull request: https://github.com/apache/activemq-artemis/pull/2408 ARTEMIS-2160: Addressed occurance where cluster configuration on serv… …er locator was hard coded. Covered with test. You can merge this pull request into a Git repository by

[GitHub] activemq-artemis pull request #2401: ARTEMIS-1710 Allow management msgs to p...

Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2401#discussion_r229835269 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/config/Configuration.java --- @@ -493,6 +493,17 @@ Configuration

[GitHub] activemq-artemis issue #2401: ARTEMIS-1710 Allow management msgs to pass the...

Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2401 @franz1981 Did you mean exceed global-max-size? when I read this originally I had the impression you were setting global-max-size using management messages. I'm

[GitHub] activemq-artemis issue #2401: ARTEMIS-1710 Allow management msgs to pass the...

Github user lulf commented on the issue: https://github.com/apache/activemq-artemis/pull/2401 The use case is covered in https://issues.apache.org/jira/browse/ARTEMIS-1710 In a cloud-setting, we need to: a) Have the broker derive (global) limits based on things like

[GitHub] activemq-artemis issue #2401: ARTEMIS-1710 Allow management msgs to pass the...

Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/2401 @clebert I will try to connect later in order to understand what you mean mate (ATM I'm on the phone) ---

[GitHub] activemq-artemis issue #2401: ARTEMIS-1710 Allow management msgs to pass the...

Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/2401 FWIW, management can be done through JMX or REST (via Jolokia) if management messages are blocked for any reason. ---

[GitHub] activemq-artemis issue #2401: ARTEMIS-1710 Allow management msgs to pass the...

Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2401 @lulf / @franz1981 ok, Why not make a simpler change.. and return -1 on PaginManager if the management address. That's a lot less code to get around the sizing.

[GitHub] activemq-artemis pull request #2369: ARTEMIS-2123 Paging not stopped if ther...

Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2369 ---

[GitHub] activemq-artemis pull request #2401: ARTEMIS-1710 Allow management msgs to p...

Github user franz1981 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2401#discussion_r229845531 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/config/Configuration.java --- @@ -493,6 +493,17 @@ Configuration

[GitHub] activemq-artemis issue #2400: ARTEMIS-2151 JMS Selectors broken in some case...

Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/2400 For openwire JMSPriority, JMSCorrelationID etc etc were all broken. ---

[GitHub] activemq-artemis issue #2401: ARTEMIS-1710 Allow management msgs to pass the...

Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/2401 @clebertsuconic Let me run it while I'm working on an alternative version too: we can talk later about it mate? ---

[GitHub] activemq-artemis pull request #2401: ARTEMIS-1710 Allow management msgs to p...

Github user franz1981 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2401#discussion_r229640945 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/PagingManagerImpl.java --- @@ -437,12 +449,27 @@ public

[GitHub] activemq-artemis pull request #2406: New profile to allow skipping or includ...

GitHub user orpiske opened a pull request: https://github.com/apache/activemq-artemis/pull/2406 New profile to allow skipping or including the execution of integration tests This comes as request from our team. They would like to be able to skip and/or include the execution of the

[GitHub] activemq-artemis issue #2401: ARTEMIS-1710 Allow management msgs to pass the...

Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/2401 @michaelandrepearce I've started working on the alternative one based on a second level global limit, but TBH I've already found quite complex to add such condition without breaking any