[GitHub] activemq-artemis issue #2401: ARTEMIS-1710 Allow management msgs to pass the...

2018-11-01 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/2401 @lulf if i understand @mtaylor proposal it would be that you could set address setting match to # meaning anything and set aggegate-size to the max size you want for all normal

[GitHub] activemq-artemis issue #2401: ARTEMIS-1710 Allow management msgs to pass the...

2018-11-01 Thread lulf
Github user lulf commented on the issue: https://github.com/apache/activemq-artemis/pull/2401 @michaelandrepearce @mtaylor Ok, just to make sure I understand this, what we have today: ``` -1 ``` would be equivalent to: ``` # -1 ``` Which

[GitHub] activemq-artemis issue #2401: ARTEMIS-1710 Allow management msgs to pass the...

2018-11-01 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/2401 @clebertsuconic the change you propose would mean still management addresses would NOT be under the global max catch all, as it is today. Which is my initial concern and my

[GitHub] activemq-artemis issue #2401: ARTEMIS-1710 Allow management msgs to pass the...

2018-11-01 Thread lulf
Github user lulf commented on the issue: https://github.com/apache/activemq-artemis/pull/2401 @mtaylor I agree, having percentages is better, and will work for our use case. ---

[GitHub] activemq-artemis issue #2401: ARTEMIS-1710 Allow management msgs to pass the...

2018-11-01 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/2401 I would suggest for address settings -1 isnt used (as for other settings it typically means disable also for your above mentioned it could not be very flexible) but some

[GitHub] activemq-artemis issue #2401: ARTEMIS-1710 Allow management msgs to pass the...

2018-11-01 Thread mtaylor
Github user mtaylor commented on the issue: https://github.com/apache/activemq-artemis/pull/2401 > @michaelandrepearce @mtaylor Ok, just to make sure I understand this, what we have today: > > ``` > -1 > ``` > would be equivalent to: > > ``` > # >

[GitHub] activemq-artemis issue #2401: ARTEMIS-1710 Allow management msgs to pass the...

2018-11-01 Thread franz1981
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/2401 @lulf @michaelandrepearce I was looking to implement it as: ```xml 30 ``` Per address-settings to allow all the addresses matching it to share a 30% of the configured

[GitHub] activemq-artemis issue #2401: ARTEMIS-1710 Allow management msgs to pass the...

2018-11-01 Thread mtaylor
Github user mtaylor commented on the issue: https://github.com/apache/activemq-artemis/pull/2401 > @mtaylor I agree, having percentages is better, and will work for our use case. Great. It took me 5 minutes to write that reply and 15 minutes trying to get the formatting

[GitHub] activemq-artemis issue #2385: ARTEMIS-1929 race in STOMP identical durable s...

2018-11-01 Thread gaohoward
Github user gaohoward commented on the issue: https://github.com/apache/activemq-artemis/pull/2385 I think it's good. ---

[GitHub] activemq-artemis pull request #2409: ARTEMIS-2159 Fixing OpenWire Blocker Pr...

2018-11-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2409 ---

[GitHub] activemq-artemis pull request #2409: ARTEMIS-2159 Fixing OpenWire Blocker Pr...

2018-11-01 Thread clebertsuconic
GitHub user clebertsuconic opened a pull request: https://github.com/apache/activemq-artemis/pull/2409 ARTEMIS-2159 Fixing OpenWire Blocker Producer Previous change on Flow control in OpenWire broke Blocked cases This is a better fix. You can merge this pull request into a Git

[GitHub] activemq pull request #314: Fix missing trace argument

2018-11-01 Thread ecki
GitHub user ecki opened a pull request: https://github.com/apache/activemq/pull/314 Fix missing trace argument LGTM.com found this mismatch between format and arguments. Lets also make sure the array is printable. Source:

[GitHub] activemq-artemis pull request #2397: ARTEMIS-2116 Extend tests on producer C...

2018-11-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2397 ---