[GitHub] activemq-artemis pull request #2181: ARTEMIS-1980 Warn on failed check of ta...

2018-11-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2181 ---

[GitHub] activemq-artemis issue #2401: ARTEMIS-1710 Allow management msgs to exceed g...

2018-11-02 Thread franz1981
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/2401 I'm considering the proposal of @clebertsuconic to allow management messages to avoid paging AN`D `global-max-size` too, considering that they won't queue up and they are necessary to

[GitHub] activemq-artemis issue #2410: ARTEMIS-2125 Tabs preference changes to displa...

2018-11-02 Thread feuillemorte
Github user feuillemorte commented on the issue: https://github.com/apache/activemq-artemis/pull/2410 @tadayosi could you review it please? ---

[GitHub] activemq-artemis pull request #2411: ARTEMIS-2162 Remove -XX:+AggressiveOpts...

2018-11-02 Thread franz1981
GitHub user franz1981 opened a pull request: https://github.com/apache/activemq-artemis/pull/2411 ARTEMIS-2162 Remove -XX:+AggressiveOpts to improve JDK 11 compatibility You can merge this pull request into a Git repository by running: $ git pull

[GitHub] activemq-artemis pull request #2410: ARTEMIS-2125 Tabs preference changes to...

2018-11-02 Thread feuillemorte
GitHub user feuillemorte opened a pull request: https://github.com/apache/activemq-artemis/pull/2410 ARTEMIS-2125 Tabs preference changes to display columns not persistent through page refresh Fix based on https://github.com/apache/activemq-artemis/pull/2373 Not all

[GitHub] activemq-artemis issue #2181: ARTEMIS-1980 Warn on failed check of table exi...

2018-11-02 Thread franz1981
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/2181 @clebertsuconic @jbertram Guys if is good is possible to merge it? :+1: ---

[GitHub] activemq-artemis issue #2401: ARTEMIS-1710 Allow management msgs to exceed g...

2018-11-02 Thread mtaylor
Github user mtaylor commented on the issue: https://github.com/apache/activemq-artemis/pull/2401 @clebertsuconic I was thinking at this at a more general higher level, but given that management methods are as you say, never queued, then they don't take up storage. So, yes let's just

[GitHub] activemq-artemis pull request #2412: DO NOT MERGE

2018-11-02 Thread michaelandrepearce
GitHub user michaelandrepearce opened a pull request: https://github.com/apache/activemq-artemis/pull/2412 DO NOT MERGE You can merge this pull request into a Git repository by running: $ git pull https://github.com/michaelandrepearce/activemq-artemis SingleIterator

[GitHub] activemq-artemis pull request #2408: ARTEMIS-2160: Addressed occurance where...

2018-11-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2408 ---

[GitHub] activemq-artemis issue #2412: DO NOT MERGE

2018-11-02 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/2412 Me playing ;) dont merge ---

[GitHub] activemq-artemis issue #2401: ARTEMIS-1710 Allow management msgs to exceed g...

2018-11-02 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/2401 If thats the case, then great its just like invoking a method but just via core protocol. The bit im now a little confused by then is why in @franz1981 pr is it having to

[GitHub] activemq-artemis issue #2401: ARTEMIS-1710 Allow management msgs to exceed g...

2018-11-02 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2401 @franz1981 / @michaelandrepearce : Management messages exist to manage the broker. they are passed right into QueueController and are not queued. Hence they should not be

[GitHub] activemq-artemis issue #2401: ARTEMIS-1710 Allow management msgs to exceed g...

2018-11-02 Thread franz1981
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/2401 @clebertsuconic I will open a new PR in the weekend fixing it in the suggested way :+1: ---

[GitHub] activemq-artemis pull request #2413: NO-JIRA fixing tests

2018-11-02 Thread clebertsuconic
GitHub user clebertsuconic opened a pull request: https://github.com/apache/activemq-artemis/pull/2413 NO-JIRA fixing tests You can merge this pull request into a Git repository by running: $ git pull https://github.com/clebertsuconic/activemq-artemis fixTest Alternatively

[GitHub] activemq-artemis issue #2401: ARTEMIS-1710 Allow management msgs to exceed g...

2018-11-02 Thread franz1981
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/2401 @michaelandrepearce that's a good point: indeed I will work on a different solution (much easier) trying to not involve at all any PageStore/PageSubscription with management addresses.

[GitHub] activemq-artemis issue #2412: DO NOT MERGE

2018-11-02 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2412 What is this? :) ---