GitHub user cshannon opened a pull request:
https://github.com/apache/activemq-artemis/pull/2191
ARTEMIS-1987 - Add consumer window size to AddressSettings
Support configuring a default consumer window size via AddressSettings
which will allow sensible defaults to be used by
Github user cshannon commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2191#discussion_r204819939
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/ActiveMQSessionContext.java
---
@@ -822,6
Github user cshannon commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2191#discussion_r204819904
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ServerLocatorImpl.java
---
@@ -347,7 +347,7 @@ private
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/2191
@clebertsuconic - My use case is for the "service provider" case where the
administrators want to protect a shared resource broker that services many
different customers and
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/2191
@clebertsuconic and @michaelandrepearce - PR has been updated
---
Github user cshannon commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2191#discussion_r204867293
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/SessionQueueQueryResponseMessage_V4.java
Github user cshannon commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2191#discussion_r204867142
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/SessionQueueQueryResponseMessage_V4.java
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/2191
Ok latest changes have been pushed which includes removing the new version
and using a nullable integer instead
---
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/2191
@clebertsuconic - Is this ok to merge?
---
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/2191
I had to add a setting to one of the tests so hopefully that fixes it, will
find out in a few minutes
---
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/2191
I don't know what the latest test failure is but the tests pass on my
machine. The travis CI build seems to be pretty inconsistent with random
failures.
---
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/2191
@clebertsuconic and @michaelandrepearce - i rebased against master and it
looks like the tests all pass so this should be good to merge
---
GitHub user cshannon opened a pull request:
https://github.com/apache/activemq-artemis/pull/2206
ARTEMIS-2003 - Add bridge metrics
This commit adds support for tracking metrics for bridges for both
normal bridges and bridges that are part of a cluster. The two
statistics
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/2206
I don't think that change can be made. The metrics for the dequeue case on
the send acknowledge in this case can be updated in another runnable (new
thread)
Also, hones
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/2206
@franz1981 - makes sense with the API hints if that change is done in other
cases to make it known to developers the semantics...in this case i think we
are good as no change should be
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/2206
@jbertram - renaming the metrics is no problem, I had just used what 5.x
had called them but it's fine to rename them for consistency with other
existing metrics
I added th
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/2206
@jbertram - patch updated...not sure why CI keeps failing but the tests
pass on my machine
---
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/2206
Done, test is running now
---
GitHub user cshannon opened a pull request:
https://github.com/apache/activemq-artemis/pull/2229
ARTEMIS-2018 - Add bridge events to plugin API
Add callbacks to handle bridge events including beforeDeliverBridge,
afterDeliverBridge and afterAcknowledgeBridge
You can merge this
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/2229
I like the idea of using separate interfaces and having
ActiveMQServerPlugin extend them. This way if someone doesn't care they can
make it easy and just extend ActiveMQServerPlugi
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/2231
Looks good to me
---
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/2258
Adding exception callbacks seems good to me, one thing I noticed is a lot
of white space changes. My guess is your IDE is set to use tabs instead of
spaces so I would fix that before
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/2258
@calohmn - ah ok, yeah that makes sense I didn't look closely enough so if
it's spaces then all should be good
---
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/2262
@michaelandrepearce - Do you have an actual use case or example where it's
not reliable? The new metric gets used for size stuff as well so I don't think
it should be c
GitHub user cshannon opened a pull request:
https://github.com/apache/activemq-artemis/pull/2267
ARTEMIS-2052 - QueueQuery should use address name for address settings
The name used for looking up address settings for a queue now uses the
address name if there is a local queue
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/2278
It looks like one of tests I added in ConsumerWindowSizeTest
brokertestConsumerWindowSizeAddressSettingsDifferentAddressAndQueueName
---
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/2278
The issue is here:
https://github.com/apache/activemq-artemis/blob/106e71bdf4f1cf7ddf0dfc37ce6bab76d5c00dad/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/2278
@clebertsuconic - besides the test fix it looks good to me, thanks for
fixing it
---
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/2191
This is only available for version 2.7.0 which has not been released yet.
There is documentation available for it as well that will be released with it
---
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/2191
Yes you need the latest client as well. This feature works by retrieving
the value from the server as part of a query on connect. The old client doesn't
know to read the de
GitHub user cshannon opened a pull request:
https://github.com/apache/activemq-artemis/pull/2402
NO-JIRA: Clarify journal-buffer-timeout documentation
Clarify how to disable the buffer timeout. On one of my test brokers I
disabled journal-sync-transactional and journal-sync-non
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/2402
I know, either way, this is just to update the documentation to say that 0
will disable the timed buffer
---
GitHub user cshannon opened a pull request:
https://github.com/apache/activemq/pull/68
AMQ-5649: Fixed max producers per connection for anonymous producers
Modified TransportConnection so that maximumProducersAllowedPerConnection
will be enforced even for anonymous producers
GitHub user cshannon opened a pull request:
https://github.com/apache/activemq/pull/84
Modified StoreQueueCursor to prevent a broker deadlock
Modified StoreQueueCursor to properly implement tryAddMessageLast so that
the message lock can be released during a timeout when the
Github user cshannon closed the pull request at:
https://github.com/apache/activemq/pull/68
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user cshannon opened a pull request:
https://github.com/apache/activemq/pull/86
Updated durable related error messages in TopicRegion
Updated durable related error messages in TopicRegion to include both
subscriptionName and clientId.
This resolves https
GitHub user cshannon opened a pull request:
https://github.com/apache/activemq/pull/92
Added a getMessageSize method to MessageStore
Added a getMessageSize method to MessageStore to support retrieving the
total message size of all stored messages for a destination. This is useful
GitHub user cshannon opened a pull request:
https://github.com/apache/activemq/pull/93
Added an uncaught exception handler to ThreadPoolExecutor
Added an uncaught exception handler to ThreadPoolExecutor getExecutor()
method to log errors in threads.
This resolves https
GitHub user cshannon opened a pull request:
https://github.com/apache/activemq/pull/97
Adding a configuration option set max destinations on the broker
Adding a configuration option to PolicyEntry to enable setting the maximum
number of created destinations by policy on the broker
GitHub user cshannon opened a pull request:
https://github.com/apache/activemq/pull/98
Adding the ability to limit the maximum size of a message
Adding the ability to limit the maximum size of a message sent by a client
per transport.
This can be configured in on the
Github user cshannon closed the pull request at:
https://github.com/apache/activemq/pull/98
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user cshannon opened a pull request:
https://github.com/apache/activemq/pull/99
Adding maxFrameSize to the Stomp Protocol
Adding maxFrameSize to the Stomp Protocol so that a maximum frame size can
be validated to be consistent with OpenWire.
This applies to https
GitHub user cshannon opened a pull request:
https://github.com/apache/activemq/pull/101
Fixing missing volatile on references in VMTransport
Fixing missing volatile on references in VMTransport to prevent a
synchronization bug.
This resolves https://issues.apache.org/jira
Github user cshannon closed the pull request at:
https://github.com/apache/activemq/pull/99
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user cshannon closed the pull request at:
https://github.com/apache/activemq/pull/101
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user cshannon opened a pull request:
https://github.com/apache/activemq/pull/102
https://issues.apache.org/jira/browse/AMQ-5792 - Adding
SubscriptionStatistics
Adding SubscriptionStatistics to group together all metrics in a bean
for a subscription.
You can merge this
GitHub user cshannon opened a pull request:
https://github.com/apache/activemq/pull/103
https://issues.apache.org/jira/browse/AMQ-5771
Including remote ip address when logging authentication failures
You can merge this pull request into a Git repository by running:
$ git pull
GitHub user cshannon opened a pull request:
https://github.com/apache/activemq/pull/105
https://issues.apache.org/jira/browse/AMQ-5813
Fixing countBeforeFull for TopicSubscriptions to report a positive value
You can merge this pull request into a Git repository by running
GitHub user cshannon opened a pull request:
https://github.com/apache/activemq/pull/110
https://issues.apache.org/jira/browse/AMQ-5393
Adding a property called schedulePeriodForDiskUsageCheck which can be set
to a time period to periodically check disk usage limits and adjust if
GitHub user cshannon opened a pull request:
https://github.com/apache/activemq/pull/111
https://issues.apache.org/jira/browse/AMQ-5836
Modifying start up scripts to consistently use the same property names
You can merge this pull request into a Git repository by running:
$ git
GitHub user cshannon opened a pull request:
https://github.com/apache/activemq/pull/113
https://issues.apache.org/jira/browse/AMQ-5837
This commit adds an Inflight message size statistic to
SubscriptionStatistics so we can know the size of all the messages that are
inflight
GitHub user cshannon opened a pull request:
https://github.com/apache/activemq/pull/115
https://issues.apache.org/jira/browse/AMQ-5843
Adding a new property on PolicyEntry called includeBodyForAdvisory which
will
include the original message body when sending advisory messages
GitHub user cshannon opened a pull request:
https://github.com/apache/activemq/pull/116
https://issues.apache.org/jira/browse/AMQ-5668
This commit fixes a race condition in AbstractStoreCursor setLastCacheId
that could
cause a null pointer exception in certain cases.
You can
GitHub user cshannon opened a pull request:
https://github.com/apache/activemq/pull/117
https://issues.apache.org/jira/browse/AMQ-5705
Modifing the AdivsoryBroker to set the originBrokerURL to the transport
connector's
URL if it has been set versus using a default URL.
Yo
GitHub user cshannon opened a pull request:
https://github.com/apache/activemq/pull/118
https://issues.apache.org/jira/browse/AMQ-5745
This commit is based off a patch submitted by ad...@int3solutions.com.
It fixes several locations in the code where there are potential resource
GitHub user cshannon opened a pull request:
https://github.com/apache/activemq/pull/123
https://issues.apache.org/jira/browse/AMQ-5851
This commit resolves an issue where unmatched acknowledgement
messages could be received when running a MDB consumer and
sending messages
GitHub user cshannon opened a pull request:
https://github.com/apache/activemq/pull/124
https://issues.apache.org/jira/browse/AMQ-5865
StompSocket and MQTTSocket will now return the appropriate web socket
remote address based on the HttpRequestServlet that initialized
the
GitHub user cshannon opened a pull request:
https://github.com/apache/activemq/pull/125
https://issues.apache.org/jira/browse/AMQ-5814
This fixes an issue where a producer's connection context was being
used to create a subscription instead of the consumer's context
Github user cshannon closed the pull request at:
https://github.com/apache/activemq/pull/125
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user cshannon opened a pull request:
https://github.com/apache/activemq/pull/127
https://issues.apache.org/jira/browse/AMQ-5340
A QueueBrowser no longer checks expiry on messages to prevent a
browser from hanging in between the hasMoreElements check and actually
GitHub user cshannon opened a pull request:
https://github.com/apache/activemq/pull/128
https://issues.apache.org/jira/browse/AMQ-5748
Fixing a potential Null pointer exception in MemoryMessageStore
You can merge this pull request into a Git repository by running:
$ git pull
GitHub user cshannon opened a pull request:
https://github.com/apache/activemq/pull/129
https://issues.apache.org/jira/browse/AMQ-5748
Fixing an issue that prevented old versions of KahaDB from being
upgraded to the newest version 6
You can merge this pull request into a Git
GitHub user cshannon opened a pull request:
https://github.com/apache/activemq/pull/130
https://issues.apache.org/jira/browse/AMQ-5875
Resolves an issue when using mKahaDB that caused a MessageStore
being used by more than one destination to be deleted even though
there was
Github user cshannon closed the pull request at:
https://github.com/apache/activemq/pull/84
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user cshannon opened a pull request:
https://github.com/apache/activemq/pull/131
https://issues.apache.org/jira/browse/AMQ-5875
Fixing a regression that caused a network bridge to recreate durable
demand improperly.
You can merge this pull request into a Git repository
Github user cshannon closed the pull request at:
https://github.com/apache/activemq/pull/131
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user cshannon opened a pull request:
https://github.com/apache/activemq/pull/132
https://issues.apache.org/jira/browse/AMQ-5875
Fixing a regression that caused a network bridge to recreate durable
demand improperly.
You can merge this pull request into a Git repository
GitHub user cshannon opened a pull request:
https://github.com/apache/activemq/pull/134
https://issues.apache.org/jira/browse/AMQ-5857
Changing ActiveMQTextMessage to clear out the text field on marshal to
a ByteSequence to prevent the data from being stored in memory twice
GitHub user cshannon opened a pull request:
https://github.com/apache/activemq/pull/135
https://issues.apache.org/jira/browse/AMQ-5879
Adding full exception to logs for tansport failures when the exception
is unexpected to help debugging.
You can merge this pull request into a
Github user cshannon closed the pull request at:
https://github.com/apache/activemq/pull/135
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user cshannon opened a pull request:
https://github.com/apache/activemq/pull/136
https://issues.apache.org/jira/browse/AMQ-5875
Reworking DurableConduitBridge to look up subscriptions from the
msesage store instead of the RegionBroker since inactive subscriptions
need
Github user cshannon closed the pull request at:
https://github.com/apache/activemq/pull/132
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user cshannon closed the pull request at:
https://github.com/apache/activemq/pull/136
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user cshannon closed the pull request at:
https://github.com/apache/activemq/pull/134
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user cshannon opened a pull request:
https://github.com/apache/activemq-artemis/pull/772
ARTEMIS-730: Updating Hacking guide documentation
Fixed a few issues with Eclipse related documentation
You can merge this pull request into a Git repository by running:
$ git pull
GitHub user cshannon opened a pull request:
https://github.com/apache/activemq-artemis/pull/774
https://issues.apache.org/jira/browse/ARTEMIS-730
Adding instructions to set up test projects to work in eclipse that
depend on the unit-tests project. This is necessary so that the
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/774
@clebertsuconic , I added some more documentation for Eclipse. @tabish121
and I both ran into problems running integration tests from Eclipse and this is
a work around as the issue seems
GitHub user cshannon opened a pull request:
https://github.com/apache/activemq-artemis/pull/822
Eclipse fixes
This PR includes one documentation fix and also excludes an old xml-apis
test jar that is unnecessary so that it doesn't interfere with the classpath in
eclipse and
GitHub user cshannon opened a pull request:
https://github.com/apache/activemq-artemis/pull/864
https://issues.apache.org/jira/browse/ARTEMIS-819
Increasing the minimum required version of Java to Java 8
You can merge this pull request into a Git repository by running:
$ git
Github user cshannon commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/864#discussion_r84760382
--- Diff: pom.xml ---
@@ -128,8 +128,8 @@
UTF-8
UTF-8
- 1.7
- 1.7
+ 1.8
--- End diff
GitHub user cshannon opened a pull request:
https://github.com/apache/activemq-artemis/pull/1015
https://issues.apache.org/jira/browse/ARTEMIS-964
Moving XML conversion logic to a common XmlDataExporterUtil class so it
can be used elsewhere.
You can merge this pull request into
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/1015
I changed the commit message.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user cshannon opened a pull request:
https://github.com/apache/activemq-artemis/pull/1019
ARTEMIS-943 fix queueType in import-export schema
https://issues.apache.org/jira/browse/ARTEMIS-943
queueType in the artemis-import-export schema needs to be marked with
min
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/1019
@clebertsuconic and @jbertram ,
If necessary I can create a new Jira for this but it seemed minor enough
that I just attached it to the existing Jira that was used to add the
GitHub user cshannon opened a pull request:
https://github.com/apache/activemq-artemis/pull/1242
ARTEMIS-898 - Adding Plugin Support
Adding a new ActievMQServerPlugin interface to support adding custom
behavior to the broker at certain events such as connection or session
creation
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/1242
@clebertsuconic - I just ran my new tests and the sanity check as I figured
the complete test suite takes a long time to run so I was going to let Jenkins
run it. So up to you if you
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/1242
It's running now but will probably take a while.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project doe
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/1242
Yeah I thought about that but wasn't sure how much of a difference it would
really make in terms of real performance and how the JVM will optimize. I was
trying to keep the code
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/1242
@clebertsuconic - I added a second commit to address the performance
concerns, the lambda expressions should now be avoided if there are no
registered plugins. The JVM should skip the
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/1242
I'll rebase, let me do that real quick.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/1242
@clebertsuconic - should be good to go, i squashed the commits and I
rebased against the latest in master
---
If your project is set up for it, you can reply to this email and have your
GitHub user cshannon opened a pull request:
https://github.com/apache/activemq-artemis/pull/1257
ARTEMIS-898 - Adding support for XML configuration of Broker Plugins
Broker plugins can now be added to the broker through XML config.
You can merge this pull request into a Git
GitHub user cshannon opened a pull request:
https://github.com/apache/activemq-artemis/pull/1258
ARTEMIS-898 - Adding documentation for Plugin support
Started a new chapter in the user manual for plugin support
You can merge this pull request into a Git repository by running
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/1258
@clebertsuconic - I added basic documentation for the plugin feature here
but I think for next release it would also be good to add to the existing
examples with a sample plugin to show
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/1258
No, what do you mean?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/1258
I would say that the ServiceLoader stuff makes more sense for internal
things like the protocol manager. I think a lot of users would want to have
more explicit control over registering
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/1258
Yeah I wouldn't put it into 2.1.0 at this point. If it gets added it would
be a future release. There are issues to work out with using the
ServiceLocator support such as h
GitHub user cshannon opened a pull request:
https://github.com/apache/activemq-artemis/pull/1277
ARTEMIS-1172 - Update beforeDeliver and afterDeliver method arguments
Adding ServerConsumer as an argument to both the beforeDeliver and
afterDeliver methods inside
GitHub user cshannon opened a pull request:
https://github.com/apache/activemq-artemis/pull/1373
ARTEMIS-1258 - Add ServerSession as an argument to before/after send plugin
methods
This improves the beforeSend and afterSend callback by allowing the plugin
writer to get access to
GitHub user cshannon opened a pull request:
https://github.com/apache/activemq-artemis/pull/1445
ARTEMIS-1327 - Support checked exceptions in ActiveMQServerPlugin
This will allow plugin writers to use checked exceptions when writing
plugins
You can merge this pull request into
1 - 100 of 214 matches
Mail list logo
