[GitHub] activemq-6 pull request: ACTIVEMQ6-40 Update to the geronimo jms 2...

2015-01-02 Thread johnament
GitHub user johnament opened a pull request: https://github.com/apache/activemq-6/pull/51 ACTIVEMQ6-40 Update to the geronimo jms 2 spec JAR. Geronimo now has a JMS 2 spec jar published. I've updated the ActiveMQ 6 code base to point to it. You were also missing apache parent

[GitHub] activemq-artemis pull request: HornetQ Protocol Support

2015-05-05 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/227#discussion_r29698636 --- Diff: artemis-protocols/artemis-hornetq-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/hornetq

[GitHub] activemq-artemis pull request: Connection Factory updates

2015-06-04 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/15#discussion_r31742948 --- Diff: pom.xml --- @@ -53,7 +53,7 @@ properties !-- base url for site deployment. See distribution management for full url

[GitHub] activemq-artemis pull request: Artemis 120

2015-06-04 Thread johnament
GitHub user johnament opened a pull request: https://github.com/apache/activemq-artemis/pull/18 Artemis 120 You can merge this pull request into a Git repository by running: $ git pull https://github.com/johnament/activemq-artemis ARTEMIS-120 Alternatively you can review

[GitHub] activemq-artemis pull request: ARTEMIS-119 Upgraded to Jetty 9.2.

2015-06-04 Thread johnament
Github user johnament commented on the pull request: https://github.com/apache/activemq-artemis/pull/16#issuecomment-108909261 @clebertsuconic yep that was the issue. Removed the y and its doing the right thing now. --- If your project is set up for it, you can reply to this email

[GitHub] activemq-artemis pull request: Connection Factory updates

2015-06-04 Thread johnament
Github user johnament commented on the pull request: https://github.com/apache/activemq-artemis/pull/15#issuecomment-108931776 @clebertsuconic I'm not sure what you're referring to btw, I don't recall discussing with you that option. --- If your project is set up for it, you can

[GitHub] activemq-artemis pull request: Connection Factory updates

2015-06-04 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/15#discussion_r31730205 --- Diff: pom.xml --- @@ -53,7 +53,7 @@ properties !-- base url for site deployment. See distribution management for full url

[GitHub] activemq-artemis pull request: Connection Factory updates

2015-06-04 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/15#discussion_r31731232 --- Diff: pom.xml --- @@ -53,7 +53,7 @@ properties !-- base url for site deployment. See distribution management for full url

[GitHub] activemq-artemis pull request: ARTEMIS-119 Upgraded to Jetty 9.2.

2015-06-03 Thread johnament
GitHub user johnament opened a pull request: https://github.com/apache/activemq-artemis/pull/16 ARTEMIS-119 Upgraded to Jetty 9.2. You can merge this pull request into a Git repository by running: $ git pull https://github.com/johnament/activemq-artemis ARTEMIS-119

[GitHub] activemq-artemis pull request: ARTEMIS-120 Upgraded Netty to lates...

2015-06-03 Thread johnament
GitHub user johnament opened a pull request: https://github.com/apache/activemq-artemis/pull/14 ARTEMIS-120 Upgraded Netty to latest 4.0.x. You can merge this pull request into a Git repository by running: $ git pull https://github.com/johnament/activemq-artemis ARTEMIS-120

[GitHub] activemq-artemis pull request: Connection Factory updates

2015-06-03 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/15#discussion_r31688005 --- Diff: tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/ConnectionTest.java --- @@ -65,6 +67,33 @@ public void

[GitHub] activemq-artemis pull request: ARTEMIS-119 Upgraded to Jetty 9.2.

2015-06-04 Thread johnament
Github user johnament commented on the pull request: https://github.com/apache/activemq-artemis/pull/16#issuecomment-108855820 @clebertsuconic ah -ha, that's the question I had on the mailing list as well. I'll take a look this evening. --- If your project is set up for it, you

[GitHub] activemq-artemis pull request: ARTEMIS-91 Improvements to the Serv...

2015-06-16 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/31#discussion_r32566155 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/ServiceRegistry.java --- @@ -32,32 +32,12 @@ { --- End

[GitHub] activemq-artemis pull request: ARTEMIS-116 Fixed exception handlin...

2015-06-16 Thread johnament
Github user johnament commented on the pull request: https://github.com/apache/activemq-artemis/pull/32#issuecomment-112617374 I added a fix for ARTEMIS-140. Doing some adhoc testing didn't give quite the results I was hoping for. --- If your project is set up for it, you can reply

[GitHub] activemq-artemis pull request: ARTEMIS-116 Fixed exception handlin...

2015-06-16 Thread johnament
GitHub user johnament opened a pull request: https://github.com/apache/activemq-artemis/pull/32 ARTEMIS-116 Fixed exception handling. Minor formatting clean up in t… …he CLI. You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] activemq-artemis pull request: ARTEMIS-91 Separated out interface ...

2015-06-10 Thread johnament
GitHub user johnament opened a pull request: https://github.com/apache/activemq-artemis/pull/24 ARTEMIS-91 Separated out interface for ServiceRegistry. Provided a g… …etter in the ActiveMQServer interface. @jmesnil is this what you were thinking? You can merge

[GitHub] activemq-artemis pull request: ARTEMIS-103 Changed JGroupsBroadcas...

2015-06-14 Thread johnament
Github user johnament commented on the pull request: https://github.com/apache/activemq-artemis/pull/27#issuecomment-111905436 @clebertsuconic that's one of the pains with the ASF setup for github, need to push to the ASF git repo. --- If your project is set up for it, you can reply

[GitHub] activemq-artemis pull request: ARTEMIS-103 Changed JGroupsBroadcas...

2015-06-14 Thread johnament
Github user johnament commented on the pull request: https://github.com/apache/activemq-artemis/pull/27#issuecomment-111905386 @clebertsuconic nope, not a committer. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] activemq-artemis pull request: ARTEMIS-119 Upgraded to Jetty 9.2.

2015-06-04 Thread johnament
Github user johnament commented on the pull request: https://github.com/apache/activemq-artemis/pull/16#issuecomment-108900627 Ok, this is the best I can do. Let me know your thoughts. It looks like there is no geronimo spec jar for servlet 3.1 (which is what Jetty 9.2 is based

[GitHub] activemq-artemis pull request: ARTEMIS-119 Upgraded to Jetty 9.2.

2015-06-04 Thread johnament
Github user johnament commented on the pull request: https://github.com/apache/activemq-artemis/pull/16#issuecomment-108900995 This is the output btw ``` Johns-MBP:bin johnament$ ./artemis create /tmp/myserver --user a --password a --allow-anonymous y Creating

[GitHub] activemq-artemis pull request: ARTEMIS-148 Upgrade to alpha 2 JAR.

2015-06-30 Thread johnament
GitHub user johnament opened a pull request: https://github.com/apache/activemq-artemis/pull/57 ARTEMIS-148 Upgrade to alpha 2 JAR. Upgraded JAR. You can merge this pull request into a Git repository by running: $ git pull https://github.com/johnament/activemq-artemis ARTEMIS

[GitHub] activemq-artemis pull request: Don't auto-send STOMP content-lengt...

2015-07-20 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/86#discussion_r34987573 --- Diff: artemis-protocols/artemis-stomp-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/stomp/v11/StompFrameV11.java

[GitHub] activemq-artemis pull request: Don't auto-send STOMP content-lengt...

2015-07-20 Thread johnament
Github user johnament commented on the pull request: https://github.com/apache/activemq-artemis/pull/86#issuecomment-122944335 @clebertsuconic none taken at all. I just know that issues like this tend to lead to buffer overflow type errors. It's technically an unrelated issue

[GitHub] activemq-artemis pull request: ARTEMIS-326 Quote logging configura...

2015-12-21 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/282#discussion_r48204956 --- Diff: pom.xml --- @@ -115,11 +115,11 @@ --> -Djava.util.logging.manager=org.jboss.logmanager.LogMana

[GitHub] activemq-artemis pull request: ARTEMIS-326 Quote logging configura...

2015-12-21 Thread johnament
Github user johnament commented on the pull request: https://github.com/apache/activemq-artemis/pull/282#issuecomment-166446355 Lets see if this fixes it. I'm on 3.3.9, so I'm wondering if it may be a difference in variable resolution. --- If your project is set up for it, you can

[GitHub] activemq-artemis pull request: ARTEMIS-326 Quote logging configura...

2015-12-21 Thread johnament
Github user johnament commented on the pull request: https://github.com/apache/activemq-artemis/pull/282#issuecomment-166449487 Ok, it seems like it was a jenkins config issue. I changed your config to explicitly point to 3.2.5 (which is the minimum version required as per

[GitHub] activemq-artemis pull request: ARTEMIS-326 Quote logging configura...

2015-12-21 Thread johnament
Github user johnament closed the pull request at: https://github.com/apache/activemq-artemis/pull/282 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] activemq-artemis pull request: ARTEMIS-326 Quote logging configura...

2015-12-21 Thread johnament
Github user johnament commented on the pull request: https://github.com/apache/activemq-artemis/pull/282#issuecomment-166477108 I'm going to decline this PR. Looks like my initial issue with single quotes was user error and that's working fine. --- If your project is set up

[GitHub] activemq-artemis pull request: ARTEMIS-326 Quote parameters that m...

2015-12-21 Thread johnament
GitHub user johnament opened a pull request: https://github.com/apache/activemq-artemis/pull/283 ARTEMIS-326 Quote parameters that may include spaces. You can merge this pull request into a Git repository by running: $ git pull https://github.com/johnament/activemq-artemis

[GitHub] activemq-artemis pull request #602: NO-JIRA update building instructions on ...

2016-06-26 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/602#discussion_r68509150 --- Diff: docs/hacking-guide/en/building.md --- @@ -23,9 +23,9 @@ Install `NPM` using the instructions below The new npm

[GitHub] activemq-artemis pull request: ARTEMIS-463 Refactored protocol loa...

2016-04-11 Thread johnament
GitHub user johnament opened a pull request: https://github.com/apache/activemq-artemis/pull/456 ARTEMIS-463 Refactored protocol loading code to not duplicate logic, and load from the default list. Prior to this change, when you would start the broker on the CLI, you would see

[GitHub] activemq-artemis pull request #667: ARTEMIS-43 Adding notice about HornetQ d...

2016-07-26 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/667#discussion_r72306219 --- Diff: NOTICE --- @@ -3,3 +3,7 @@ Copyright [2014-2016] The Apache Software Foundation This product includes software developed

[GitHub] activemq-artemis pull request #667: ARTEMIS-43 Adding notice about HornetQ d...

2016-07-26 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/667#discussion_r72302279 --- Diff: NOTICE --- @@ -3,3 +3,7 @@ Copyright [2014-2016] The Apache Software Foundation This product includes software developed

[GitHub] activemq-artemis pull request #662: ARTEMIS-587 add more JSON JMX mgmt metho...

2016-07-25 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/662#discussion_r72180014 --- Diff: artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/management/impl/JMSServerControlImpl.java --- @@ -796,20 +796,12

[GitHub] activemq-artemis issue #640: ARTEMIS-565 Replace json.org with javax.json

2016-07-25 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/640 I pinged the PMC to add me as contributor. That will allow JIRA assignment. I must have had something cached, as this was after I rebased. --- If your project is set up

[GitHub] activemq-artemis issue #640: ARTEMIS-565 Replace json.org with javax.json

2016-07-25 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/640 I just checked. its happening with my changes. I can't find this log message anywhere though. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] activemq-artemis issue #640: ARTEMIS-565 Replace json.org with javax.json

2016-07-25 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/640 No problems @clebertsuconic hope it went well. I pushed up fixes, one oddity is that when starting the broker I get this on the console... ``` 20:50:26,422 INFO

[GitHub] activemq-artemis pull request #667: ARTEMIS-43 Adding notice about HornetQ d...

2016-07-27 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/667#discussion_r72416705 --- Diff: NOTICE --- @@ -3,3 +3,7 @@ Copyright [2014-2016] The Apache Software Foundation This product includes software developed

[GitHub] activemq-artemis pull request #653: ARTEMIS-548 Stomp durable sub unsubscrbe

2016-07-21 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/653#discussion_r71780013 --- Diff: artemis-protocols/artemis-stomp-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/stomp/StompProtocolManager.java

[GitHub] activemq-artemis issue #640: ARTEMIS-565 Replace json.org with javax.json

2016-07-25 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/640 Ah good catch. I can fix that, probably some assembly issues. I'm assuming shipping johnzon as the default is fine? --- If your project is set up for it, you can reply to this email

[GitHub] activemq-artemis issue #640: ARTEMIS-565 Replace json.org with javax.json

2016-07-25 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/640 @clebertsuconic yes, once i fix the distribution the johnzon one will ship by default. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] activemq-artemis issue #640: ARTEMIS-565 Replace json.org with javax.json

2016-07-25 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/640 @clebertsuconic oh, for wildfly, you'll need to add dependencies on `javax.json.api` and `org.glassfish.javax.json` modules. As far as plain library usage, the dependency tree

[GitHub] activemq-artemis pull request #662: ARTEMIS-587 add more JSON JMX mgmt metho...

2016-07-25 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/662#discussion_r72125621 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/ActiveMQServerControlImpl.java --- @@ -1360,6 +1359,130

[GitHub] activemq-artemis pull request #667: ARTEMIS-43 Adding notice about HornetQ d...

2016-07-27 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/667#discussion_r72448663 --- Diff: NOTICE --- @@ -3,3 +3,7 @@ Copyright [2014-2016] The Apache Software Foundation This product includes software developed

[GitHub] activemq-artemis issue #672: [ARTEMIS-642] Disable slow client reconnecting ...

2016-07-27 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/672 @bayern39 sorry, you're right. I just realized your changes in `failoverOrReconnect` is in the client side. --- If your project is set up for it, you can reply to this email and have

[GitHub] activemq-artemis issue #672: [ARTEMIS-642] Disable slow client reconnecting ...

2016-07-27 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/672 BTW, you may want to look at the jenkins output. May be a new test failing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] activemq-artemis issue #640: ARTEMIS-565 Replace json.org with javax.json

2016-07-21 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/640 Ok, the changes should be good. I manually ran the integration tests that were touched, and fixed a bunch of issues identified there. I'm going to create a ticket to create

[GitHub] activemq-artemis pull request #682: Adding set -e on merge script

2016-07-28 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/682#discussion_r72696319 --- Diff: scripts/merge-PR.sh --- @@ -16,6 +16,8 @@ # specific language governing permissions and limitations # under the License

[GitHub] activemq-artemis issue #684: ARTEMIS-565 Dealing with ClassLoading issues on...

2016-07-28 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/684 What was happening prior to this change? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] activemq-artemis issue #684: ARTEMIS-565 Dealing with ClassLoading issues on...

2016-07-28 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/684 If you don't mind, let me take a look over the weekend. This sounds like more of an issue with the geronimo spec jar, which we can get changes into. https://github.com/apache

[GitHub] activemq-artemis issue #684: ARTEMIS-565 Dealing with ClassLoading issues on...

2016-07-28 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/684 Mmmph. So I can fix the spec jar for geronimo, but the problem will persist in the other spec jars, e.g. the same problem happens w/ the RI JAR and the JBoss JAR. Minor issue

[GitHub] activemq-artemis pull request #691: ARTEMIS-659 Remove unneeded CDI dependen...

2016-07-31 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/691#discussion_r72918082 --- Diff: pom.xml --- @@ -349,16 +349,9 @@ -javax.enterprise -cdi-api

[GitHub] activemq-artemis pull request #691: ARTEMIS-659 Remove unneeded CDI dependen...

2016-07-31 Thread johnament
GitHub user johnament opened a pull request: https://github.com/apache/activemq-artemis/pull/691 ARTEMIS-659 Remove unneeded CDI dependency. Switch to geronimo atinj… …ect JAR in all uses. It turned out the client wasn't even using the dependency and the JARs were

[GitHub] activemq-artemis issue #672: [ARTEMIS-642] Disable slow client reconnecting ...

2016-08-01 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/672 @clebertsuconic think we can add the version aware stuff to the hacking guide? Would be useful for those not very familiar to know how to deal with it. --- If your project is set up

[GitHub] activemq-artemis pull request #672: [ARTEMIS-642] Disable slow client reconn...

2016-08-01 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/672#discussion_r72964880 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/RemotingConnectionImpl.java --- @@ -387,4

[GitHub] activemq-artemis pull request #672: [ARTEMIS-642] Disable slow client reconn...

2016-08-01 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/672#discussion_r72964784 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/ActiveMQSessionContext.java --- @@ -162,6

[GitHub] activemq-artemis pull request #672: [ARTEMIS-642] Disable slow client reconn...

2016-07-27 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/672#discussion_r72421190 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/DisconnectConsumerWithKillMessage.java

[GitHub] activemq-artemis pull request #672: [ARTEMIS-642] Disable slow client reconn...

2016-07-27 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/672#discussion_r72421069 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java --- @@ -2983,6 +2988,18 @@ else

[GitHub] activemq-artemis pull request #672: [ARTEMIS-642] Disable slow client reconn...

2016-07-27 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/672#discussion_r72420954 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java --- @@ -2971,6 +2975,7 @@ public void run

[GitHub] activemq-artemis issue #672: [ARTEMIS-642] Disable slow client reconnecting ...

2016-07-27 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/672 It strikes me that the client needs to know about this message type as well, potentially. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] activemq-artemis pull request #672: [ARTEMIS-642] Disable slow client reconn...

2016-07-27 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/672#discussion_r72420571 --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/SlowConsumerTest.java --- @@ -115,6 +119,40

[GitHub] activemq-artemis pull request #672: [ARTEMIS-642] Disable slow client reconn...

2016-07-27 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/672#discussion_r72420605 --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/SlowConsumerTest.java --- @@ -115,6 +119,40

[GitHub] activemq-artemis pull request #667: ARTEMIS-43 Adding notice about HornetQ d...

2016-07-26 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/667#discussion_r72292777 --- Diff: NOTICE --- @@ -3,3 +3,7 @@ Copyright [2014-2016] The Apache Software Foundation This product includes software developed

[GitHub] activemq-artemis pull request #667: ARTEMIS-43 Adding notice about HornetQ d...

2016-07-26 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/667#discussion_r72296232 --- Diff: NOTICE --- @@ -3,3 +3,7 @@ Copyright [2014-2016] The Apache Software Foundation This product includes software developed

[GitHub] activemq-artemis issue #672: [ARTEMIS-642] Disable slow client reconnecting ...

2016-08-01 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/672 Looks good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] activemq-artemis issue #694: ARTEMIS-659 Remove unneeded CDI dependency

2016-08-01 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/694 If that comes in, I'll bring in a separate dependency from geronimo. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] activemq-artemis pull request #691: ARTEMIS-659 Remove unneeded CDI dependen...

2016-08-01 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/691#discussion_r73035248 --- Diff: pom.xml --- @@ -349,16 +349,9 @@ -javax.enterprise -cdi-api

[GitHub] activemq-artemis pull request #712: Artemis 447

2016-08-10 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/712#discussion_r74238033 --- Diff: artemis-protocols/artemis-proton-plug/src/main/java/org/proton/plug/context/AbstractConnectionContext.java --- @@ -73,6 +76,8

[GitHub] activemq-artemis pull request #712: Artemis 447

2016-08-10 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/712#discussion_r74238129 --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/proton/ProtonTest.java --- @@ -211,6 +213,25

[GitHub] activemq-artemis issue #718: just some refactorings

2016-08-11 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/718 Could you create a Jira and reference it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] activemq pull request #194: Renamed README file. Updated link for encryption...

2016-08-04 Thread johnament
GitHub user johnament opened a pull request: https://github.com/apache/activemq/pull/194 Renamed README file. Updated link for encryption and location of LICENSE. Formatting looks better IMHO, if you want to take a look: https://github.com/johnament/activemq/blob/master/README.md

[GitHub] activemq-artemis issue #717: Logs, docs and CLI

2016-08-10 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/717 Let me give it a shot.. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] activemq-artemis issue #640: ARTEMIS-565 Replace json.org with javax.json

2016-07-21 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/640 @puntogil yep, that's why i'm not saying this is ready. @mtaylor Ok, I'll clean it up. Thanks for looking at this guys! --- If your project is set up for it, you can

[GitHub] activemq-artemis pull request #640: ARTEMIS-565 Replace json.org with javax....

2016-07-17 Thread johnament
GitHub user johnament opened a pull request: https://github.com/apache/activemq-artemis/pull/640 ARTEMIS-565 Replace json.org with javax.json Javax.json is a newer JSR, but has an ASF compliant version, is pretty close to the original JSON.org API and will support a standard

[GitHub] activemq-artemis issue #618: Upgrade ApacheRat to 0.12

2016-07-04 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/618 Kicked it off again, not sure why it failed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] activemq-artemis issue #617: ARTEMIS-607 Added interceptor support for MQTT ...

2016-07-05 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/617 Ok, I rebased from master and squashed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] activemq-artemis issue #617: ARTEMIS-607 Added interceptor support for MQTT ...

2016-07-05 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/617 Up to you. I won't be able to squash until this evening. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] activemq-artemis pull request #706: ARTEMIS-671 Returning messages after con...

2016-08-08 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/706#discussion_r73975246 --- Diff: artemis-commons/src/main/java/org/apache/activemq/artemis/logs/AssertionLoggerHandler.java --- @@ -71,6 +71,26 @@ public static

[GitHub] activemq-artemis issue #706: ARTEMIS-671 Returning messages after connection...

2016-08-09 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/706 BTW -> SOP = System.out.println instead of logging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[GitHub] activemq-artemis issue #691: ARTEMIS-659 Remove unneeded CDI dependency. Swi...

2016-08-01 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/691 Closing out since Clebert pushed his own version. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] activemq-artemis pull request #691: ARTEMIS-659 Remove unneeded CDI dependen...

2016-08-01 Thread johnament
Github user johnament closed the pull request at: https://github.com/apache/activemq-artemis/pull/691 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] activemq-artemis issue #640: ARTEMIS-565 Replace json.org with javax.json

2016-07-23 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/640 I'm not sure why Jenkins didn't write the result back, but the build did pass in Jenkins. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] activemq-artemis pull request #680: Null pointer/check related fixes

2016-07-28 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/680#discussion_r72686371 --- Diff: artemis-commons/src/main/java/org/apache/activemq/artemis/utils/FileUtil.java --- @@ -63,10 +63,15 @@ public static final boolean

[GitHub] activemq-artemis pull request #672: [ARTEMIS-642] Disable slow client reconn...

2016-07-28 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/672#discussion_r72686692 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/ActiveMQSessionContext.java --- @@ -759,6

[GitHub] activemq-artemis pull request #672: [ARTEMIS-642] Disable slow client reconn...

2016-07-28 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/672#discussion_r72686789 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/RemotingConnectionImpl.java --- @@ -387,4

[GitHub] activemq-artemis pull request #682: Adding set -e on merge script

2016-07-28 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/682#discussion_r72686205 --- Diff: scripts/merge-PR.sh --- @@ -16,6 +16,8 @@ # specific language governing permissions and limitations # under the License

[GitHub] activemq-artemis issue #684: ARTEMIS-565 Dealing with ClassLoading issues on...

2016-07-29 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/684 At this point, this is the best solution to ensure that it works across different impls and spec jars. +1 --- If your project is set up for it, you can reply to this email and have your

[GitHub] activemq-artemis issue #610: Artemis build enhancements

2016-06-30 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/610 The usage of maven-wrapper.jar is fine. You just need to make sure its excluded from your source release (and probably exclude mvnw and mvnw.bat files) https://github.com/takari

[GitHub] activemq-artemis issue #610: Artemis build enhancements

2016-06-30 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/610 @clebertsuconic yep, shouldn't be an issue having it in source, just like the libaio binary. Just need to exclude it from your source release. @glauciom Even though they're

[GitHub] activemq-artemis issue #610: Artemis build enhancements

2016-06-30 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/610 Well its still in the PR - https://github.com/glauciom/activemq-artemis/blob/c84c39abf0c9033a0a3b989dabee9ab12e5f030c/.mvn/wrapper/maven-wrapper.jar --- If your project is set up

[GitHub] activemq-artemis issue #610: Artemis build enhancements

2016-06-30 Thread johnament
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/610 @clebertsuconic maybe from your POV. However, from a release standpoint they carry the same problems. --- If your project is set up for it, you can reply to this email and have your

[GitHub] activemq-artemis pull request #617: ARTEMIS-607 Added interceptor support fo...

2016-07-03 Thread johnament
GitHub user johnament opened a pull request: https://github.com/apache/activemq-artemis/pull/617 ARTEMIS-607 Added interceptor support for MQTT protocol. BTW, feel free to cry foul on things that don't look right. I was trying to follow the patterns in Stomp, but the structure

[GitHub] activemq-artemis pull request #617: ARTEMIS-607 Added interceptor support fo...

2016-07-03 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/617#discussion_r69403171 --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/mqtt/imported/MQTTTest.java --- @@ -380,7 +384,8

[GitHub] activemq-artemis pull request #610: Artemis build enhancements

2016-07-01 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/610#discussion_r69366465 --- Diff: pom.xml --- @@ -112,8 +112,8 @@ UTF-8 UTF-8 - 1.7 - 1.7 + 1.8 + 1.8

[GitHub] activemq-artemis pull request #:

2016-08-17 Thread johnament
Github user johnament commented on the pull request: https://github.com/apache/activemq-artemis/commit/76288a3ad9f468332cba2580b63cb0da79b6ccc3#commitcomment-18671852 In pom.xml: In pom.xml on line 591: That would be here: https://github.com/apache/activemq-artemis/blob

[GitHub] activemq-artemis pull request #725: Add forceShutdown core management operat...

2016-08-17 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/725#discussion_r75113156 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/ActiveMQServerControlImpl.java --- @@ -1983,6 +1983,12

[GitHub] activemq pull request #194: Renamed README file. Updated link for encryption...

2016-08-15 Thread johnament
Github user johnament closed the pull request at: https://github.com/apache/activemq/pull/194 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] activemq-artemis pull request #754: Adding my releasing experience to RELEAS...

2016-09-06 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/754#discussion_r77720730 --- Diff: RELEASING.md --- @@ -36,6 +36,16 @@ The file will be located under ./artemis-pom/RELEASE/ Remove these files manually under Nexus

[GitHub] activemq-artemis pull request #754: Adding my releasing experience to RELEAS...

2016-09-06 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/754#discussion_r77727254 --- Diff: RELEASING.md --- @@ -36,6 +36,16 @@ The file will be located under ./artemis-pom/RELEASE/ Remove these files manually under Nexus

[GitHub] activemq-artemis pull request #754: Adding my releasing experience to RELEAS...

2016-09-06 Thread johnament
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/754#discussion_r77727346 --- Diff: RELEASING.md --- @@ -45,6 +55,26 @@ mvn clean release:prepare -DautoVersionSubmodules=true -Prelease

  1   2   >