[GitHub] activemq-artemis pull request: ARTEMIS-129 removes empty package-i...

2015-06-23 Thread orpiske
GitHub user orpiske opened a pull request: https://github.com/apache/activemq-artemis/pull/44 ARTEMIS-129 removes empty package-info.java files As describes in ARTEMIS-129, performs a small cleanup on the codebase by removing empty package-info.java files. You can merge this pull

[GitHub] activemq-artemis pull request #1130: Add a MQTT interceptor example

2017-03-24 Thread orpiske
GitHub user orpiske opened a pull request: https://github.com/apache/activemq-artemis/pull/1130 Add a MQTT interceptor example This a sample code we created in order to verify ARTEMIS-607. It adds a simple MQTT interceptor that is run whenever a MQTT message is published. I

[GitHub] activemq-artemis issue #1071: Add a test for MQTT will message with non-reta...

2017-03-09 Thread orpiske
Github user orpiske commented on the issue: https://github.com/apache/activemq-artemis/pull/1071 @clebertsuconic / @mtaylor Sure thing. That should be fine. I basically just copied the TC above this one to reproduce the issue. I will take a look and update it accordingly

[GitHub] activemq-artemis pull request #1071: Add a test for MQTT will message with n...

2017-03-09 Thread orpiske
Github user orpiske commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1071#discussion_r105194247 --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/mqtt/imported/MQTTTest.java --- @@ -1067,6

[GitHub] activemq-artemis pull request #1071: Add a test for MQTT will message with n...

2017-03-10 Thread orpiske
Github user orpiske closed the pull request at: https://github.com/apache/activemq-artemis/pull/1071 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] activemq-artemis issue #1071: Add a test for MQTT will message with non-reta...

2017-03-10 Thread orpiske
Github user orpiske commented on the issue: https://github.com/apache/activemq-artemis/pull/1071 After some discussions w/ the developers, this code does not properly reproduce the issue raised on the C code and, among other things, is wrong. Therefore, closing the PR. --- If your

[GitHub] activemq-artemis pull request #1071: Add a test for MQTT will message with n...

2017-03-08 Thread orpiske
GitHub user orpiske opened a pull request: https://github.com/apache/activemq-artemis/pull/1071 Add a test for MQTT will message with non-retain flag This patch adds a new test that verifies if the broker is able to send a will message if the retain flag is set to false. You

[GitHub] activemq-artemis pull request #1464: Implement support for intercepting addi...

2017-08-16 Thread orpiske
GitHub user orpiske opened a pull request: https://github.com/apache/activemq-artemis/pull/1464 Implement support for intercepting additional MQTT control packets Previously, only the PUBLISH packet was intercepted. This patch modifies the code to add support for the other incoming

[GitHub] activemq-artemis issue #1464: Implement support for intercepting additional ...

2017-08-16 Thread orpiske
Github user orpiske commented on the issue: https://github.com/apache/activemq-artemis/pull/1464 Some additional comments: @jbertram suggested to also look at org.apache.activemq.artemis.core.protocol.core.impl.ChannelImpl#invokeInterceptors. While I agree that it seems

[GitHub] activemq-artemis issue #1464: Implement support for intercepting additional ...

2017-08-16 Thread orpiske
Github user orpiske commented on the issue: https://github.com/apache/activemq-artemis/pull/1464 Sample output from running the modified Interceptor example: ``` server-out:MQTT Interceptor gets called server-out:A MQTT control packet was intercepted CONNACK

[GitHub] activemq-artemis pull request #1473: ARTEMIS-1291 - fix incorrect links in t...

2017-08-19 Thread orpiske
GitHub user orpiske opened a pull request: https://github.com/apache/activemq-artemis/pull/1473 ARTEMIS-1291 - fix incorrect links in the documentation Some links in the documentation point to non-existent pages within the Apache website. The links make reference to classes

[GitHub] activemq-artemis issue #1473: ARTEMIS-1291 - fix incorrect links in the docu...

2017-08-19 Thread orpiske
Github user orpiske commented on the issue: https://github.com/apache/activemq-artemis/pull/1473 For verifying this fixes, I generated the documentation. For further review, the corrected pages can be reviewed in these two links: - http://orpiske.net/files/artemis-hacking

[GitHub] activemq-artemis pull request #1473: ARTEMIS-1291 - fix incorrect links in t...

2017-08-21 Thread orpiske
Github user orpiske commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1473#discussion_r134207461 --- Diff: docs/hacking-guide/en/tests.md --- @@ -22,20 +22,20 @@ The broker is comprised of POJOs so it's simple to configure and run a broker

[GitHub] activemq-artemis issue #2015: ARTEMIS-1807 File-based Large Message encoding...

2018-04-19 Thread orpiske
Github user orpiske commented on the issue: https://github.com/apache/activemq-artemis/pull/2015 @franz1981 we can definitely work out some numbers for this! ---

[GitHub] activemq-artemis pull request #2030: Adds the Travis CI build status label o...

2018-04-19 Thread orpiske
GitHub user orpiske opened a pull request: https://github.com/apache/activemq-artemis/pull/2030 Adds the Travis CI build status label on the README Some of my colleagues suggested it would be useful to have the Travis CI build label right when accessing the project page. You can

[GitHub] activemq-artemis issue #2030: Adds the Travis CI build status label on the R...

2018-04-19 Thread orpiske
Github user orpiske commented on the issue: https://github.com/apache/activemq-artemis/pull/2030 One additional suggestion I received was to, possibly, put a label for all the active branches. Thoughts? ---

[GitHub] activemq-artemis pull request #:

2018-10-31 Thread orpiske
Github user orpiske commented on the pull request: https://github.com/apache/activemq-artemis/commit/9490e745c5431e681c768e6fdd20ed5dda0b7b95#commitcomment-31119234 @andytaylor I didn't know about that one! I think that might do the trick. We'll try and I'll close if it solves

[GitHub] activemq-artemis issue #2406: New profile to allow skipping or including the...

2018-10-31 Thread orpiske
Github user orpiske commented on the issue: https://github.com/apache/activemq-artemis/pull/2406 > how to run a single test: > > ``` > mvn -Ptests -DfailIfNoTests=false -Pextra-tests -DskipStyleCheck=true -DskipPerformanceTests=false -D

[GitHub] activemq-artemis pull request #2406: New profile to allow skipping or includ...

2018-10-31 Thread orpiske
Github user orpiske closed the pull request at: https://github.com/apache/activemq-artemis/pull/2406 ---

[GitHub] activemq-artemis issue #2407: openWire would allow one extra send

2018-10-31 Thread orpiske
Github user orpiske commented on the issue: https://github.com/apache/activemq-artemis/pull/2407 Looking at the test, I think it correctly reproduces the problem we were seeing. Thanks for the quick fix! ---

[GitHub] activemq-artemis issue #2406: New profile to allow skipping or including the...

2018-10-31 Thread orpiske
Github user orpiske commented on the issue: https://github.com/apache/activemq-artemis/pull/2406 We have tried the proposed approach and it did not skip the integration tests. We received a suggestion from @andytaylor to use "-PDev" in addition to that. Any solution

[GitHub] activemq-artemis pull request #2406: New profile to allow skipping or includ...

2018-10-31 Thread orpiske
GitHub user orpiske opened a pull request: https://github.com/apache/activemq-artemis/pull/2406 New profile to allow skipping or including the execution of integration tests This comes as request from our team. They would like to be able to skip and/or include the execution