GitHub user priyankpande9 opened a pull request: https://github.com/apache/activemq/pull/205
Master Learning You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/activemq master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq/pull/205.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #205 ---- commit ff99872263981982bb1ebce93c07bfb8a28d4a06 Author: Timothy Bish <tabish...@gmail.com> Date: 2016-05-13T15:13:11Z https://issues.apache.org/jira/browse/AMQ-6209 Better management of shared resources between the background run thread and the main start / stop thread. Makes sure to cleanup all resources before finally throwing on stop to prevent leaking and resources. commit cc849e74406e6fdc410aac862bd615b9a321bb7f Author: Timothy Bish <tabish...@gmail.com> Date: 2016-05-13T15:31:15Z https://issues.apache.org/jira/browse/AMQ-6291 Simplify the selector close in doStop, the run method no longer tries to close this after it has been registered and assigned. commit b9334960e06f48454305fc60732b683347d4aaed Author: Timothy Bish <tabish...@gmail.com> Date: 2016-05-13T16:50:13Z Add some additional time to the wait for completion assert. On a sufficiently loaded system 30s is not quite enough. This is reproducable if run while a heavily I/O based application is also running in the background. commit 15405af2e6c44037ce09e616bdfe79852c19647a Author: Timothy Bish <tabish...@gmail.com> Date: 2016-05-13T18:56:01Z https://issues.apache.org/jira/browse/AMQ-6292 allow for batch writes of forwarded acks. commit ab434ee776bda7afeb6c1ae26f66559940afbf6d Author: Timothy Bish <tabish...@gmail.com> Date: 2016-05-13T22:30:44Z Refactor test which has some flawed assumptions about the incoming messages based on subscriptions that it makes. Adds better thread safety as well. commit 1241e4120a5f4af58be2952a6ec985dcd8ac11c3 Author: Christopher L. Shannon (cshannon) <christopher.l.shan...@gmail.com> Date: 2016-05-14T15:30:28Z https://issues.apache.org/jira/browse/AMQ-6293 Fixing Queue destination statistics in dropMessage by adding sync in between the check for dropped and actually dropping the message plus fixing dequeue stats so messages aren't counted twice commit a2720c46530a4e82907888bb0c33c2e41c6565e4 Author: Timothy Bish <tabish...@gmail.com> Date: 2016-05-16T15:02:20Z https://issues.apache.org/jira/browse/AMQ-6293 Clean up the test, the times were causing CI failure. Turn off persistence and fix a couple other things, reduced time to 2.5 secs while still reproducing with fix removed. commit d9c404829298f1a8c67a6d7a732d8e687268b014 Author: Timothy Bish <tabish...@gmail.com> Date: 2016-05-16T15:24:50Z Clean up and adjust test timeouts for CI commit 2a10e9900a5f8a48eafc15f6820476f76499a70b Author: Timothy Bish <tabish...@gmail.com> Date: 2016-05-16T17:58:14Z https://issues.apache.org/jira/browse/AMQ-5621 Add some additional test cleanup commit 1263dd8c4343fbe9412b377e10d84109e230fd5c Author: Timothy Bish <tabish...@gmail.com> Date: 2016-05-17T13:59:35Z Fix failing test in CI. Subscribe should request receipts so that the subscription exists prior to initiating the event that triggers the advisory message sent to the Topic. commit 2c3046b81616c52be5e5d45f99ee7e648d6939a4 Author: Timothy Bish <tabish...@gmail.com> Date: 2016-05-17T17:00:56Z Fix test timing out on slow spinning disks. On a local drive with heave I/O this test took over 2.5 minutes to complete, CI machines can see similar times, bumped timeout to 5 minutes to account for this range. commit c2230fda4bd8eed7bba3245ad4b11fcd8e3bd581 Author: gtully <gary.tu...@gmail.com> Date: 2016-05-17T16:03:05Z https://issues.apache.org/jira/browse/AMQ-6286 - refine fix to distinguish multiple consumers in a transaction, verify insertion at head will preserve order commit 0883011147d80e1804b1738d2a56294a97ee1b38 Author: Timothy Bish <tabish...@gmail.com> Date: 2016-05-18T15:02:14Z Fix data dir path change that shouldn't have been committed with the other fixes. commit 8b7632cb4f6aaa0d7d7c2febab5e60b6abcf3dff Author: Seth Leger <s...@opennms.org> Date: 2016-05-20T08:57:51Z AMQ-6298: Moved Spring Import-Package wildcard below other Spring imports. commit 53a9080c27d229b57b48292058f93cbdc1e7afe3 Author: vivek-dhayalan <dvvi...@gmail.com> Date: 2016-04-21T13:13:07Z Updating help text properly commit 991d69f3879f1c206c5fda537920eed569db9b38 Author: sprgn <git...@filatov.us> Date: 2016-04-20T22:12:06Z Fix error message typo. Fix typo from javax.jmx.ConnectionFactory to javax.jms.ConnectionFactory commit daf7e85e68e2403bc9e86948ae38adaa3e55ad69 Author: gtully <gary.tu...@gmail.com> Date: 2016-05-20T13:54:04Z https://issues.apache.org/jira/browse/AMQ-6297 - null check for case where interface has no bindings commit 5cc5022d2a2da6e2add8de5c1576a28e97006e87 Author: gtully <gary.tu...@gmail.com> Date: 2016-05-20T14:33:33Z https://issues.apache.org/jira/browse/AMQ-6297 - displayName can also be null - thanks tbish commit 7c04aa9909ab123332102a6ef86547a166cb51ca Author: gtully <gary.tu...@gmail.com> Date: 2016-05-20T14:37:24Z reduce test message size and quantity for ci commit b1d8e66eafe522fce44ba7fb86865d9102541222 Author: Timothy Bish <tabish...@gmail.com> Date: 2016-05-20T22:52:27Z https://issues.apache.org/jira/browse/AMQ-6299 Update commons deps to latest patch versions. commit b4e35fe8a355c0fd5fe8935ab583e2886121946b Author: gtully <gary.tu...@gmail.com> Date: 2016-05-23T12:29:25Z AMQ-4181 - revert mod to testQueueBrowserWith2ConsumersInterleaved which cause intermittent ci failure - browse is a snapshot at time of creation. tidy up some gaps in pagein logic sync commit 4d6cc4b46007c7bcec10ade080e822d83261273f Author: Christopher L. Shannon (cshannon) <christopher.l.shan...@gmail.com> Date: 2016-05-23T18:09:01Z https://issues.apache.org/jira/browse/AMQ-6303 Properly setting typeCode value for new journal files used for ack compaction commit f46b2927a4fcbd52fd4d80a7908f7f59428079ae Author: gtully <gary.tu...@gmail.com> Date: 2016-05-24T09:47:34Z fix intermittent ci failure - ensure no expiry before first dispatch commit fe9d99e7a071c4c09c78dfd95630036b86a8a05b Author: gtully <gary.tu...@gmail.com> Date: 2016-05-25T10:24:43Z AMQ-3166 - implement rollbackOnlyOnAsyncException such that async exceptions on transactional sends or acks result in the transaction being marked rollback only and commit failing with an exception. Test that shows current state of play using alwaySendSync or AsyncCallback. rollbackOnlyOnAsyncException enabled by default. commit 281fbb1f9d7e329fd36556df6c0ea23a8bbea683 Author: gtully <gary.tu...@gmail.com> Date: 2016-05-25T11:34:07Z tidy up close for vm broker - seems ci failure of InMemeoryJmsSchedulerTest is related to overlap between tests of vm transport commit e467f34cc1add0dba8f669aa49f1905245266b7c Author: gtully <gary.tu...@gmail.com> Date: 2016-05-25T11:45:07Z longer receive timeout on first message, intermittent ci failure commit 3b626c9edc4525ef5bd13e041cc41f734ddd4abe Author: gtully <gary.tu...@gmail.com> Date: 2016-05-25T11:51:56Z resolve intermittent failure - if broker closes socket on security excepiton before client gets response commit 0757cdcd596f1fd90c4c2e10a7e0f9b215ba7db6 Author: Timothy Bish <tabish...@gmail.com> Date: 2016-05-25T16:15:21Z Cleanup the tearDown method to ensure we follow on to the super tearDown where the broker is stopped. commit 62ab55683f6fcb5942af43b84ebeb0365699dd2a Author: gtully <gary.tu...@gmail.com> Date: 2016-05-26T10:29:34Z increase the lease to allow kahadb recovery, ci intermittent failure commit 29b833fe8ed87141e4a5870fe3c2377f5107437f Author: gtully <gary.tu...@gmail.com> Date: 2016-05-26T10:30:14Z fix shadowing and ensure close of connection, ci... ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---