[GitHub] activemq-artemis pull request #1742: ARTEMIS-1570 Flush appendExecutor befor...

2017-12-26 Thread shoukunhuai
GitHub user shoukunhuai opened a pull request: https://github.com/apache/activemq-artemis/pull/1742 ARTEMIS-1570 Flush appendExecutor before take journal snapshot When live start replication, it must make sure there is no pending write in message & bindings journal, or we

[GitHub] activemq-artemis issue #1742: ARTEMIS-1570 Flush appendExecutor before take ...

2017-12-27 Thread shoukunhuai
Github user shoukunhuai commented on the issue: https://github.com/apache/activemq-artemis/pull/1742 @clebertsuconic That will be great if we can avoid wait. Please do not merge, i will push my test. ---

[GitHub] activemq-artemis issue #1742: ARTEMIS-1570 Flush appendExecutor before take ...

2017-12-27 Thread shoukunhuai
Github user shoukunhuai commented on the issue: https://github.com/apache/activemq-artemis/pull/1742 @clebertsuconic just pushed my test for your reference. ---

[GitHub] activemq-artemis pull request #1747: [WIP] NO-JIRA DISCUSS Replica use opera...

2018-01-03 Thread shoukunhuai
GitHub user shoukunhuai opened a pull request: https://github.com/apache/activemq-artemis/pull/1747 [WIP] NO-JIRA DISCUSS Replica use operationcontext This PR is used to discuss using `OperationContext` on backup side. The original implementation of `ReplicationEndpoint

[GitHub] activemq-artemis issue #1747: [WIP] NO-JIRA DISCUSS Replica use operationcon...

2018-01-03 Thread shoukunhuai
Github user shoukunhuai commented on the issue: https://github.com/apache/activemq-artemis/pull/1747 @michaelandrepearce we want the guarantee that when we response to client, any journal is wrote to both live and backup. Say we set both syncNonTransactional and

[GitHub] activemq-artemis pull request #1747: [WIP] NO-JIRA DISCUSS Replica use opera...

2018-01-11 Thread shoukunhuai
Github user shoukunhuai closed the pull request at: https://github.com/apache/activemq-artemis/pull/1747 ---

[GitHub] activemq-artemis issue #1747: [WIP] NO-JIRA DISCUSS Replica use operationcon...

2018-01-11 Thread shoukunhuai
Github user shoukunhuai commented on the issue: https://github.com/apache/activemq-artemis/pull/1747 @jbertram sure, i will close it, and thanks all. ---

[GitHub] activemq-artemis issue #1742: ARTEMIS-1570 Flush appendExecutor before take ...

2018-01-24 Thread shoukunhuai
Github user shoukunhuai commented on the issue: https://github.com/apache/activemq-artemis/pull/1742 @clebertsuconic sorry, almost forgot this, being busy on something else. Looks like this issue was resolved? ---

[GitHub] activemq-artemis pull request #1827: Improve paged message acknowledge

2018-01-30 Thread shoukunhuai
GitHub user shoukunhuai opened a pull request: https://github.com/apache/activemq-artemis/pull/1827 Improve paged message acknowledge Cache `messageID`, `transactionID` and `isLargeMessage` in PagedReference, so that when acknowledge, we do not have to get

[GitHub] activemq-artemis pull request #1827: Improve paged message acknowledge

2018-01-31 Thread shoukunhuai
Github user shoukunhuai commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1827#discussion_r165050956 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/RefsOperation.java --- @@ -152,14 +153,14 @@ protected

[GitHub] activemq-artemis pull request #1827: Improve paged message acknowledge

2018-02-01 Thread shoukunhuai
Github user shoukunhuai commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1827#discussion_r165284853 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/MessageReference.java --- @@ -38,6 +38,10 @@ public static

[GitHub] activemq-artemis pull request #1827: ARTEMIS-1650 Improve paged message ackn...

2018-02-01 Thread shoukunhuai
Github user shoukunhuai commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1827#discussion_r16574 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/RefsOperation.java --- @@ -152,14 +153,14 @@ protected

[GitHub] activemq-artemis pull request #1827: ARTEMIS-1650 Improve paged message ackn...

2018-02-05 Thread shoukunhuai
Github user shoukunhuai commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1827#discussion_r165955062 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/MessageReference.java --- @@ -38,6 +38,10 @@ public static

[GitHub] activemq-artemis pull request #1827: ARTEMIS-1650 Improve paged message ackn...

2018-02-05 Thread shoukunhuai
Github user shoukunhuai commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1827#discussion_r165955807 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/RefsOperation.java --- @@ -152,14 +153,14 @@ protected

[GitHub] activemq-artemis pull request #1894: ARTEMIS-1700 Fixed deadlock in paging s...

2018-02-23 Thread shoukunhuai
Github user shoukunhuai commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1894#discussion_r170405082 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/AbstractJournalStorageManager.java

[GitHub] activemq-artemis pull request #1894: ARTEMIS-1700 Fixed deadlock in paging s...

2018-02-23 Thread shoukunhuai
Github user shoukunhuai commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1894#discussion_r170405300 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/AbstractJournalStorageManager.java

[GitHub] activemq-artemis pull request #1894: ARTEMIS-1700 Fixed deadlock in paging s...

2018-02-23 Thread shoukunhuai
Github user shoukunhuai commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1894#discussion_r170405747 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/AbstractJournalStorageManager.java

[GitHub] activemq-artemis pull request #1894: ARTEMIS-1700 Fixed deadlock in paging s...

2018-02-23 Thread shoukunhuai
Github user shoukunhuai commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1894#discussion_r170407785 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/AbstractJournalStorageManager.java

[GitHub] activemq-artemis issue #1899: ARTEMIS-1700 Fixed deadlock in paging state

2018-02-26 Thread shoukunhuai
Github user shoukunhuai commented on the issue: https://github.com/apache/activemq-artemis/pull/1899 So it is a mistake to use global thread pool instead of io thread pool for page cursor. But this does not fix our problem, as you can see ``` "Thread-2

[GitHub] activemq-artemis pull request #1929: ARTEMIS-1728 Reclaim memory when page c...

2018-03-05 Thread shoukunhuai
GitHub user shoukunhuai opened a pull request: https://github.com/apache/activemq-artemis/pull/1929 ARTEMIS-1728 Reclaim memory when page cursor complete Free hash set used to hold page position for acks and removed refs. The two set is cleared, but they still hold a big array