[GitHub] activemq-artemis issue #1452: ARTEMIS-1335 Update Netty to 4.1.14

2017-08-09 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1452 Ok so happy we merge this, then, i assume. With he jproton and qpid-jms bits merged already, i would be keen for this to make it in, before tagging of 2.3.0. --- If your

[GitHub] activemq-artemis issue #1452: ARTEMIS-1335 Update Netty to 4.1.14

2017-08-09 Thread franz1981
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/1452 You did already good :) I was talking about my previous work on that class --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] activemq-artemis issue #1452: ARTEMIS-1335 Update Netty to 4.1.14

2017-08-09 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1452 Or do you mean should we make it a static method and then invoke that? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] activemq-artemis issue #1452: ARTEMIS-1335 Update Netty to 4.1.14

2017-08-09 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1452 @franz1981 it is just copy paste of the code that was in the util in previous version before it was removed so code length is the same --- If your project is set up for it,

[GitHub] activemq-artemis issue #1452: ARTEMIS-1335 Update Netty to 4.1.14

2017-08-09 Thread franz1981
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/1452 Seems ok to me! Looking at the code I've written some time ago I probably need to check if every method is inlined or not...some methods look very long!!! --- If your project is set up

[GitHub] activemq-artemis issue #1452: ARTEMIS-1335 Update Netty to 4.1.14

2017-08-09 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1452 @clebertsuconic this is ready. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have