[GitHub] activemq-artemis issue #1455: ARTEMIS-1335 Update Netty to 4.1.14 - MQTT fix
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1455 @mtaylor it would have been fine if weren't for a bug in their code change to keep the deprecated method. Would have been easier to spot if they just removed the method because then would have been compile time. Hey ho. We're now using the new methods :) and we save a byte[] to string to byte[] skip and a jump now so that's good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis issue #1455: ARTEMIS-1335 Update Netty to 4.1.14 - MQTT fix
Github user mtaylor commented on the issue: https://github.com/apache/activemq-artemis/pull/1455 @michaelandrepearce Thanks for this. I actually raised the String usage for the APIs with the Netty guys. That was a couple versions ago, looks like we got caught out during the upgrade. Cheers. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis issue #1455: ARTEMIS-1335 Update Netty to 4.1.14 - MQTT fix
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1455 build box still has perm issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis issue #1455: ARTEMIS-1335 Update Netty to 4.1.14 - MQTT fix
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1455 @clebertsuconic @mtaylor found the problem in MQTT when upgrade of Netty and fixed it, and sorted it. If you could merge/validate. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
