Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1777
Great thanks, ill merge then.
---
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/1777
These are the flamegraph of a couple of profiled tests, one on master:
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/1777
@michaelandrepearce I'm running a test before and after, but first can you
try add ".jvmArgs("-XX:+UseG1GC")" and `.forks(2)` to your benchmark?
---
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1777
@franz1981 i was waiting on you, to give a thumbs up before i merged, is
that a thumbs up?
---
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/1777
Very good results! A lil OT but seems that we really start need a JMH
folder with all the benchs on Artemis eh? :P
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1777
Thanks, @michaelandrepearce. Nice results!
---
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1777
Sure, using JMH to measure performance of the two AddressInfo
Implementations.
BenchmarkMode Cnt ScoreError
Units
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1777
Any metrics to quantify the benefit and justify this change?
---
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/1777
This looks good to me too
---
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/1777
@michaelandrepearce I'm looking at it locally right now :+1:
---
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1777
@franz1981 you happy for this to merge?
---
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/1777
@michaelandrepearce
Looking at the changes via Github it seems clean and effective and I admit
I'm a fan of using the "right" collection when needed, but I want to use some
time
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1777
@franz1981 ping.
---
13 matches
Mail list logo
