[GitHub] activemq-artemis issue #1832: ARTEMIS-853 Support for exclusive consumers

[michaelandrepearce]

Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/1832
  
We do the same as if message group which doesn’t increase the pos if 
it’s exclusive just like it doesn’t if exclusive.

We can enhance this if needed. Ping me on IRC tomorrow? happy to make 
further enhancements if needed.


---

[GitHub] activemq-artemis issue #1832: ARTEMIS-853 Support for exclusive consumers

[clebertsuconic]

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1832
  
@michaelandrepearce  I think the logic should have been updated on 
QueueImpl for the exclusive consumer...


You should just had the pos always 0. or have a different logic without 
using counters at all. 

The code became non consistent. the pos increases but then there is a 
statement to always get position 0 if exclusive.


---

[GitHub] activemq-artemis issue #1832: ARTEMIS-853 Support for exclusive consumers

[franz1981]

Github user franz1981 commented on the issue:

https://github.com/apache/activemq-artemis/pull/1832
  
@michaelandrepearce i don't have the chance to merge it yet :(
Anyway it seems that there aren't any objections so I suppose it is ok 👍 


---

[GitHub] activemq-artemis issue #1832: ARTEMIS-853 Support for exclusive consumers

[michaelandrepearce]

Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/1832
  
@franz1981 seems no objections, you still ok to merge?


---

[GitHub] activemq-artemis issue #1832: ARTEMIS-853 Support for exclusive consumers

[franz1981]

Github user franz1981 commented on the issue:

https://github.com/apache/activemq-artemis/pull/1832
  
@michaelandrepearce @gtully @mtaylor If everything is fine I will going to 
merge it, ok? 


---

[GitHub] activemq-artemis issue #1832: ARTEMIS-853 Support for exclusive consumers

[michaelandrepearce]

Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/1832
  
@gtully you happy if this is merged? Just waiting on this before I continue 
with the other bits as mentioned


---

[GitHub] activemq-artemis issue #1832: ARTEMIS-853 Support for exclusive consumers

[mtaylor]

Github user mtaylor commented on the issue:

https://github.com/apache/activemq-artemis/pull/1832
  
@michaelandrepearce Hey Michael.  I think this was a temp failure.  There 
is an Artemis PR job running now that doesn't show the git clone problem.  The 
CI is shared and there are a bunch of jobs queued so we might have to wait a 
while to run again.


---

[GitHub] activemq-artemis issue #1832: ARTEMIS-853 Support for exclusive consumers

[michaelandrepearce]

Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/1832
  
@gtully yes there is a use case for the client part here in our org, thus 
why. I'd rather do this fully, than partial. 

@mtaylor or anyone with access, can someone look at the build system, ive 
tried 10 times, and keep getting build fails with the below which seems infra 
related.

ERROR: Error fetching remote repo 'origin'
hudson.plugins.git.GitException: Failed to fetch from 
git://github.com/apache/activemq-artemis.git




---

[GitHub] activemq-artemis issue #1832: ARTEMIS-853 Support for exclusive consumers

[gtully]

Github user gtully commented on the issue:

https://github.com/apache/activemq-artemis/pull/1832
  
@michaelandrepearce to make the feature work is trivial in queueimpl; to 
make it dynamic is a lot of code.
I would have been shooting for an address setting and pulling that value in 
queueImpl on creation. An all or nothing approach.
But what you have is very comprehensive :-) I just wonder if there really 
is a need to have the consumer create an lvq or exclusive queue. If there is, 
then this nails it.
For an existing openwire client the value can come from a consumer info or 
from a destination parameter but mostly it is the effect that is needed, not 
the fact that it is dynamic, ie: Because it effects every consumer having a 
single consumer control it is a bit imbalanced and not typical I think.



---

[GitHub] activemq-artemis issue #1832: ARTEMIS-853 Support for exclusive consumers

[michaelandrepearce]

Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/1832
  
@gtully ping.


---