[GitHub] activemq-artemis issue #1835: ARTEMIS-1651 Allow custom etc and data directo...

2018-02-13 Thread dejanb 
Github user dejanb commented on the issue:

https://github.com/apache/activemq-artemis/pull/1835
  
@jbertram done!


---

[GitHub] activemq-artemis issue #1835: ARTEMIS-1651 Allow custom etc and data directo...

2018-02-13 Thread jbertram 
Github user jbertram commented on the issue:

https://github.com/apache/activemq-artemis/pull/1835
  
Can you squash these commits, @dejanb?


---

[GitHub] activemq-artemis issue #1835: ARTEMIS-1651 Allow custom etc and data directo...

2018-02-01 Thread dejanb 
Github user dejanb commented on the issue:

https://github.com/apache/activemq-artemis/pull/1835
  
@jbertram yeah, I need to recheck all tests. Thanks!


---

[GitHub] activemq-artemis issue #1835: ARTEMIS-1651 Allow custom etc and data directo...

2018-02-01 Thread jbertram 
Github user jbertram commented on the issue:

https://github.com/apache/activemq-artemis/pull/1835
  
I checked out your branch, and I still see the failures.  Does everything 
in org.apache.activemq.cli.test.ArtemisTest pass for you?


---

[GitHub] activemq-artemis issue #1835: ARTEMIS-1651 Allow custom etc and data directo...

2018-02-01 Thread dejanb 
Github user dejanb commented on the issue:

https://github.com/apache/activemq-artemis/pull/1835
  
@jbertram Thanks. I forgot to update the test. Can you give a test now?


---

[GitHub] activemq-artemis issue #1835: ARTEMIS-1651 Allow custom etc and data directo...

2018-02-01 Thread jbertram 
Github user jbertram commented on the issue:

https://github.com/apache/activemq-artemis/pull/1835
  
PR build failures look legitimate to me.  I reproduced them locally.


---