Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/1918
I'm closing this one and helping @tabish121 to validate
https://github.com/apache/activemq-artemis/pull/1928, that is 100% the best
approach, because it avoid completly the copy in the
Github user tabish121 commented on the issue:
https://github.com/apache/activemq-artemis/pull/1918
@franz1981 @clebertsuconic I've sent an alternate PR #1928 which performs
the send without any buffer copy unless necessary due to message redelivery or
existence of original delivery
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/1918
@clebertsuconic
> SoftReference sucks. It usually let you OME before itâs released.
I know and i was too hurried to say that it could be used :P you're right
:+1:
Github user tabish121 commented on the issue:
https://github.com/apache/activemq-artemis/pull/1918
@franz1981 It doesn't look like the buffer could be contended unless
perhaps the consumer was able to be subscribed to more than one queue at a time
via some sort of composite type
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1918
SoftReference sucks. It usually let you OME before itâs released.
What about having a pool somewhere else? Or a smaller pool from Netty?
Iâm out
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/1918
@clebertsuconic Yep , don't worry I'm glad that you have taken a look on
it! Will answer inline..
> i - There's a buffer sitting on the ProtonSenderContext now that may be
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1918
I won't be able to look into this before Tuesday.. Please don't merge this
without me... :)
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1918
I see two problems here..
i - There's a buffer sitting on the ProtonSenderContext now that may be
unused for a while. What if you had 1000 connections at one time.. and
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/1918
This one, together with
https://github.com/apache/activemq-artemis/pull/1916 aims to reduce the memoty
footprint (improving scalability by different angles) of AMQP on the broker.
I
