[GitHub] activemq-artemis issue #1950: ARTEMIS-1732 AMQP anonymous producer not block...
Github user gaohoward commented on the issue: https://github.com/apache/activemq-artemis/pull/1950 I think it's ok. ---
[GitHub] activemq-artemis issue #1950: ARTEMIS-1732 AMQP anonymous producer not block...
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1950 @michaelandrepearce @gaohoward merged with an additional fix. if there's any change you like I can add an additional PR. if you could review please? ---
[GitHub] activemq-artemis issue #1950: ARTEMIS-1732 AMQP anonymous producer not block...
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1950 Actually the test is very nice.. I'm doing some refactoring on this. ---
[GitHub] activemq-artemis issue #1950: ARTEMIS-1732 AMQP anonymous producer not block...
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1950 The test added is also wrong.. a sender should block while there are no credits instead of holding runnables on the server. ---
[GitHub] activemq-artemis issue #1950: ARTEMIS-1732 AMQP anonymous producer not block...
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1950 This needs some work on the model before it can be merged. ---
[GitHub] activemq-artemis issue #1950: ARTEMIS-1732 AMQP anonymous producer not block...
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1950 @clebertsuconic Whats occuring on this one? We safe to merge this to master now? ---
[GitHub] activemq-artemis issue #1950: ARTEMIS-1732 AMQP anonymous producer not block...
Github user gaohoward commented on the issue: https://github.com/apache/activemq-artemis/pull/1950 ok ---
[GitHub] activemq-artemis issue #1950: ARTEMIS-1732 AMQP anonymous producer not block...
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1950 We will have a 2.5.1 shortly ---
[GitHub] activemq-artemis issue #1950: ARTEMIS-1732 AMQP anonymous producer not block...
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1950 Lets leave this out of the release... please don't merge this!!! I will get back to this after the release. ---
[GitHub] activemq-artemis issue #1950: ARTEMIS-1732 AMQP anonymous producer not block...
Github user gaohoward commented on the issue: https://github.com/apache/activemq-artemis/pull/1950 @clebertsuconic thanks. ---
[GitHub] activemq-artemis issue #1950: ARTEMIS-1732 AMQP anonymous producer not block...
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1950 this is not complete. if your disk is full... and no more producing is happening you will never release the executables. Besides.. I will look if there is a way to use the PagingStoreManager to do this, or to avoid the duplicate code... (which would fix the issue I mentioned) ---
