[GitHub] activemq-artemis issue #1994: ARTEMIS-1787 Openwire message should not conta...

2018-05-09 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/1994
  
So issue i see here, is on the noLocal the internal property will still be 
present on noLocal, so if the argument is that including it breaks spec, then 
surely it still breaks spec even for noLocal as it would be included there 
still. 


---


[GitHub] activemq-artemis issue #1994: ARTEMIS-1787 Openwire message should not conta...

2018-04-09 Thread stanlyDoge
Github user stanlyDoge commented on the issue:

https://github.com/apache/activemq-artemis/pull/1994
  
This PR is partly reverting 
https://github.com/apache/activemq-artemis/pull/1734

AFAIK including some internal properties break JMS API specification.



---


[GitHub] activemq-artemis issue #1994: ARTEMIS-1787 Openwire message should not conta...

2018-04-06 Thread clebertsuconic
Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1994
  
same thing I asked on the JIRA. Why it shouldn't? why only on noLocal?

trying to get some context on the why it should not be included...


it would be nice to include such thing on the commit description please.


---