[GitHub] activemq-artemis issue #1997: ARTEMIS-1653 Allow database tables to be creat...

[mtaylor]

Github user mtaylor commented on the issue:

https://github.com/apache/activemq-artemis/pull/1997
  
+1 Franz.

On Tue, 17 Apr 2018, 07:27 nlippke,  wrote:

> @franz1981  I totally agree. Broker should
> not run any DDL-Statements if tables are managed by a DBA.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> 
,
> or mute the thread
> 

> .
>



---

[GitHub] activemq-artemis issue #1997: ARTEMIS-1653 Allow database tables to be creat...

[franz1981]

Github user franz1981 commented on the issue:

https://github.com/apache/activemq-artemis/pull/1997
  
@nlippke @mtaylor I have updated this PR to avoid issues with concurrent 
creations of tables/indexes for the JDBC Journal with Oracle (there is a test 
attached): when a table seems to exists both CREATE TABLE and CREATE INDEX 
statements are no longer used to initialize it.
That is useful to allow a shared store to concurrently start 2 journals on 
the same database and while rebooting the broker with an empty journal (table 
already existent, but empty ie no need to create index twice).
That means that a DBA should take care to create table and indexes (if 
any), but if it will just create tables, the broker won't create any index on 
them, wdyt?


---

[GitHub] activemq-artemis issue #1997: ARTEMIS-1653 Allow database tables to be creat...

[nlippke]

Github user nlippke commented on the issue:

https://github.com/apache/activemq-artemis/pull/1997
  
👍 


---

[GitHub] activemq-artemis issue #1997: ARTEMIS-1653 Allow database tables to be creat...

[franz1981]

Github user franz1981 commented on the issue:

https://github.com/apache/activemq-artemis/pull/1997
  
@clebertsuconic @nlippke I know that the failing COUNT sounds weird, but it 
is quite simple to be reproduced with DB2 through the test attached :+1: 


---