[GitHub] activemq-artemis issue #2023: ARTEMIS-857 Add JMX endpoints to view and rese...

[michaelandrepearce]

Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/2023
  
Test case added to QueueControlTest


---

[GitHub] activemq-artemis issue #2023: ARTEMIS-857 Add JMX endpoints to view and rese...

[michaelandrepearce]

Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/2023
  
At the core layer it’s called group eg that’s the name within core 
message, and other settings around this. 

I’ll add test though.


---

[GitHub] activemq-artemis issue #2023: ARTEMIS-857 Add JMX endpoints to view and rese...

[gaohoward]

Github user gaohoward commented on the issue:

https://github.com/apache/activemq-artemis/pull/2023
  
@michaelandrepearce The code is fine I think. It'll be nice you add some 
unittests (e.g. in QueueControlTest) to verify it works. Also I find that the 
"Group" in method names a bit confusing.
Would be using MessageGoup instead more clear? I'm not sure about that as 
I'm not a native speaker, just a personal opinion.


---

[GitHub] activemq-artemis issue #2023: ARTEMIS-857 Add JMX endpoints to view and rese...

[michaelandrepearce]

Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/2023
  
Just working through the low hanging fruit thats needed to unblock artemis 
to become activemq 6.
as per:
http://activemq.apache.org/activemq-artemis-roadmap.html


---