[GitHub] activemq-artemis issue #2133: ARTEMIS-1923 fix constructing binding journali...

2018-06-12 Thread clebertsuconic 
Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/2133
  
I will ammend the commit with a test


---

[GitHub] activemq-artemis issue #2133: ARTEMIS-1923 fix constructing binding journali...

2018-06-11 Thread jbertram 
Github user jbertram commented on the issue:

https://github.com/apache/activemq-artemis/pull/2133
  
A test here would be useful.  Even something as simple as adding some 
getters and verifying the properties are set as expected would work, I think.


---