[GitHub] activemq-artemis issue #2199: ARTEMIS-1996 MappedSequentialFileFactory may c...

2018-12-18 Thread jbertram
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/2199 IMO this PR should be closed based on the commits from #2250. @morefuntang, can you close it? ---

[GitHub] activemq-artemis issue #2199: ARTEMIS-1996 MappedSequentialFileFactory may c...

2018-10-22 Thread franz1981
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/2199 @morefuntang Please check if master has fixed your issue with GC and close this one: it has been addressed on https://github.com/apache/activemq-artemis/pull/2250 With it there

[GitHub] activemq-artemis issue #2199: ARTEMIS-1996 MappedSequentialFileFactory may c...

2018-08-15 Thread franz1981
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/2199 @michaelandrepearce I have near finished :) The thing is that I have introduced a small API change on SequentialFile that I'm not very happy with ---

[GitHub] activemq-artemis issue #2199: ARTEMIS-1996 MappedSequentialFileFactory may c...

2018-08-14 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/2199 @franz1981 how long do you need to do 1 and 2? ---

[GitHub] activemq-artemis issue #2199: ARTEMIS-1996 MappedSequentialFileFactory may c...

2018-08-14 Thread franz1981
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/2199 @michaelandrepearce @morefuntang I have just verified that the fix I have done is not complete yet; there are indeed 3 points where native allocations are performed: 1.

[GitHub] activemq-artemis issue #2199: ARTEMIS-1996 MappedSequentialFileFactory may c...

2018-08-13 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/2199 @franz1981 are you providing an alternative fix? If not why not lets merge this and later you can provide an alternative to replace this solution? ---

[GitHub] activemq-artemis issue #2199: ARTEMIS-1996 MappedSequentialFileFactory may c...

2018-08-10 Thread franz1981
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/2199 @michaelandrepearce good point! I will need to modify it because my solution do not create any ByteBuffer at all (or will dispose it immediately with Asyncio) and the test proposed

[GitHub] activemq-artemis issue #2199: ARTEMIS-1996 MappedSequentialFileFactory may c...

2018-08-10 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/2199 @franz1981 , @morefuntang provided a testcase to reproduce the issue, i note on your branch you havent copied the test, to prove your alternative change also would fix the

[GitHub] activemq-artemis issue #2199: ARTEMIS-1996 MappedSequentialFileFactory may c...

2018-08-10 Thread franz1981
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/2199 @clebertsuconic I think that using a near-to-deprecation feature to solve the issue can be avoided: https://github.com/franz1981/activemq-artemis/tree/mmap_ro_2_read_journal It is a

[GitHub] activemq-artemis issue #2199: ARTEMIS-1996 MappedSequentialFileFactory may c...

2018-08-09 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2199 @morefuntang / @franz1981 what's the status here? ---