[GitHub] activemq-artemis issue #2237: [ARTEMIS-2022] Create count messages 'group by...

2018-08-13 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/2237
  
Not atm afaik, as efforts are for bug fix release atm.


---


[GitHub] activemq-artemis issue #2237: [ARTEMIS-2022] Create count messages 'group by...

2018-08-13 Thread ArthurFritz
Github user ArthurFritz commented on the issue:

https://github.com/apache/activemq-artemis/pull/2237
  
Cool, is there an expected date for 2.7.0?


---


[GitHub] activemq-artemis issue #2237: [ARTEMIS-2022] Create count messages 'group by...

2018-08-13 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/2237
  
This is a feature not a bug fix, 2.6.3 is a bug fix release only. This 
would be in next feature release 2.7.0


---


[GitHub] activemq-artemis issue #2237: [ARTEMIS-2022] Create count messages 'group by...

2018-08-13 Thread ArthurFritz
Github user ArthurFritz commented on the issue:

https://github.com/apache/activemq-artemis/pull/2237
  
@michaelandrepearce You're welcome.
Would you know the expected date of version 2.6.3 ?


---


[GitHub] activemq-artemis issue #2237: [ARTEMIS-2022] Create count messages 'group by...

2018-08-13 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/2237
  
@ArthurFritz thanks for the contribution :) 


---


[GitHub] activemq-artemis issue #2237: [ARTEMIS-2022] Create count messages 'group by...

2018-08-13 Thread ArthurFritz
Github user ArthurFritz commented on the issue:

https://github.com/apache/activemq-artemis/pull/2237
  
Ok, thanks.


---


[GitHub] activemq-artemis issue #2237: [ARTEMIS-2022] Create count messages 'group by...

2018-08-13 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/2237
  
@ArthurFritz as your branch just had the changes i suggested, but also an 
additonal but un-needed extra merge commit, i merged from the branch i had of 
yours, https://github.com/apache/activemq-artemis/pull/2243.

Could you close this?


---


[GitHub] activemq-artemis issue #2237: [ARTEMIS-2022] Create count messages 'group by...

2018-08-11 Thread ArthurFritz
Github user ArthurFritz commented on the issue:

https://github.com/apache/activemq-artemis/pull/2237
  
Ok, nice idea include filter, and selector to group messages.


---


[GitHub] activemq-artemis issue #2237: [ARTEMIS-2022] Create count messages 'group by...

2018-08-10 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/2237
  
@ArthurFritz i sent your branch a PR with a number of improvements on this, 
see here: https://github.com/ArthurFritz/activemq-artemis/pull/1


---


[GitHub] activemq-artemis issue #2237: [ARTEMIS-2022] Create count messages 'group by...

2018-08-10 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/2237
  
This should probably filter using the selectors logic, rather than some 
seperate logic, so the fiktering expectations are the same.


---