[GitHub] activemq-artemis issue #2376: [ARTEMIS-2130]Web console display blank Client...

2018-10-24 Thread shailendra14k 
Github user shailendra14k commented on the issue:

https://github.com/apache/activemq-artemis/pull/2376
  
@michaelandrepearce @jbertram Thank you for the review. Yes, session and 
consumer models need to be re-worked and should have a generic method to 
get/set client_id accros the different client. 

I am closing this PR. 



---

[GitHub] activemq-artemis issue #2376: [ARTEMIS-2130]Web console display blank Client...

2018-10-23 Thread jbertram 
Github user jbertram commented on the issue:

https://github.com/apache/activemq-artemis/pull/2376
  
I agree with @michaelandrepearce - JMS specifics should not be built into 
the console (or any part of the core broker, for that matter).  The session 
contains generic meta-data which can be displayed on the console and then users 
can interpret that meta-data as necessary for their applications.  We've worked 
hard to get JMS stuff out of the core broker to better support other protocols. 
 Let's not add it back in.


---