[GitHub] activemq-artemis issue #2401: ARTEMIS-1710 Allow management msgs to pass the...

Github user mtaylor commented on the issue: https://github.com/apache/activemq-artemis/pull/2401 > @mtaylor I agree, having percentages is better, and will work for our use case. Great. It took me 5 minutes to write that reply and 15 minutes trying to get the formatting

[GitHub] activemq-artemis issue #2401: ARTEMIS-1710 Allow management msgs to pass the...

Github user lulf commented on the issue: https://github.com/apache/activemq-artemis/pull/2401 @mtaylor I agree, having percentages is better, and will work for our use case. ---

[GitHub] activemq-artemis issue #2401: ARTEMIS-1710 Allow management msgs to pass the...

Github user mtaylor commented on the issue: https://github.com/apache/activemq-artemis/pull/2401 > @michaelandrepearce @mtaylor Ok, just to make sure I understand this, what we have today: > > ``` > -1 > ``` > would be equivalent to: > > ``` > # >

[GitHub] activemq-artemis issue #2401: ARTEMIS-1710 Allow management msgs to pass the...

Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/2401 @lulf @michaelandrepearce I was looking to implement it as: ```xml 30 ``` Per address-settings to allow all the addresses matching it to share a 30% of the configured

[GitHub] activemq-artemis issue #2401: ARTEMIS-1710 Allow management msgs to pass the...

Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/2401 I would suggest for address settings -1 isnt used (as for other settings it typically means disable also for your above mentioned it could not be very flexible) but some

[GitHub] activemq-artemis issue #2401: ARTEMIS-1710 Allow management msgs to pass the...

Github user lulf commented on the issue: https://github.com/apache/activemq-artemis/pull/2401 @michaelandrepearce @mtaylor Ok, just to make sure I understand this, what we have today: ``` -1 ``` would be equivalent to: ``` # -1 ``` Which

[GitHub] activemq-artemis issue #2401: ARTEMIS-1710 Allow management msgs to pass the...

Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/2401 @clebertsuconic the change you propose would mean still management addresses would NOT be under the global max catch all, as it is today. Which is my initial concern and my

[GitHub] activemq-artemis issue #2401: ARTEMIS-1710 Allow management msgs to pass the...

Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/2401 @lulf if i understand @mtaylor proposal it would be that you could set address setting match to # meaning anything and set aggegate-size to the max size you want for all normal

[GitHub] activemq-artemis issue #2401: ARTEMIS-1710 Allow management msgs to pass the...

Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/2401 @clebert I will try to connect later in order to understand what you mean mate (ATM I'm on the phone) ---

[GitHub] activemq-artemis issue #2401: ARTEMIS-1710 Allow management msgs to pass the...

Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2401 @lulf / @franz1981 ok, Why not make a simpler change.. and return -1 on PaginManager if the management address. That's a lot less code to get around the sizing.

[GitHub] activemq-artemis issue #2401: ARTEMIS-1710 Allow management msgs to pass the...

Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/2401 FWIW, management can be done through JMX or REST (via Jolokia) if management messages are blocked for any reason. ---

[GitHub] activemq-artemis issue #2401: ARTEMIS-1710 Allow management msgs to pass the...

Github user lulf commented on the issue: https://github.com/apache/activemq-artemis/pull/2401 The use case is covered in https://issues.apache.org/jira/browse/ARTEMIS-1710 In a cloud-setting, we need to: a) Have the broker derive (global) limits based on things like

[GitHub] activemq-artemis issue #2401: ARTEMIS-1710 Allow management msgs to pass the...

Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2401 @franz1981 Did you mean exceed global-max-size? when I read this originally I had the impression you were setting global-max-size using management messages. I'm

[GitHub] activemq-artemis issue #2401: ARTEMIS-1710 Allow management msgs to pass the...

Github user mtaylor commented on the issue: https://github.com/apache/activemq-artemis/pull/2401 > This would work and i like the flexibility. I assume here in this option proposed. Global would remain as is today. Yes. ---

[GitHub] activemq-artemis issue #2401: ARTEMIS-1710 Allow management msgs to pass the...

Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/2401 @michaelandrepearce @lulf @mtaylor I will continue on the issue comments :+1: ---

[GitHub] activemq-artemis issue #2401: ARTEMIS-1710 Allow management msgs to pass the...

Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/2401 @mtaylor @michaelandrepearce I can't ignore all these useful comments/feedbacks guys so I will work more on this one to see if it can be done in a better way; thanks for the reviews

[GitHub] activemq-artemis issue #2401: ARTEMIS-1710 Allow management msgs to pass the...

Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/2401 This would work and i like the flexibility. I assume here in this option proposed. Global would remain as is today. ---

[GitHub] activemq-artemis issue #2401: ARTEMIS-1710 Allow management msgs to pass the...

Github user mtaylor commented on the issue: https://github.com/apache/activemq-artemis/pull/2401 I don't really like the idea of the double threshold. I think the global-max-size limit should be the catch all case. What would work better here is an accumulative-max-size

[GitHub] activemq-artemis issue #2401: ARTEMIS-1710 Allow management msgs to pass the...

Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/2401 @clebertsuconic I have added some additional unit tests on `PagingStoreImpl` ---

Re: [GitHub] activemq-artemis issue #2401: ARTEMIS-1710 Allow management msgs to pass the...

That is a sagaciously composed article and this is actually what I was searching for. Great motivational counsel, and more info just as exactly what I require. I altogether making the most of your top to bottom audit and have

[GitHub] activemq-artemis issue #2401: ARTEMIS-1710 Allow management msgs to pass the...

Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/2401 @clebertsuconic I'm fixing a couple of things on this one too ---

[GitHub] activemq-artemis issue #2401: ARTEMIS-1710 Allow management msgs to pass the...

Github user lulf commented on the issue: https://github.com/apache/activemq-artemis/pull/2401 As a user, I think the first alternative is the clearest, it explicitly states the intention and does not change any existing behavior (i.e. auto tune -1 which we already rely on). In our

[GitHub] activemq-artemis issue #2401: ARTEMIS-1710 Allow management msgs to pass the...

Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/2401 @michaelandrepearce I've started working on the alternative one based on a second level global limit, but TBH I've already found quite complex to add such condition without breaking any

[GitHub] activemq-artemis issue #2401: ARTEMIS-1710 Allow management msgs to pass the...

Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/2401 @clebertsuconic Let me run it while I'm working on an alternative version too: we can talk later about it mate? ---

[GitHub] activemq-artemis issue #2401: ARTEMIS-1710 Allow management msgs to pass the...

Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2401 @franz1981 did you run a full testsuite on this? ---

[GitHub] activemq-artemis issue #2401: ARTEMIS-1710 Allow management msgs to pass the...

Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/2401 > Surely this would be better handled with simply setting better values per address. I could be wrong (and @mtaylor or @clebertsuconic can help me to understand the conditions

[GitHub] activemq-artemis issue #2401: ARTEMIS-1710 Allow management msgs to pass the...

Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/2401 @franz1981 this seems a bit dangerous, as a user/operator i set global max as a safety net even for management messages. Surely this would be better handled with simply setting