[GitHub] activemq-artemis issue #2406: New profile to allow skipping or including the...

2018-10-31 Thread orpiske
Github user orpiske commented on the issue:

https://github.com/apache/activemq-artemis/pull/2406
  
> how to run a single test:
> 
> ```
> mvn -Ptests -DfailIfNoTests=false -Pextra-tests -DskipStyleCheck=true 
-DskipPerformanceTests=false -Dtest=$1 test
> ```
> 
> ^^^ the following is provided as ./scripts/one-test.sh from main.
> 
> and TBH: most people just use the IDE to start a single test.
> 
> or if you just want to run the integration-tests, you can call mvn 
-Ptests within integration-tests
> 
> I really don't see a reason for this profile.

The primary reason is that they want to run a couple of tests (without the 
integration ones) on the CI. 

That said: I see no reason to struggle with this without having exhausted 
other possibilities. I will close this PR and will point them to this as a 
source of some ideas. If nothing comes up that satisfies them, then we can re 
discuss this on better grounds.


---


[GitHub] activemq-artemis issue #2406: New profile to allow skipping or including the...

2018-10-31 Thread clebertsuconic
Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/2406
  
how to run a single test:


```
mvn -Ptests -DfailIfNoTests=false -Pextra-tests -DskipStyleCheck=true 
-DskipPerformanceTests=false -Dtest=$1 test
```

^^^ the following is provided as ./scripts/one-test.sh from main.


and TBH: most people just use the IDE to start a single test.

or if you just want to run the integration-tests, you can call mvn -Ptests 
within integration-tests


I really don't see a reason for this profile.



---


[GitHub] activemq-artemis issue #2406: New profile to allow skipping or including the...

2018-10-31 Thread clebertsuconic
Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/2406
  
There is a script. One-test.sh.  Or you can run the test in an ide. 


---


[GitHub] activemq-artemis issue #2406: New profile to allow skipping or including the...

2018-10-31 Thread orpiske
Github user orpiske commented on the issue:

https://github.com/apache/activemq-artemis/pull/2406
  
We have tried the proposed approach and it did not skip the integration 
tests. We received a suggestion from @andytaylor to use "-PDev" in addition to 
that. Any solution that does not involve code changes would be preferred, 
indeed.


---


[GitHub] activemq-artemis issue #2406: New profile to allow skipping or including the...

2018-10-31 Thread clebertsuconic
Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/2406
  
This is not needed at all. can you close it?


---